LeKoala\DebugBar\Extension\ControllerExtension

Complexity

Total Complexity

24

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	clearBuffer()	0	9	3
B	beforeCallActionHandler()	0	32	8
A	onBeforeInit()	0	15	3
A	afterCallActionHandler()	0	16	3
B	onAfterInit()	0	25	7

<?php

namespace LeKoala\DebugBar\Extension;

use LeKoala\DebugBar\Collector\HeaderCollector;
use LeKoala\DebugBar\Collector\SilverStripeCollector;
use LeKoala\DebugBar\DebugBar;
use SilverStripe\Control\Controller;
use SilverStripe\Core\Extension;
use SilverStripe\Security\Security;

/**
 * A controller extension to log times and render the Debug Bar
 */
class ControllerExtension extends Extension
{
    public function onBeforeInit()
    {
        DebugBar::withDebugBar(function (\DebugBar\DebugBar $debugbar) {
            // We must set the current controller when it's available and before it's pushed out of stack
            $debugbar->getCollector('silverstripe')->setController(Controller::curr());

The method setController() does not exist on DebugBar\DataCollector\DataCollectorInterface. It seems like you code against a sub-type of DebugBar\DataCollector\DataCollectorInterface such as LeKoala\DebugBar\Collector\SilverStripeCollector.

            /** @var $timeData DebugBar\DataCollector\TimeDataCollector */
            $timeData = $debugbar->getCollector('time');
            if (!$timeData) {

$timeData is of type LeKoala\DebugBar\DebugBar\DataCollector\TimeDataCollector, thus it always evaluated to true.

                return;
            }
            if ($timeData->hasStartedMeasure('pre_request')) {
                $timeData->stopMeasure("pre_request");
            }
            $timeData->startMeasure("init", get_class($this->owner) . ' init');
        });
    }

    public function onAfterInit()
    {
        // On Security, onAfterInit is called before init() in your Page method
        // jQuery is most likely not included yet
        if (!$this->owner instanceof Security) {
            DebugBar::includeRequirements();
        }

        DebugBar::withDebugBar(function (\DebugBar\DebugBar $debugbar) {
            // Add the headers Collector
            if (!$debugbar->hasCollector('Headers') && DebugBar::config()->get('header_collector')) {
                $debugbar->addCollector(new HeaderCollector($this->owner));
            }
            /** @var $timeData DebugBar\DataCollector\TimeDataCollector */
            $timeData = $debugbar->getCollector('time');
            if (!$timeData) {

$timeData is of type LeKoala\DebugBar\DebugBar\DataCollector\TimeDataCollector, thus it always evaluated to true.

                return;
            }
            if ($timeData->hasStartedMeasure("cms_init")) {
                $timeData->stopMeasure("cms_init");
            }
            if ($timeData->hasStartedMeasure("init")) {
                $timeData->stopMeasure("init");
            }
            $timeData->startMeasure("handle", get_class($this->owner) . ' handle request');
        });
    }

    /**
     * @param HTTPRequest $request

The type LeKoala\DebugBar\Extension\HTTPRequest was not found. Did you mean HTTPRequest? If so, make sure to prefix the type with \.

     * @param string $action
     */
    public function beforeCallActionHandler($request, $action)
    {
        // This could be called twice
        // TODO: check if we can remove this safely
        if ($this->owner->beforeCallActionHandlerCalled) {
            return;
        }

        // If we don't have an action, getViewer will be called immediatly
        // If we have custom routes, request action is different than action
        $allParams     = $request->allParams();
        $requestAction = null;
        if (!empty($allParams['Action'])) {
            $requestAction = $allParams['Action'];
        }
        if (!$this->owner->hasMethod($action) || ($requestAction && $requestAction != $action)) {
            self::clearBuffer();
        }

        DebugBar::withDebugBar(function (\DebugBar\DebugBar $debugBar) use ($action) {
            /** @var $timeData DebugBar\DataCollector\TimeDataCollector */
            $timeData = $debugBar->getCollector('time');
            if (!$timeData) {

$timeData is of type LeKoala\DebugBar\DebugBar\DataCollector\TimeDataCollector, thus it always evaluated to true.

                return;
            }
            if ($timeData->hasStartedMeasure("handle")) {
                $timeData->stopMeasure("handle");
            }
            $timeData->startMeasure("action", get_class($this->owner) . " action $action");
        });

        $this->owner->beforeCallActionHandlerCalled = true;
    }

    /**
     * @param HTTPRequest $request
     * @param string $action
     * @param mixed $result
     */
    public function afterCallActionHandler($request, $action, $result)

The parameter $request is not used and could be removed.

The parameter $result is not used and could be removed.

    {
        self::clearBuffer();

        DebugBar::withDebugBar(function (\DebugBar\DebugBar $debugBar) use ($action) {
            /** @var $timeData DebugBar\DataCollector\TimeDataCollector */
            $timeData = $debugBar->getCollector('time');
            if (!$timeData) {

$timeData is of type LeKoala\DebugBar\DebugBar\DataCollector\TimeDataCollector, thus it always evaluated to true.

                return;
            }
            if ($timeData->hasStartedMeasure("action")) {
                $timeData->stopMeasure("action");
            }
            $timeData->startMeasure(
                "after_action",
                get_class($this->owner) . " after action $action"
            );
        });
    }

    protected static function clearBuffer()
    {
        if (!DebugBar::$bufferingEnabled) {
            return;
        }
        $buffer = ob_get_clean();
        if (!empty($buffer)) {
            unset($_REQUEST['debug_request']); // Disable further messages that we can't intercept
            SilverStripeCollector::setDebugData($buffer);
        }
    }
}