LeKoala\DebugBar\Middleware\DebugBarMiddleware::afterRequest()

Complexity

Conditions	18
Paths	69

Size

Total Lines	76
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	0	Features	3

<?php
    protected function afterRequest(HTTPRequest $request, HTTPResponse $response)
    {
        $debugbar = DebugBar::getDebugBar();
        if (!$debugbar) {

$debugbar is of type DebugBar\DebugBar, thus it always evaluated to true.

            return;
        }
        DebugBar::setRequest($request);

        // All queries have been displayed
        if (DebugBar::getShowQueries()) {
            exit();

Using exit here is not recommended.

        }

        $script = DebugBar::renderDebugBar();

        // If the bar is not renderable, return early
        if (!$script) {
            return;
        }

        // Use module to make sure it's deferred and does not cause side effects
        $script = str_replace('<script type="text/javascript">', '<script type="module">', $script);

        // Inject init script into the HTML response
        $body = (string)$response->getBody();
        if (strpos($body, '</body>') !== false) {
            $customScripts = '';
            if (DebugBar::$suppressJquery) {
                // Move scripts after the latest script
                $matches = [];
                preg_match_all('/<script(.*) src="(.*)\/debugbar\/(.*)"><\/script>/', $body, $matches);
                $body = preg_replace('/<script(.*) src="(.*)\/debugbar\/(.*)"><\/script>\n/', '', $body);
                $customScripts = implode("\n", $matches[0]);
            }

            $scriptsToInsert = $customScripts . "\n" . $script;
            // You can use a placeholder if somehow you have a </body> string somewhere else in the body
            // @link https://github.com/lekoala/silverstripe-debugbar/issues/154
            $debugbarPlaceholder = "<!-- debugbar -->";
            if (strpos($body, $debugbarPlaceholder) !== false) {
                $body = str_replace($debugbarPlaceholder, $scriptsToInsert, $body);
            } else {
                if (Requirements::get_write_js_to_body()) {
                    // Replace the last occurence of </body>
                    $pos = strrpos($body, '</body>');
                    if ($pos !== false) {
                        $body = substr_replace($body, $scriptsToInsert . '</body>', $pos, strlen('</body>'));
                    }
                } else {
                    // Replace the first occurence of </head>
                    $pos = strpos($body, '</head>');
                    if ($pos !== false) {
                        $body = substr_replace($body, $scriptsToInsert . '</head>', $pos, strlen('</head>'));
                    }
                }
            }
            $response->setBody($body);

It seems like $body can also be of type array; however, parameter $body of SilverStripe\Control\HTTPResponse::setBody() does only seem to accept string, maybe add an additional type check?

        }

        // Ajax support
        if (Director::is_ajax() && !headers_sent()) {
            if (DebugBar::isAdminUrl() && !DebugBar::config()->get('enabled_in_admin')) {
                return;
            }
            // Skip anything that is not a GET request
            if (!$request->isGET()) {
                return;
            }
            // Always enable in admin because everything is mostly loaded through ajax
            if (DebugBar::config()->get('ajax') || DebugBar::isAdminUrl()) {
                $headers = $debugbar->getDataAsHeaders();

                // Prevent throwing js errors in case header size is too large
                if (is_array($headers)) {

The condition is_array($headers) is always true.

                    $maxHeaderLength = DebugBar::config()->get('max_header_length');
                    $debugbar->sendDataInHeaders(null, 'phpdebugbar', $maxHeaderLength);
                }