lekoala / silverstripe-common-extensions

tests/ExtensionsTest.php

<?php

namespace LeKoala\CommonExtensions\Test;

use SilverStripe\Dev\SapphireTest;
use LeKoala\CommonExtensions\IPExtension;
use SilverStripe\Control\Controller;

class ExtensionsTest extends SapphireTest
{
    /**
     * Defines the fixture file to use for this test class
     * @var string
     */
    protected static $fixture_file = 'Test_CommonExtensions.yml';

    protected static $extra_dataobjects = array(
        Test_CommonExtensions::class,
    );

    public function testHasExtensions()
    {
        $model = new Test_CommonExtensions();

        $this->assertTrue($model->hasExtension(IPExtension::class));
    }

    public function testIPExtension()
    {
        $controller = Controller::curr();

        $model = new Test_CommonExtensions();
        $model->write();
        if ($controller) {

$controller is of type SilverStripe\Control\Controller, thus it always evaluated to true.

            $this->assertNotEmpty($model->IP);

The property IP does not exist on LeKoala\CommonExtensions\Test\Test_CommonExtensions. Since you implemented __get, consider adding a @property annotation.

        }

        $ip = '127.0.0.1';
        $model->IP = $ip;

The property IP does not exist on LeKoala\CommonExtensions\Test\Test_CommonExtensions. Since you implemented __set, consider adding a @property annotation.

        $this->assertEquals($ip, $model->IP);
    }
}