LeKoala\CommonExtensions\EditorTrackingExtension

Complexity

Total Complexity

5

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	updateCMSFields()	0	9	3
A	onBeforeWrite()	0	7	2

<?php

namespace LeKoala\CommonExtensions;

use SilverStripe\Forms\FieldList;
use SilverStripe\Security\Member;
use SilverStripe\ORM\DataExtension;
use SilverStripe\Security\Security;

/**
 * Track who edited what
 *
 * @property \LeKoala\CommonExtensions\EditorTrackingExtension|\SilverStripe\ORM\DataObject $owner
 * @property int $CreatedByID
 * @property int $LastEditedByID
 * @method \SilverStripe\Security\Member CreatedBy()
 * @method \SilverStripe\Security\Member LastEditedBy()
 */
class EditorTrackingExtension extends DataExtension
{
    private static $has_one = [

The private property $has_one is not used, and could be removed.

        "CreatedBy" => Member::class,
        "LastEditedBy" => Member::class,
    ];

    public function onBeforeWrite()
    {
        $user = Security::getCurrentUser();
        if (!$this->owner->ID) {

The property ID does not exist on LeKoala\CommonExtensions\EditorTrackingExtension. Did you maybe forget to declare it?

            $this->owner->CreatedBy = $user->ID ?? 0;

The property CreatedBy does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }
        $this->owner->LastEditedBy = $user->ID ?? 0;

The property LastEditedBy does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function updateCMSFields(FieldList $fields)
    {
        $CreatedByID = $fields->dataFieldByName('CreatedByID');
        if ($CreatedByID) {
            $fields->replaceField('CreatedByID', $CreatedByID->performReadonlyTransformation());
        }
        $LastEditedByID = $fields->dataFieldByName('LastEditedByID');
        if ($LastEditedByID) {
            $fields->replaceField('LastEditedByID', $LastEditedByID->performReadonlyTransformation());
        }
    }
}