Issues in BlockButtonField.php (master) - Issues in master - lekoala/silverstripe-blocks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (81)

src/Fields/BlockButtonField.php (8 issues)

Labels

Bug 8

Severity

Minor 8

<?php

namespace LeKoala\Blocks\Fields;

use SilverStripe\Forms\TextField;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\CheckboxField;
use SilverStripe\Forms\CompositeField;
use SilverStripe\Forms\FieldGroup;

class BlockButtonField extends CompositeField
{
    public function __construct($name, $title = null, $value = null)
    {
        $children = new FieldList();

        $TitleField = TextField::create(
            "{$name}[Title]",
            'Title'
        );
        $children->push($TitleField);

        $LinkField = TextField::create(
            "{$name}[Link]",
            'Link'
        );
        $children->push($LinkField);

        $group = FieldGroup::create();
        $children->push($group);

        $NewWindowField = CheckboxField::create(
            "{$name}[NewWindow]",
            'Open in new window?'
        );
        $group->push($NewWindowField);

        $ExtraClassesField = TextField::create(
            "{$name}[ExtraClasses]",
            ''
        );
        $ExtraClassesField->setAttribute('placeholder', 'Extra Classes');
        $group->push($ExtraClassesField);

        parent::__construct($children);

        $this->setName($name);

        if ($title === null) {
            $this->title = self::name_to_label($name);
        } else {
            $this->title = $title;
        }

        if ($value !== null) {
            $this->setValue($value);
        }
    }

    public function setValue($value, $data = null)
    {
        if (is_array($value)) {
            if (isset($value['Title'])) {
                $this->getTitleField()->setValue($value['Title']);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }
            if (isset($value['Link'])) {
                $this->getLinkField()->setValue($value['Link']);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }
            if (isset($value['NewWindow'])) {
                $this->getNewWindowField()->setValue($value['NewWindow']);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }
            if (isset($value['ExtraClasses'])) {
                $this->getExtraClassesField()->setValue($value['ExtraClasses']);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            }
        }
        return parent::setValue($value, $data);
    }

    public function getTitleField()
    {
        $name = $this->name;
        return $this->fieldByName("{$name}[Title]");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function getLinkField()
    {
        $name = $this->name;
        return $this->fieldByName("{$name}[Link]");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function getNewWindowField()
    {
        $name = $this->name;
        return $this->fieldByName("{$name}[NewWindow]");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function getExtraClassesField()
    {
        $name = $this->name;
        return $this->fieldByName("{$name}[ExtraClasses]");
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1			<?php
2
3			namespace LeKoala\Blocks\Fields;
4
5			use SilverStripe\Forms\TextField;
6			use SilverStripe\Forms\FieldList;
7			use SilverStripe\Forms\CheckboxField;
8			use SilverStripe\Forms\CompositeField;
9			use SilverStripe\Forms\FieldGroup;
10
11			class BlockButtonField extends CompositeField
12			{
13			public function __construct($name, $title = null, $value = null)
14			{
15			$children = new FieldList();
16
17			$TitleField = TextField::create(
18			"{$name}[Title]",
19			'Title'
20			);
21			$children->push($TitleField);
22
23			$LinkField = TextField::create(
24			"{$name}[Link]",
25			'Link'
26			);
27			$children->push($LinkField);
28
29			$group = FieldGroup::create();
30			$children->push($group);
31
32			$NewWindowField = CheckboxField::create(
33			"{$name}[NewWindow]",
34			'Open in new window?'
35			);
36			$group->push($NewWindowField);
37
38			$ExtraClassesField = TextField::create(
39			"{$name}[ExtraClasses]",
40			''
41			);
42			$ExtraClassesField->setAttribute('placeholder', 'Extra Classes');
43			$group->push($ExtraClassesField);
44
45			parent::__construct($children);
46
47			$this->setName($name);
48
49			if ($title === null) {
50			$this->title = self::name_to_label($name);
51			} else {
52			$this->title = $title;
53			}
54
55			if ($value !== null) {
56			$this->setValue($value);
57			}
58			}
59
60			public function setValue($value, $data = null)
61			{
62			if (is_array($value)) {
63			if (isset($value['Title'])) {
64			$this->getTitleField()->setValue($value['Title']);
			0 ignored issues – show Bug introduced 2020-12-15 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->getTitleField()` targeting `LeKoala\Blocks\Fields\Bl...nField::getTitleField()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
65			}
66			if (isset($value['Link'])) {
67			$this->getLinkField()->setValue($value['Link']);
			0 ignored issues – show Bug introduced 2020-12-15 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->getLinkField()` targeting `LeKoala\Blocks\Fields\Bl...onField::getLinkField()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
68			}
69			if (isset($value['NewWindow'])) {
70			$this->getNewWindowField()->setValue($value['NewWindow']);
			0 ignored issues – show Bug introduced 2020-12-15 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->getNewWindowField()` targeting `LeKoala\Blocks\Fields\Bl...ld::getNewWindowField()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
71			}
72			if (isset($value['ExtraClasses'])) {
73			$this->getExtraClassesField()->setValue($value['ExtraClasses']);
			0 ignored issues – show Bug introduced 2020-12-15 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->getExtraClassesField()` targeting `LeKoala\Blocks\Fields\Bl...:getExtraClassesField()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
74			}
75			}
76			return parent::setValue($value, $data);
77			}
78
79			public function getTitleField()
80			{
81			$name = $this->name;
82			return $this->fieldByName("{$name}[Title]");
			0 ignored issues – show Bug introduced 2020-12-15 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->fieldByName($name.'[Title]')` targeting `SilverStripe\Forms\CompositeField::fieldByName()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
83			}
84
85			public function getLinkField()
86			{
87			$name = $this->name;
88			return $this->fieldByName("{$name}[Link]");
			0 ignored issues – show Bug introduced 2020-12-15 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->fieldByName($name.'[Link]')` targeting `SilverStripe\Forms\CompositeField::fieldByName()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
89			}
90
91			public function getNewWindowField()
92			{
93			$name = $this->name;
94			return $this->fieldByName("{$name}[NewWindow]");
			0 ignored issues – show Bug introduced 2020-12-15 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->fieldByName($name.'[NewWindow]')` targeting `SilverStripe\Forms\CompositeField::fieldByName()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
95			}
96
97			public function getExtraClassesField()
98			{
99			$name = $this->name;
100			return $this->fieldByName("{$name}[ExtraClasses]");
			0 ignored issues – show Bug introduced 2020-12-15 16:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->fieldByName($name.'[ExtraClasses]')` targeting `SilverStripe\Forms\CompositeField::fieldByName()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
101			}
102			}
103

lekoala / silverstripe-blocks

Issues (81)

src/Fields/BlockButtonField.php (8 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like