Failed Conditions
Pull Request — master (#32)
by Moesjarraf
06:49
created

SwitchChoose::choose()   A

Complexity

Conditions 2
Paths 2

Size

Total Lines 5
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 6

Importance

Changes 0
Metric Value
dl 0
loc 5
ccs 0
cts 0
cp 0
rs 9.4285
c 0
b 0
f 0
cc 2
eloc 3
nc 2
nop 2
crap 6
1
<?php
2
3
namespace LegalThings\DataEnricher\Processor;
4
5
use LegalThings\DataEnricher\Node;
6
use LegalThings\DataEnricher\Processor;
7
use LegalThings\DataEnricher\Processor\Helper;
8
9
/**
10
 * Choose one of the child properties based on a property in the document
11
 */
12
class SwitchChoose implements Processor
13
{
14
    use Processor\Implementation,
15
        Helper\GetByReference
16
    {
17
        Helper\GetByReference::withSourceAndTarget insteadof Processor\Implementation;
18
    }
19
    
20
    /**
21
     * Apply processing to a single node
22
     * 
23
     * @param Node $node
24
     */
25 1
    public function applyToNode(Node $node)
26
    {
27 1
        $instruction = $node->getInstruction($this);
28 1
29
        // for bc
30 1
        if (is_string($instruction)) {
31 1
            $cases = $node->getResult();
32 1
33
            $result = $this->choose($instruction, $cases);
0 ignored issues
show
Bug introduced by
It seems like $cases defined by $node->getResult() on line 31 can also be of type array; however, LegalThings\DataEnricher...\SwitchChoose::choose() does only seem to accept object, maybe add an additional type check?

If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check:

/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue.

Loading history...
34
            return $node->setResult($result);
35
        }
36
        
37
        if (is_array($instruction) || is_object($instruction)) {
38
            $instruction = (object)$instruction;
39
        }
40
        
41 1
        if (!isset($instruction->on) || !isset($instruction->options)) {
42
            return;
43 1
        }
44 1
        
45
        $instruction->options = (object)$instruction->options;
46
        
47
        $result = isset($instruction->default) ? $instruction->default : null;
48
        
49
        if (isset($instruction->options->{$instruction->on})) {
50
            $result = $instruction->options->{$instruction->on};
51
        }
52
        
53
        $node->setResult($result);
54
    }
55
    
56
    /**
57
     * Choose on of the cases
58
     * 
59
     * @param string $ref    Property name of source
60
     * @param object $cases
61
     * @return mixed
62
     */
63
    protected function choose($ref, $cases)
64
    {
65
        $test = $this->getByReference($ref, $this->source, $this->target);
66
        return isset($cases->$test) ? $cases->$test : null;
67
    }
68
}
69