Merge::merge() - Code Metrics - Inspection of "Fix issue with merge processor" - legalthings/data-enricher - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#15)

by Arnold

created 2016-07-11 14:06 UTC

Merge::merge() A

↳ Parent: Merge

Complexity

Conditions	4
Paths	6

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	4

Importance

Changes	3
Bugs	1	Features	2

Metric	Value
c	3
b	1
f	2
dl	0
loc	17
ccs	11
cts	11
cp	1
rs	9.2
cc	4
eloc	8
nc	6
nop	1
crap	4

<?php

namespace LegalThings\DataEnricher\Processor;

use LegalThings\DataEnricher\Node;
use LegalThings\DataEnricher\Processor;

/**
 * Merge multiple object into one
 */
class Merge implements Processor
{
    use Processor\Implementation;
    
    /**
     * Apply processing to a single node
     * 
     * @param Node $node
     */
    public function applyToNode(Node $node)
    {
        $instruction = $node->getInstruction($this);
        
        $list = $this->resolve($instruction);
        
        $result = $this->merge($list);
        $node->setResult($result);
    }
    
    /**
     * Resolve processing nodes in the instruction
     * 
     * @param array $list
     * @return array
     */
    public function resolve($list)
    {
        if ($list instanceof Node) {
            $list = $list->getResult();
        }
        
        foreach ($list as &$item) {
            if ($item instanceof Node) {
                $item = $item->getResult();
            }
        }
        
        return $list;
    }
    
    /**
     * Merge properties of an object
     * 
     * @param array $list
     * @return \stdClass|array
     */
    protected function merge(array $list)

    {
        foreach ($list as &$item) {
            if (is_object($item)) {
                $item = get_object_vars($item);
            }
        }
        
        $result = call_user_func_array('array_merge', $list);
        
        // Is associative array
        if (array_keys($result) !== array_keys(array_keys($result))) {
            $result = (object)$result;
        }
        
        return $result;
    }
}


1		<?php
2
3		namespace LegalThings\DataEnricher\Processor;
4
5		use LegalThings\DataEnricher\Node;
6		use LegalThings\DataEnricher\Processor;
7
8		/**
9		* Merge multiple object into one
10		*/
11		class Merge implements Processor
12		{
13		use Processor\Implementation;
14
15		/**
16		* Apply processing to a single node
17		*
18		* @param Node $node
19		*/
20	3	public function applyToNode(Node $node)
21		{
22	3	$instruction = $node->getInstruction($this);
23
24	3	$list = $this->resolve($instruction);
25
26	3	$result = $this->merge($list);
27	3	$node->setResult($result);
28	3	}
29
30		/**
31		* Resolve processing nodes in the instruction
32		*
33		* @param array $list
34		* @return array
35		*/
36	3	public function resolve($list)
37		{
38	3	if ($list instanceof Node) {
39		$list = $list->getResult();
40		}
41
42	3	foreach ($list as &$item) {
43	3	if ($item instanceof Node) {
44	1	$item = $item->getResult();
45	1	}
46	3	}
47
48	3	return $list;
49		}
50
51		/**
52		* Merge properties of an object
53		*
54		* @param array $list
55		* @return \stdClass\|array
56		*/
57	3	protected function merge(array $list)
		0 ignored issues – show Coding Style Best Practice introduced 2016-07-11 14:12 UTC by Report Bug Copy Issue Report Please use `__construct()` instead of a PHP4-style constructor that is named after the class. Loading history...
58		{
59	3	foreach ($list as &$item) {
60	3	if (is_object($item)) {
61	2	$item = get_object_vars($item);
62	2	}
63	3	}
64
65	3	$result = call_user_func_array('array_merge', $list);
66
67		// Is associative array
68	3	if (array_keys($result) !== array_keys(array_keys($result))) {
69	2	$result = (object)$result;
70	2	}
71
72	3	return $result;
73		}
74		}
75

legalthings / data-enricher

Pull Request — master (#15)

Merge::merge() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like