Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
12 | class DataEnricher |
||
13 | { |
||
14 | /** |
||
15 | * Default processors |
||
16 | * @var array |
||
17 | */ |
||
18 | public static $defaultProcessors = [ |
||
19 | '<ifset>' => Processor\IfSet::class, |
||
20 | '<ref>' => Processor\Reference::class, |
||
21 | '<switch>' => Processor\SwitchChoose::class, |
||
22 | '<merge>' => Processor\Merge::class, |
||
23 | '<tpl>' => Processor\Mustache::class, |
||
24 | '<src>' => Processor\Http::class, |
||
25 | '<jmespath>' => Processor\JmesPath::class, |
||
26 | '<apply>' => Processor\JmesPath::class, |
||
27 | '<transformation>' => Processor\Transform::class, |
||
28 | '<math>' => Processor\Math::class, |
||
29 | '<enrich>' => Processor\Enrich::class, |
||
30 | '<dateformat>' => Processor\DateFormat::class, |
||
31 | '<numberformat>' => Processor\NumberFormat::class, |
||
32 | '<equal>' => Processor\Equal::class, |
||
33 | '<match>' => Processor\Match::class, |
||
34 | '<replace>' => Processor\Replace::class, |
||
35 | '<if>' => Processor\IfElse::class, |
||
36 | '<join>' => Processor\Join::class, |
||
37 | '<encode>' => Processor\Encode::class, |
||
38 | '<decode>' => Processor\Decode::class, |
||
39 | '<serialize>' => Processor\Serialize::class, |
||
40 | '<unserialize>' => Processor\Unserialize::class, |
||
41 | '<hash>' => Processor\Hash::class, |
||
42 | |||
43 | // Deprecated |
||
44 | '_ref' => Processor\Reference::class, |
||
45 | '_switch' => Processor\SwitchChoose::class, |
||
46 | '_src' => Processor\Http::class, |
||
47 | '_merge' => Processor\Merge::class, |
||
48 | '_jmespath' => Processor\JmesPath::class, |
||
49 | '_tpl' => Processor\Mustache::class, |
||
50 | '_transformation' => Processor\Transform::class |
||
51 | ]; |
||
52 | |||
53 | |||
54 | /** |
||
55 | * Processors, applied in specified order. |
||
56 | * |
||
57 | * @var DataEnricher\Processor[] |
||
58 | */ |
||
59 | public $processors; |
||
60 | |||
61 | |||
62 | /** |
||
63 | * Class constructor |
||
64 | */ |
||
65 | 4 | public function __construct() |
|
66 | { |
||
67 | 4 | foreach (static::$defaultProcessors as $property => $processor) { |
|
68 | 4 | if (is_string($processor)) { |
|
69 | 4 | $processor = new $processor($property); |
|
70 | 4 | } |
|
71 | |||
72 | 4 | $this->processors[] = $processor; |
|
73 | 4 | } |
|
74 | 4 | } |
|
75 | |||
76 | /** |
||
77 | * Create processors |
||
78 | * |
||
79 | * @param object $source Data source |
||
80 | * @param array|object $target Target or dot key path |
||
81 | * @return Processor[] |
||
82 | */ |
||
83 | 1 | protected function getProcessorsFor($source, $target) |
|
84 | { |
||
85 | 1 | $processors = []; |
|
86 | |||
87 | 1 | foreach ($this->processors as $processor) { |
|
88 | 1 | $processors[] = $processor->withSourceAndTarget($source, $target); |
|
89 | 1 | } |
|
90 | |||
91 | 1 | return $processors; |
|
92 | } |
||
93 | |||
94 | |||
95 | /** |
||
96 | * Apply processing instructions |
||
97 | * |
||
98 | * @param array|object|string $target Target or dot key path |
||
99 | * @param object $source Data source |
||
100 | */ |
||
101 | 3 | public function applyTo($target, $source = null) |
|
102 | { |
||
103 | 3 | if (!isset($source)) { |
|
104 | 3 | $source = $target; |
|
105 | 3 | } |
|
106 | |||
107 | 3 | if (!is_object($source)) { |
|
108 | 2 | throw new \Exception("Data enricher on works on an object, not on a " . gettype($source)); |
|
109 | } |
||
110 | |||
111 | 1 | if (is_string($target)) { |
|
112 | $target = DotKey::on($source)->get($target); |
||
113 | } |
||
114 | |||
115 | 1 | $nodes = $this->findNodes($target); |
|
116 | 1 | $processors = $this->getProcessorsFor($source, $target); |
|
117 | |||
118 | 1 | foreach ($nodes as $node) { |
|
119 | 1 | foreach ($processors as $processor) { |
|
120 | 1 | $node->apply($processor); |
|
121 | 1 | } |
|
122 | 1 | } |
|
123 | |||
124 | 1 | $this->applyNodeResults($target); |
|
125 | 1 | } |
|
126 | |||
127 | /** |
||
128 | * Find nodes that have processing instructions |
||
129 | * |
||
130 | * @param array|object $target |
||
131 | * @return array |
||
132 | */ |
||
133 | 1 | public function findNodes(&$target) |
|
134 | { |
||
135 | 1 | $nodes = []; |
|
136 | |||
137 | 1 | foreach ($target as $key => &$value) { |
|
138 | 1 | if (is_array($value) || (is_object($value) && !$value instanceof Node)) { |
|
139 | 1 | $nodes = array_merge($nodes, $this->findNodes($value)); |
|
140 | 1 | } |
|
141 | |||
142 | 1 | if ($value instanceof \stdClass && $this->hasProcessorProperty($value)) { |
|
143 | 1 | $value = new Node($value); |
|
144 | 1 | $nodes[] = $value; |
|
145 | 1 | } |
|
146 | 1 | } |
|
147 | |||
148 | 1 | return $nodes; |
|
149 | } |
||
150 | |||
151 | /** |
||
152 | * Check if object has at leas one process property |
||
153 | * |
||
154 | * @param \stdClass $value |
||
155 | * @param Processor[] $processors |
||
|
|||
156 | * @return boolean |
||
157 | */ |
||
158 | protected function hasProcessorProperty($value) |
||
167 | |||
168 | /** |
||
169 | * Replace nodes with their results |
||
170 | * |
||
171 | * @param array|object $target |
||
172 | */ |
||
173 | 1 | View Code Duplication | protected function applyNodeResults(&$target) |
183 | } |
||
184 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italy
is not defined by the methodfinale(...)
.The most likely cause is that the parameter was removed, but the annotation was not.