LegalThings\DataEnricher\Processor\Merge

Complexity

Total Complexity

4

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	applyToNode()	0	7	1
A	merge()	0	12	3

<?php

namespace LegalThings\DataEnricher\Processor;

use LegalThings\DataEnricher\Node;
use LegalThings\DataEnricher\Processor;

/**
 * Merge multiple object into one
 */
class Merge implements Processor
{
    use Processor\Implementation;
    
    /**
     * Apply processing to a single node
     * 
     * @param Node $node
     */
    public function applyToNode($node)
    {
        $list = $node->getInstruction($this);
        
        $result = $this->merge($list);
        $node->setResult($result);
    }
    
    /**
     * Merge properties of an object
     * 
     * @param array $merge
     */
    protected function merge($merge)

The return type could not be reliably inferred; please add a @return annotation.

Please use __construct() instead of a PHP4-style constructor that is named after the class.

    {
        $value = (object)[];
        
        foreach ($merge as $object) { 
            foreach ($object as $key => $value) {
               $value->$key = $value;

It seems like the identation of this line is off (expected at least 16 spaces, but found 15).

            }
        }
        
        return $value;
    }
}