Merge::execute()   B
last analyzed

Complexity

Conditions 10
Paths 21

Size

Total Lines 42

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 26
CRAP Score 10

Importance

Changes 0
Metric Value
dl 0
loc 42
ccs 26
cts 26
cp 1
rs 7.6666
c 0
b 0
f 0
cc 10
nc 21
nop 1
crap 10

How to fix   Complexity   

Long Method

Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.

For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.

Commonly applied refactorings include:

1
<?php
2
3
namespace LegalThings\DataEnricher\Processor;
4
5
use LegalThings\DataEnricher\Node;
6
use LegalThings\DataEnricher\Processor;
7
8
/**
9
 * Merge multiple object into one
10
 */
11
class Merge implements Processor
12
{
13
    use Processor\Implementation;
14
    
15
    /**
16
     * Apply processing to a single node
17
     * 
18
     * @param Node $node
19
     */
20 13 View Code Duplication
    public function applyToNode(Node $node)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
21
    {
22 13
        $instruction = $node->getInstruction($this);
23
        
24 13
        $list = $this->resolve($instruction);
25
        
26 13
        if (isset($list) && !is_array($list)) {
27 1
            throw new \Exception("Unable to apply {$this->property} processing instruction:"
28 1
                . " Expected an array, got a " . (is_object($list) ? get_class($list) . ' ' : '') . gettype($list));
29
        }
30
        
31 12
        $result = $this->execute((array)$list);
32 11
        $node->setResult($result);
33 11
    }
34
    
35
    /**
36
     * Resolve processing nodes in the instruction
37
     * 
38
     * @param array $list
39
     * @return array
40
     */
41 13 View Code Duplication
    public function resolve($list)
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
42
    {
43 13
        if ($list instanceof Node) {
44 1
            $list = $list->getResult();
45 1
        }
46
        
47 13
        if (is_array($list)) {
48 12
            foreach ($list as &$item) {
49 11
                if ($item instanceof Node) {
50 1
                    $item = $item->getResult();
51 1
                }
52
53 11
                if ($item instanceof \Traversable) {
54 1
                    $item = iterator_to_array($item);
55 1
                }
56 12
            }
57 12
        }
58
        
59 13
        return $list;
60
    }
61
    
62
    /**
63
     * Merge properties of an object
64
     * 
65
     * @param array $list
66
     * @return \stdClass|array|string
67
     */
68 12
    protected function execute(array $list)
69
    {
70 12
        if (empty($list)) {
71 1
            return null;
72
        }
73
        
74 11
        $scalar = [];
75
        
76 11
        foreach ($list as $key => &$item) {
77 11
            if (!isset($item)) {
78 2
                unset($list[$key]);
79 2
                continue;
80
            }
81
            
82 10
            if (is_object($item)) {
83 5
                $item = get_object_vars($item);
84 5
            }
85
            
86 10
            $scalar[] = is_scalar($item);
87 11
        }
88
89 11
        if (count(array_unique($scalar)) > 1) {
90 1
            throw new \Exception("Unable to apply {$this->property} processing instruction:"
91 1
                . " Mixture of scalar and non-scalar values");
92
        }
93
        
94 10
        if (count($scalar) > 0 && $scalar[0]) {
95 2
            $result = join('', $list);
96 2
        } else {
97 8
            if (empty($list)) {
98 1
                return null;
99
            }
100 7
            $result = call_user_func_array('array_merge', $list);
101
            
102
            // Is associative array
103 7
            if (array_keys($result) !== array_keys(array_keys($result))) {
104 6
                $result = (object)$result;
105 6
            }
106
        }
107
        
108 9
        return $result;
109
    }
110
}
111
112