Complex classes like RouteMetaData often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use RouteMetaData, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 27 | class RouteMetaData implements \Serializable |
||
| 28 | { |
||
| 29 | /** |
||
| 30 | * This route objects parent |
||
| 31 | * @var ClassMetaData $classMetaData |
||
| 32 | */ |
||
| 33 | protected $class_metadata; |
||
| 34 | |||
| 35 | /** |
||
| 36 | * A string route pattern to be matched on. eg /user/:id |
||
| 37 | * @var string $route_pattern |
||
| 38 | */ |
||
| 39 | protected $route_pattern; |
||
| 40 | |||
| 41 | /** |
||
| 42 | * Any custom regex conditions that are needed when matching a route param component. |
||
| 43 | * Eg array('year' => '(19|20)\d\d') |
||
| 44 | * @var array $route_conditions |
||
| 45 | */ |
||
| 46 | protected $route_conditions = []; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * Key-value array of URL parameter names |
||
| 50 | * @var array $param_names |
||
| 51 | */ |
||
| 52 | protected $param_names = []; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * Key-value array of URL parameters with + at the end |
||
| 56 | * @var array $param_names_path |
||
| 57 | */ |
||
| 58 | protected $param_names_path = []; |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Key-value array of URL parameters populated after a match has been successful |
||
| 62 | * - or directly by using available setter |
||
| 63 | * @var array $route_params |
||
| 64 | */ |
||
| 65 | protected $route_params; |
||
| 66 | |||
| 67 | /** |
||
| 68 | * An index array of URL parameters that exist but didn't match a route pattern parameter |
||
| 69 | * Eg: pattern: /user/:id+ with url: /user/1/some/additional/params. |
||
| 70 | * The value id => 1 will go into $route_params |
||
| 71 | * All the rest will go in here. |
||
| 72 | * @var array $unmapped_route_params |
||
| 73 | */ |
||
| 74 | protected $unmapped_route_params; |
||
| 75 | |||
| 76 | /** |
||
| 77 | * The route name (must be unique) |
||
| 78 | * @var string $name |
||
| 79 | */ |
||
| 80 | protected $name; |
||
| 81 | |||
| 82 | /** |
||
| 83 | * Any array of verbs allowed on this route. |
||
| 84 | * They match the constant values defined in DrestCommon\Request\Request eg array('GET', 'POST') |
||
| 85 | * @var array $verbs |
||
| 86 | */ |
||
| 87 | protected $verbs; |
||
| 88 | |||
| 89 | /** |
||
| 90 | * Whether get requests to this route should be exposed / handled as collections |
||
| 91 | * @var boolean $collection |
||
| 92 | */ |
||
| 93 | protected $collection = false; |
||
| 94 | |||
| 95 | /** |
||
| 96 | * A handle function call for this route (if one is configured) |
||
| 97 | * @var string $handle_call |
||
| 98 | */ |
||
| 99 | protected $handle_call; |
||
| 100 | |||
| 101 | /** |
||
| 102 | * An array of fields to be exposed to the end client |
||
| 103 | * @var array $expose |
||
| 104 | */ |
||
| 105 | protected $expose = []; |
||
| 106 | |||
| 107 | |||
| 108 | /** |
||
| 109 | * Prevent expose settings lookup |
||
| 110 | * @var boolean $disable_expose |
||
| 111 | */ |
||
| 112 | protected $disable_expose; |
||
| 113 | |||
| 114 | /** |
||
| 115 | * Whether this route is open to allow OPTION requests to detail available $verbs |
||
| 116 | * -1 = not set |
||
| 117 | * 0 = not allowed |
||
| 118 | * 1 = allowed |
||
| 119 | * @var integer $allowed_option_request ; |
||
| 120 | */ |
||
| 121 | protected $allowed_option_request = -1; |
||
| 122 | |||
| 123 | |||
| 124 | /** |
||
| 125 | * Set this objects parent metadata class |
||
| 126 | * @param ClassMetaData $class_metadata |
||
| 127 | */ |
||
| 128 | 48 | public function setClassMetaData(ClassMetaData $class_metadata) |
|
| 132 | |||
| 133 | /** |
||
| 134 | * Get this classes metadata object |
||
| 135 | * @return ClassMetaData $class_metadata |
||
| 136 | */ |
||
| 137 | 31 | public function getClassMetaData() |
|
| 141 | |||
| 142 | /** |
||
| 143 | * Get this routes route pattern |
||
| 144 | * @return string $route_pattern |
||
| 145 | */ |
||
| 146 | 30 | public function getRoutePattern() |
|
| 150 | |||
| 151 | /** |
||
| 152 | * Add the route path. eg '/users/:id' |
||
| 153 | * @param string $route_pattern |
||
| 154 | */ |
||
| 155 | 45 | public function setRoutePattern($route_pattern) |
|
| 159 | |||
| 160 | /** |
||
| 161 | * Add an array of route conditions |
||
| 162 | * @param array $route_conditions |
||
| 163 | */ |
||
| 164 | 36 | public function setRouteConditions(array $route_conditions) |
|
| 170 | |||
| 171 | /** |
||
| 172 | * Get the route conditions |
||
| 173 | * @return array|null |
||
| 174 | */ |
||
| 175 | 27 | public function getRouteConditions() |
|
| 179 | |||
| 180 | /** |
||
| 181 | * Get the name of this route |
||
| 182 | * @return string $name |
||
| 183 | */ |
||
| 184 | 51 | public function getName() |
|
| 188 | |||
| 189 | /** |
||
| 190 | * Sets a unique reference name for the resource. |
||
| 191 | * If other resources are created with this name an exception is thrown (must be unique) |
||
| 192 | * @param string $name |
||
| 193 | */ |
||
| 194 | 51 | public function setName($name) |
|
| 198 | |||
| 199 | /** |
||
| 200 | * The unique named route to reference this route by |
||
| 201 | * Note that is should use the entities fully qualified class names |
||
| 202 | * @return string |
||
| 203 | */ |
||
| 204 | 30 | public function getNamedRoute() |
|
| 208 | |||
| 209 | /** |
||
| 210 | * Whether requests to this route should be handled as collections |
||
| 211 | * @param boolean $value |
||
| 212 | */ |
||
| 213 | 34 | public function setCollection($value = true) |
|
| 217 | |||
| 218 | /** |
||
| 219 | * Should this route be handled as a collection |
||
| 220 | */ |
||
| 221 | 22 | public function isCollection() |
|
| 225 | |||
| 226 | /** |
||
| 227 | * Get an array of verbs that are allowed on this route |
||
| 228 | * @return array |
||
| 229 | */ |
||
| 230 | 40 | public function getVerbs() |
|
| 234 | |||
| 235 | /** |
||
| 236 | * Add verbs that are to be allowed on this route. |
||
| 237 | * @param mixed $verbs = a single or array of verbs valid for this route. eg array('GET', 'PUT') |
||
| 238 | * @throws DrestException if verb is invalid |
||
| 239 | */ |
||
| 240 | 45 | public function setVerbs($verbs) |
|
| 250 | |||
| 251 | /** |
||
| 252 | * Inject route params onto this object without performing a match. Useful when calling a named route directly |
||
| 253 | * @param array $params - should be an associative array. keyed values are ignored |
||
| 254 | */ |
||
| 255 | 2 | public function setRouteParams(array $params = []) |
|
| 266 | |||
| 267 | /** |
||
| 268 | * Get any params that were set after a successful match |
||
| 269 | * @return array $params |
||
| 270 | */ |
||
| 271 | 25 | public function getRouteParams() |
|
| 275 | |||
| 276 | /** |
||
| 277 | * Inject unmapped route params onto this object without performing a match. |
||
| 278 | * Useful when calling a named route directly |
||
| 279 | * @param array $params - should be a keyed array. associative values are ignored |
||
| 280 | */ |
||
| 281 | public function setUnmappedRouteParams(array $params = []) |
||
| 292 | |||
| 293 | /** |
||
| 294 | * An array of fields we're allowed to expose to the client |
||
| 295 | * @param array $expose |
||
| 296 | */ |
||
| 297 | 36 | public function setExpose(array $expose) |
|
| 301 | |||
| 302 | /** |
||
| 303 | * Get the field exposure on this route |
||
| 304 | * @return array $expose |
||
| 305 | */ |
||
| 306 | 34 | public function getExpose() |
|
| 310 | |||
| 311 | /** |
||
| 312 | * Set disable expose flag |
||
| 313 | * @param bool $flag |
||
| 314 | */ |
||
| 315 | public function setDisableExpose($flag = true) |
||
| 319 | |||
| 320 | /** |
||
| 321 | * Is the expose lookup disabled |
||
| 322 | * @return bool |
||
| 323 | */ |
||
| 324 | 25 | public function isExposeDisabled() |
|
| 328 | |||
| 329 | /** |
||
| 330 | * Set the handle function call |
||
| 331 | * @param string $handle_call |
||
| 332 | */ |
||
| 333 | 36 | public function setHandleCall($handle_call) |
|
| 339 | |||
| 340 | /** |
||
| 341 | * Get the handle call function |
||
| 342 | * @return string $handle_call |
||
| 343 | */ |
||
| 344 | 4 | public function getHandleCall() |
|
| 348 | |||
| 349 | /** |
||
| 350 | * |
||
| 351 | * Does this route have an annotated handle call |
||
| 352 | */ |
||
| 353 | 37 | public function hasHandleCall() |
|
| 357 | |||
| 358 | /** |
||
| 359 | * Does this route need a handle call? Required for POST/PUT/PATCH verbs |
||
| 360 | * @return boolean $response |
||
| 361 | */ |
||
| 362 | 39 | public function needsHandleCall() |
|
| 375 | |||
| 376 | /** |
||
| 377 | * Set whether we would like to expose this route (and its verbs) to OPTIONS requests |
||
| 378 | * @param integer|boolean $value - if using integer -1 to unset, 0 for no and 1 if yes |
||
| 379 | * @throws DrestException |
||
| 380 | */ |
||
| 381 | public function setAllowedOptionRequest($value = true) |
||
| 392 | |||
| 393 | /** |
||
| 394 | * Is this route allowed to expose its verbs to OPTIONS requests |
||
| 395 | * @return integer $result -1 if not set, 0 if no and 1 if yes |
||
| 396 | */ |
||
| 397 | 2 | public function isAllowedOptionRequest() |
|
| 401 | |||
| 402 | /** |
||
| 403 | * Generate the location string from the provided object |
||
| 404 | * @param object $object |
||
| 405 | * @param string $url - the Url to be prepended to the location |
||
| 406 | * @param EntityManager $em - Optionally pass the entity manager to assist in determining a GET origin location |
||
| 407 | * @return string|false |
||
| 408 | */ |
||
| 409 | 3 | public function getOriginLocation($object, $url, EntityManager $em = null) |
|
| 428 | |||
| 429 | /** |
||
| 430 | * Does this request match the route pattern |
||
| 431 | * @param Request $request |
||
| 432 | * @param boolean $matchVerb - Whether you want to match the route using the request HTTP verb |
||
| 433 | * - useful for OPTIONS requests to provide route info |
||
| 434 | * @param string $basePath - add a base path to the route pattern |
||
| 435 | * @return boolean $result |
||
| 436 | */ |
||
| 437 | 30 | public function matches(Request $request, $matchVerb = true, $basePath = null) |
|
| 453 | |||
| 454 | /** |
||
| 455 | * Is this route specific to defined HTTP verbs |
||
| 456 | */ |
||
| 457 | 30 | public function usesHttpVerbs() |
|
| 461 | |||
| 462 | /** |
||
| 463 | * Serialise this object |
||
| 464 | * @return string |
||
| 465 | */ |
||
| 466 | 1 | public function serialize() |
|
| 491 | |||
| 492 | /** |
||
| 493 | * Un-serialise this object and reestablish it's state |
||
| 494 | * @param string $string |
||
| 495 | */ |
||
| 496 | 1 | public function unserialize($string) |
|
| 514 | } |
||
| 515 |