CheckDefinitions - Code Metrics - leedavis81/drest - Measure and Improve Code Quality continuously with Scrutinizer

CheckDefinitions A
last analyzed 2017-05-11 10:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	37
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	3
lcom	1
cbo	3
dl	37
loc	37
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	configure()	11	11	1
A	execute()	12	12	2

How to fix Duplicated Code

<?php
/**
 * This file is part of the Drest package.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 *
 * @author Lee Davis
 * @copyright Copyright (c) Lee Davis <@leedavis81>
 * @link https://github.com/leedavis81/drest/blob/master/LICENSE
 * @license http://opensource.org/licenses/MIT The MIT X License (MIT)
 */
namespace Drest\Tools\Console\Command;

use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console;

/**
 * Check Drest definitions
 */
class CheckDefinitions extends Command
{
    /**
     * @see Console\Command\Command
     */
    protected function configure()
    {
        $this
            ->setName('annotation:check')
            ->setDescription('Checks the definitions used in Entity annotations are valid.')
            ->setHelp(
                <<<EOT
                Validate that the drest definitions are correct
EOT
            );
    }

    /**
     * @see Console\Command\Command
     *
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return void
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        /* @var $drm \Drest\Manager */
        $drm = $this->getHelper('drm')->getDrestManager();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        try {
            $drm->checkDefinitions();
            $output->write('Syntax check OK' . PHP_EOL);
        } catch (\Exception $e) {
            $output->write(PHP_EOL . $e->getMessage() . PHP_EOL);
        }
    }
}


1		<?php
2		/**
3		* This file is part of the Drest package.
4		*
5		* For the full copyright and license information, please view the LICENSE
6		* file that was distributed with this source code.
7		*
8		* @author Lee Davis
9		* @copyright Copyright (c) Lee Davis <@leedavis81>
10		* @link https://github.com/leedavis81/drest/blob/master/LICENSE
11		* @license http://opensource.org/licenses/MIT The MIT X License (MIT)
12		*/
13		namespace Drest\Tools\Console\Command;
14
15		use Symfony\Component\Console\Command\Command;
16		use Symfony\Component\Console\Input\InputInterface;
17		use Symfony\Component\Console\Output\OutputInterface;
18		use Symfony\Component\Console;
19
20		/**
21		* Check Drest definitions
22		*/
23	View Code Duplication	class CheckDefinitions extends Command
24		{
25		/**
26		* @see Console\Command\Command
27		*/
28		protected function configure()
29		{
30		$this
31		->setName('annotation:check')
32		->setDescription('Checks the definitions used in Entity annotations are valid.')
33		->setHelp(
34		<<<EOT
35		Validate that the drest definitions are correct
36		EOT
37		);
38		}
39
40		/**
41		* @see Console\Command\Command
42		*
43		* @param InputInterface $input
44		* @param OutputInterface $output
45		* @return void
46		*/
47		protected function execute(InputInterface $input, OutputInterface $output)
48		{
49		/* @var $drm \Drest\Manager */
50		$drm = $this->getHelper('drm')->getDrestManager();
		0 ignored issues – show Bug introduced 2016-08-02 10:08 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Helper\HelperInterface` as the method `getDrestManager()` does only exist in the following implementations of said interface: `Drest\Tools\Console\Helper\DrestManagerHelper`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
51
52		try {
53		$drm->checkDefinitions();
54		$output->write('Syntax check OK' . PHP_EOL);
55		} catch (\Exception $e) {
56		$output->write(PHP_EOL . $e->getMessage() . PHP_EOL);
57		}
58		}
59		}
60

leedavis81 / drest

CheckDefinitions A last analyzed 2017-05-11 10:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Duplication Side-by-Side

Filter issues like

CheckDefinitions A
last analyzed 2017-05-11 10:14 UTC