Lechimp\Dicto\Analysis\Result

Complexity

Total Complexity

10

Size/Duplication

Total Lines	83
Duplicated Lines	38.55 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

94.12%

Importance

Changes	3
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	ruleset()	0	3	1
A	violations_of()	16	16	4
A	violations_in()	16	16	4

<?php
/******************************************************************************
 * An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
 * 
 * Copyright (c) 2016, 2015 Richard Klees <richard.klees@rwth-aachen.de>
 *
 * This software is licensed under The MIT License. You should have received 
 * a copy of the licence along with the code.
 */

namespace Lechimp\Dicto\Analysis;
use Lechimp\Dicto\Definition as Def;
use Lechimp\Dicto\Rules\Rule;

class Result {
    /**
     * @var Def\Ruleset
     */
    protected $ruleset;

    /**
     * @var Violation[] 
     */
    protected $violations;

    /**
     * @var array
     */
    protected $by_rule_cache;

    /**
     * @var array
     */
    protected $by_filename_cache;

    /**
     * @param   Def\Ruleset     $ruleset
     * @param   Violations[]    $violations
     */
    public function __construct(Def\Ruleset $ruleset, array $violations) {
        $this->ruleset = $ruleset;
        $this->violations = array_map(function(Violation $v) {
            return $v;
        }, $violations);
        $this->by_rule_cache = array();
        $this->by_filename_cache = array();
    }

    /**
     * @return  Def\Ruleset
     */
    public function ruleset() {
        return $this->ruleset;
    }

    /**
     * @param   Def\Rules\Rule  $rule
     * @return  Violation[]
     */
    public function violations_of(Rule $rule) {

This method seems to be duplicated in your project.

        $r = $rule->pprint();
        if (array_key_exists($r, $this->by_rule_cache)) {
            return $this->by_rule_cache[$r];
        }

        $vs = array();
        foreach ($this->violations as $v) {
            if ($v->rule() == $rule) {
                $vs[] = $v;
            }
        }

        $this->by_rule_cache[$r] = $vs;
        return $vs;
    }

    /**
     * @param   string          $filename
     * @return  Violation[]
     */
    public function violations_in($filename) {

This method seems to be duplicated in your project.

        assert('is_string($filename)');
        if (array_key_exists($filename, $this->by_filename_cache)) {
            return $this->by_filename_cache[$filename];
        }

        $vs = array();
        foreach ($this->violations as $v) {
            if ($v->filename() == $filename) {
                $vs[] = $v;
            }
        }

        $this->by_filename_cache[$filename] = $vs;
        return $vs;
    }
}