BaseVisitor::leaveNode() - Code Metrics - Inspection of "further compression" - lechimp-p/dicto.php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 605cf4...2dcac2 )

by Richard

created 2016-11-06 17:30 UTC

BaseVisitor::leaveNode() B

↳ Parent: BaseVisitor

Complexity

Conditions	6
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	8
cts	8
cp	1
rs	8.8571
c	0
b	0
f	0
cc	6
eloc	7
nc	2
nop	1
crap	6

<?php
/******************************************************************************
 * An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
 *
 * Copyright (c) 2016, 2015 Richard Klees <[email protected]>
 *
 * This software is licensed under The MIT License. You should have received
 * a copy of the license along with the code.
 */

namespace Lechimp\Dicto\Indexer;

use Lechimp\Dicto\Variables\Variable;
use PhpParser\Node as N;

/**
 * Visitor for the AST used by Indexer.
 */
class BaseVisitor implements \PhpParser\NodeVisitor {
    /**
     * @var LocationImpl
     */
    protected $location;

    /**
     * @var Insert
     */
    protected $insert;

    /**
     * This is used to exit early in enterNode and to break enterNode apart
     * into many methods.
     *
     * @var array<string,string>
     */
    protected $jump_labels;

    public function __construct(LocationImpl $location, Insert $insert) {
        $this->location = $location;
        $this->insert = $insert;
        $this->jump_labels =
            [ N\Stmt\Namespace_::class => "enterNamespace"

            , N\Stmt\Class_::class => "enterClass"
            , N\Stmt\Interface_::class => "enterInterface"
            , N\Stmt\Trait_::class => "enterTrait"
            , N\Stmt\ClassMethod::class => "enterMethod"
            , N\Stmt\Function_::class => "enterFunction"
            ];
    }

    // from \PhpParser\NodeVisitor

    /**
     * @inheritdoc
     */
    public function beforeTraverse(array $nodes) {
        $handle = $this->insert->_file($this->location->_file_name(), $this->location->_file_content());
        $this->location->push_entity(Variable::FILE_TYPE, $handle);
    }

    /**
     * @inheritdoc
     */
    public function afterTraverse(array $nodes) {
    }

    /**
     * @inheritdoc
     */
    public function enterNode(\PhpParser\Node $node) {
        $cls = get_class($node);
        if (isset($this->jump_labels[$cls])) {
            $this->location->set_current_node($node);
            $start_line = $node->getAttribute("startLine");
            $end_line = $node->getAttribute("endLine");
            list($type, $handle) = $this->{$this->jump_labels[$cls]}
                                                ($node, $start_line, $end_line);
            $this->location->push_entity($type, $handle);
            $this->location->flush_current_node();
        }
    }

    public function enterNamespace(N\Stmt\Namespace_ $node, $start_line, $end_line) {

        $handle = $this->insert->_namespace
            ( "".$node->name // force string representation
            );
        return [Variable::NAMESPACE_TYPE, $handle];
    }

    public function enterClass(N\Stmt\Class_ $node, $start_line, $end_line) {

        $handle = $this->insert->_class
            ( $node->name
            , $this->location->_file()
            , $start_line
            , $end_line
            , $this->location->_namespace()
            );
        return [Variable::CLASS_TYPE, $handle];
    }

    public function enterInterface(N\Stmt\Interface_ $node, $start_line, $end_line) {

        $handle = $this->insert->_interface
            ( $node->name
            , $this->location->_file()
            , $start_line
            , $end_line
            , $this->location->_namespace()
            );
        return [Variable::INTERFACE_TYPE, $handle];
    }

    public function enterTrait(N\Stmt\Trait_ $node, $start_line, $end_line) {

        $handle = $this->insert->_trait
            ( $node->name
            , $this->location->_file()
            , $start_line
            , $end_line
            , $this->location->_namespace()
            );
        return [Variable::INTERFACE_TYPE, $handle];
    }

    public function enterMethod(N\Stmt\ClassMethod $node, $start_line, $end_line) {
        $handle = $this->insert->_method
            ( $node->name
            , $this->location->_class_interface_trait()
            , $this->location->_file()
            , $start_line
            , $end_line
            );
        return [Variable::METHOD_TYPE, $handle];
    }

    public function enterFunction(N\Stmt\Function_ $node, $start_line, $end_line) {
        $handle = $this->insert->_function
            ( $node->name
            , $this->location->_file()
            , $start_line
            , $end_line
            );
        return [Variable::FUNCTION_TYPE, $handle];
    }

    /**
     * @inheritdoc
     */
    public function leaveNode(\PhpParser\Node $node) {
        if (  $node instanceof N\Stmt\Namespace_
           || $node instanceof N\Stmt\Class_
           || $node instanceof N\Stmt\Interface_
           || $node instanceof N\Stmt\ClassMethod
           || $node instanceof N\Stmt\Function_) {

            $this->location->pop_entity();
        }
    }
}


1			<?php
2			/******************************************************************************
3			* An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
4			*
5			* Copyright (c) 2016, 2015 Richard Klees <[email protected]>
6			*
7			* This software is licensed under The MIT License. You should have received
8			* a copy of the license along with the code.
9			*/
10
11			namespace Lechimp\Dicto\Indexer;
12
13			use Lechimp\Dicto\Variables\Variable;
14			use PhpParser\Node as N;
15
16			/**
17			* Visitor for the AST used by Indexer.
18			*/
19			class BaseVisitor implements \PhpParser\NodeVisitor {
20			/**
21			* @var LocationImpl
22			*/
23			protected $location;
24
25			/**
26			* @var Insert
27			*/
28			protected $insert;
29
30			/**
31			* This is used to exit early in enterNode and to break enterNode apart
32			* into many methods.
33			*
34			* @var array<string,string>
35			*/
36			protected $jump_labels;
37
38	53		public function __construct(LocationImpl $location, Insert $insert) {
39	53		$this->location = $location;
40	53		$this->insert = $insert;
41	53		$this->jump_labels =
42			[ N\Stmt\Namespace_::class => "enterNamespace"
			0 ignored issues – show Documentation Bug introduced 2016-11-01 15:42 UTC by Report Bug Copy Issue Report It seems like `array(\PhpParser\Node\St...ass => 'enterFunction')` of type `array<string\|integer,string>` is incompatible with the declared type `array<string,string>` of property `$jump_labels`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
43	53		, N\Stmt\Class_::class => "enterClass"
44	53		, N\Stmt\Interface_::class => "enterInterface"
45	53		, N\Stmt\Trait_::class => "enterTrait"
46	53		, N\Stmt\ClassMethod::class => "enterMethod"
47	53		, N\Stmt\Function_::class => "enterFunction"
48	53		];
49	53		}
50
51			// from \PhpParser\NodeVisitor
52
53			/**
54			* @inheritdoc
55			*/
56	53		public function beforeTraverse(array $nodes) {
57	53		$handle = $this->insert->_file($this->location->_file_name(), $this->location->_file_content());
58	53		$this->location->push_entity(Variable::FILE_TYPE, $handle);
59	53		}
60
61			/**
62			* @inheritdoc
63			*/
64	53		public function afterTraverse(array $nodes) {
65	53		}
66
67			/**
68			* @inheritdoc
69			*/
70	53		public function enterNode(\PhpParser\Node $node) {
71	53		$cls = get_class($node);
72	53		if (isset($this->jump_labels[$cls])) {
73	51		$this->location->set_current_node($node);
74	51		$start_line = $node->getAttribute("startLine");
75	51		$end_line = $node->getAttribute("endLine");
76	51		list($type, $handle) = $this->{$this->jump_labels[$cls]}
77	51		($node, $start_line, $end_line);
78	51		$this->location->push_entity($type, $handle);
79	51		$this->location->flush_current_node();
80	51		}
81	53		}
82
83	7		public function enterNamespace(N\Stmt\Namespace_ $node, $start_line, $end_line) {
			0 ignored issues – show Unused Code introduced 2016-11-01 15:42 UTC by Report Bug Copy Issue Report The parameter `$start_line` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2016-11-01 15:42 UTC by Report Bug Copy Issue Report The parameter `$end_line` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
84	7		$handle = $this->insert->_namespace
85	7		( "".$node->name // force string representation
86	7		);
87	7		return [Variable::NAMESPACE_TYPE, $handle];
88			}
89
90	44	View Code Duplication	public function enterClass(N\Stmt\Class_ $node, $start_line, $end_line) {
			0 ignored issues – show Duplication introduced 2016-11-01 15:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91	44		$handle = $this->insert->_class
92	44		( $node->name
93	44		, $this->location->_file()
94	44		, $start_line
95	44		, $end_line
96	44		, $this->location->_namespace()
97	44		);
98	44		return [Variable::CLASS_TYPE, $handle];
99			}
100
101	3	View Code Duplication	public function enterInterface(N\Stmt\Interface_ $node, $start_line, $end_line) {
			0 ignored issues – show Duplication introduced 2016-11-01 15:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
102	3		$handle = $this->insert->_interface
103	3		( $node->name
104	3		, $this->location->_file()
105	3		, $start_line
106	3		, $end_line
107	3		, $this->location->_namespace()
108	3		);
109	3		return [Variable::INTERFACE_TYPE, $handle];
110			}
111
112	3	View Code Duplication	public function enterTrait(N\Stmt\Trait_ $node, $start_line, $end_line) {
			0 ignored issues – show Duplication introduced 2016-11-01 15:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
113	3		$handle = $this->insert->_trait
114	3		( $node->name
115	3		, $this->location->_file()
116	3		, $start_line
117	3		, $end_line
118	3		, $this->location->_namespace()
119	3		);
120	3		return [Variable::INTERFACE_TYPE, $handle];
121			}
122
123	38		public function enterMethod(N\Stmt\ClassMethod $node, $start_line, $end_line) {
124	38		$handle = $this->insert->_method
125	38		( $node->name
126	38		, $this->location->_class_interface_trait()
127	38		, $this->location->_file()
128	38		, $start_line
129	38		, $end_line
130	38		);
131	38		return [Variable::METHOD_TYPE, $handle];
132			}
133
134	4		public function enterFunction(N\Stmt\Function_ $node, $start_line, $end_line) {
135	4		$handle = $this->insert->_function
136	4		( $node->name
137	4		, $this->location->_file()
138	4		, $start_line
139	4		, $end_line
140	4		);
141	4		return [Variable::FUNCTION_TYPE, $handle];
142			}
143
144			/**
145			* @inheritdoc
146			*/
147	53		public function leaveNode(\PhpParser\Node $node) {
148			if ( $node instanceof N\Stmt\Namespace_
149	53		\|\| $node instanceof N\Stmt\Class_
150	53		\|\| $node instanceof N\Stmt\Interface_
151	49		\|\| $node instanceof N\Stmt\ClassMethod
152	53		\|\| $node instanceof N\Stmt\Function_) {
153
154	50		$this->location->pop_entity();
155	50		}
156	53		}
157			}
158

lechimp-p / dicto.php

Push — master ( 605cf4...2dcac2 )

BaseVisitor::leaveNode() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like