Lechimp\Dicto\App\SourceStatusGit

Complexity

Total Complexity

3

Size/Duplication

Total Lines	27
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

90.91%

Importance

Changes	2
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	commit_hash()	0	9	2

<?php
/******************************************************************************
 * An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
 * 
 * Copyright (c) 2016 Richard Klees <richard.klees@rwth-aachen.de>
 *
 * This software is licensed under The MIT License. You should have received 
 * a copy of the licence along with the code.
 */

namespace Lechimp\Dicto\App;

/**
 * Get the current state of the sourcecode by using git.
 */
class SourceStatusGit implements SourceStatus {
    /**
     * @var string
     */
    protected $path;

    /**
     * @param   string  $path
     */
    public function __construct($path) {
        assert('is_string($path)');
        $this->path = $path;
    }

    /**
     * @inheritdoc
     */
    public function commit_hash() {
        $escaped_path = escapeshellarg($this->path);
        $command = "git -C $escaped_path rev-parse HEAD";
        exec($command, $output, $returned);
        if ($returned != 0) {

It seems like you are loosely comparing $returned of type integer|null to 0; this is ambiguous as not only 0 == 0 is true, but null == 0 is true, too. Consider using a strict comparison ===.

            throw new \RuntimeException(implode("\n", $output));
        }
        return $output[0];
    }
}