Lechimp\Dicto\Variables\Except

Complexity

Total Complexity

5

Size/Duplication

Total Lines	32
Duplicated Lines	43.75 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	id()	0	3	1
A	compile()	14	20	4

<?php
/******************************************************************************
 * An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
 * 
 * Copyright (c) 2016, 2015 Richard Klees <richard.klees@rwth-aachen.de>
 *
 * This software is licensed under The MIT License. You should have received 
 * a copy of the license along with the code.
 */

namespace Lechimp\Dicto\Variables;

use Lechimp\Dicto\Graph\Node;

class Except extends Combinator {
    /**
     * @inheritdocs
     */
    public function id() {
        return "except";
    }

    /**
     * @inheritdocs
     */
    public function compile($negate = false) {
        $left_condition = $this->left()->compile($negate);
        $right_condition = $this->right()->compile($negate);

        // normal case: left_condition and not right_condition
        if (!$negate) {

This code seems to be duplicated across your project.

            return function(Node $n) use ($left_condition, $right_condition) {
                return $left_condition($n)
                    && !$right_condition($n);
            };
        }
        // negated case: not (left_condition and not right_condition)
        //             = not left_condition or right_condition
        else {
            return function(Node $n) use ($left_condition, $right_condition) {
                return $left_condition($n)
                    || !$right_condition($n);
            };
        }
    }
}