Lechimp\Dicto\Variables\Name

Complexity

Total Complexity

8

Size/Duplication

Total Lines	42
Duplicated Lines	23.81 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

89.47%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	name()	0	3	1
A	fetch_arguments()	0	4	1
A	arguments_are_valid()	10	10	4
A	compile()	0	8	2

<?php
/******************************************************************************
 * An implementation of dicto (scg.unibe.ch/dicto) in and for PHP.
 * 
 * Copyright (c) 2016, 2015 Richard Klees <richard.klees@rwth-aachen.de>
 *
 * This software is licensed under The MIT License. You should have received 
 * a copy of the license along with the code.
 */

namespace Lechimp\Dicto\Variables;

use Lechimp\Dicto\Graph\Node;
use Lechimp\Dicto\Definition\ArgumentParser;

/**
 * Name is a property, right?
 */
class Name extends Property {
    /**
     * @inheritdocs
     */
    public function name() {

Please use __construct() instead of a PHP4-style constructor that is named after the class.

        return "name";
    }

    /**
     * @inheritdocs
     */
    public function fetch_arguments(ArgumentParser $parser) {
        $regexp = $parser->fetch_string();
        return array($regexp);
    }

    /**
     * @inheritdocs
     */
    public function arguments_are_valid(array &$arguments) {

This method seems to be duplicated in your project.

        if (count($arguments) != 1) {
            return false;
        }
        $regexp = $arguments[0];
        if (!is_string($regexp) || @preg_match("%^$regexp\$%", "") === false) {
            return false;
        }
        return true;
    }

    /**
     * @inheritdocs
     */
    public function compile(array &$arguments) {
        assert('$this->arguments_are_valid($arguments)');
        $regexp = $arguments[0];
        return function (Node $n) use ($regexp) {
            return $n->has_property("name")
                && preg_match("%^$regexp\$%", $n->property("name")) == 1;
        };
    }
}