ViddlerError - Code Metrics - Inspection of "Added a logging option for debugging" - leadthread/laravel-viddler-upload - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Tyler

created 2017-08-08 18:16 UTC

ViddlerError A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	30
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	2
lcom	1
cbo	1
dl	30
loc	30
ccs	6
cts	6
cp	1
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	5	5	1
A	broadcastOn()	4	4	1

How to fix Duplicated Code

<?php

namespace LeadThread\Viddler\Upload\Events;

use Illuminate\Contracts\Broadcasting\ShouldBroadcast;
use Illuminate\Queue\SerializesModels;
use LeadThread\Viddler\Upload\Models\Viddler;

class ViddlerError implements ShouldBroadcast

{
    use SerializesModels;

    public $model;
    public $error;

    /**
     * Create a new event instance.
     *
     * @param  Viddler  $model
     * @param string $error
     * @return void

     */
    public function __construct(Viddler $model, $error)
    {
        $this->model = $model;
        $this->error = $error;
    }

    /**
     * Get the channels the event should be broadcast on.
     *
     * @return string[]
     */
    public function broadcastOn()
    {
        return ['viddler.'.$this->model->id];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}


1			<?php
2
3			namespace LeadThread\Viddler\Upload\Events;
4
5			use Illuminate\Contracts\Broadcasting\ShouldBroadcast;
6			use Illuminate\Queue\SerializesModels;
7			use LeadThread\Viddler\Upload\Models\Viddler;
8
9		View Code Duplication	class ViddlerError implements ShouldBroadcast
			0 ignored issues – show Duplication introduced 2017-04-20 16:50 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10			{
11			use SerializesModels;
12
13			public $model;
14			public $error;
15
16			/**
17			* Create a new event instance.
18			*
19			* @param Viddler $model
20			* @param string $error
21			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-04-20 16:50 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
22			*/
23	6		public function __construct(Viddler $model, $error)
24			{
25	6		$this->model = $model;
26	6		$this->error = $error;
27	6		}
28
29			/**
30			* Get the channels the event should be broadcast on.
31			*
32			* @return string[]
33			*/
34	6		public function broadcastOn()
35			{
36	6		return ['viddler.'.$this->model->id];
			0 ignored issues – show Documentation introduced 2017-04-20 16:50 UTC by Report Bug Copy Issue Report The property `id` does not exist on `object<LeadThread\Viddler\Upload\Models\Viddler>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
37			}
38			}
39

leadthread / laravel-viddler-upload

Pull Request — master (#6)

ViddlerError A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like