leadthread /
laravel-shortener
| Conditions | 4 |
| Paths | 6 |
| Total Lines | 16 |
| Code Lines | 9 |
| Lines | 16 |
| Ratio | 100 % |
| Tests | 10 |
| CRAP Score | 4 |
| Changes | 0 | ||
| 1 | <?php |
||
| 20 | 21 | View Code Duplication | public function shorten($url, $encode = true) |
|
|
|||
| 21 | { |
||
| 22 | 21 | $short = false; |
|
| 23 | |||
| 24 | 21 | foreach ($this->drivers as $driver) { |
|
| 25 | 21 | if(!is_string($short)){ |
|
| 26 | 21 | $short = $this->handle($driver, $url, $encode); |
|
| 27 | 21 | } |
|
| 28 | 21 | } |
|
| 29 | |||
| 30 | 21 | if(is_string($short)){ |
|
| 31 | 15 | return $short; |
|
| 32 | } else { |
||
| 33 | 9 | throw new ShortenerException($this->error); |
|
| 34 | } |
||
| 35 | } |
||
| 36 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.