Issues in index.php (main) - Issues in main - leCheveuCodeur/Blog_PHP - Measure and Improve Code Quality continuously with Scrutinizer

Issues (19)

public/index.php (2 issues)

Labels

Bug 2

Severity

Minor 2

<?php

use Core\Services\Globals\Globals;

define('ROOT', dirname(__DIR__));

require ROOT . '/app/App.php';
App::load();
$globals = new Globals;

$page = ($globals->getGET('p')) ?? 'home.index';

$page = explode('.', $page);
if ($page[0] === 'admin') {
    $controller = '\App\Controller\Admin\\' . ucfirst($page[1]) . 'Controller';
    $action = $page[2];
    $id = (!empty($page[3]) && ($page[2] !== 'index' && $page[2] !== 'add')) ? $page[3] : null;
} else {
    $controller = '\App\Controller\\' . ucfirst($page[0]) . 'Controller';
    $action = $page[1];
    $id = $page[2] ?? null;
    $paging = $page[3] ?? null;
}

if (!class_exists($controller)) {
    return \header('Location: index.php');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
}

$controller = new $controller;

try {
    if (!empty($id) && !empty($paging)) {
        return $controller->$action($id, $paging);
    }
    return !empty($id) ? $controller->$action($id) : $controller->$action();
} catch (ArgumentCountError  $e) {
    return \header('Location: index.php');
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
}


1			<?php
2
3			use Core\Services\Globals\Globals;
4
5			define('ROOT', dirname(__DIR__));
6
7			require ROOT . '/app/App.php';
8			App::load();
9			$globals = new Globals;
10
11			$page = ($globals->getGET('p')) ?? 'home.index';
12
13			$page = explode('.', $page);
14			if ($page[0] === 'admin') {
15			$controller = '\App\Controller\Admin\\' . ucfirst($page[1]) . 'Controller';
16			$action = $page[2];
17			$id = (!empty($page[3]) && ($page[2] !== 'index' && $page[2] !== 'add')) ? $page[3] : null;
18			} else {
19			$controller = '\App\Controller\\' . ucfirst($page[0]) . 'Controller';
20			$action = $page[1];
21			$id = $page[2] ?? null;
22			$paging = $page[3] ?? null;
23			}
24
25			if (!class_exists($controller)) {
26			return \header('Location: index.php');
			0 ignored issues – show Bug introduced 2021-06-30 05:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `header('Location: index.php')` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
27			}
28
29			$controller = new $controller;
30
31			try {
32			if (!empty($id) && !empty($paging)) {
33			return $controller->$action($id, $paging);
34			}
35			return !empty($id) ? $controller->$action($id) : $controller->$action();
36			} catch (ArgumentCountError $e) {
37			return \header('Location: index.php');
			0 ignored issues – show Bug introduced 2021-06-30 05:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `header('Location: index.php')` is correct as it seems to always return `null`. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
38			}
39

leCheveuCodeur / Blog_PHP

Issues (19)

public/index.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like