HasOTP::setTOTP() - Code Metrics - lbhurtado/missive - Measure and Improve Code Quality continuously with Scrutinizer

HasOTP::setTOTP() A
last analyzed 2019-09-14 23:35 UTC

↳ Parent: HasOTP

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

namespace LBHurtado\Missive\Traits;

use OTPHP\TOTP;
use OTPHP\Factory;
use OTPHP\TOTPInterface;

trait HasOTP
{
    public function setTOTP(TOTPInterface $totp)
    {
        $totp->setLabel('[email protected]');
        $this->URI = $totp->getProvisioningUri();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }

    public function getTOTP(): TOTPInterface
    {
        return Factory::loadFromProvisioningUri($this->URI);
    }

    public function challenge($notification = null)

    {
        tap(TOTP::create(null, 360), function ($totp) {
            $this->setTOTP($totp);
        });

        return $this;
    }

    public function verify($otp)
    {
        $verified = $this->getTOTP()->verify($otp);

        if ($verified) $this->forceFill(['verified_at' => now()])->save();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }

    public function verified()
    {
        return $this->verified_at && $this->verified_at <= now();
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace LBHurtado\Missive\Traits;
4
5			use OTPHP\TOTP;
6			use OTPHP\Factory;
7			use OTPHP\TOTPInterface;
8
9			trait HasOTP
10			{
11			public function setTOTP(TOTPInterface $totp)
12			{
13			$totp->setLabel('[email protected]');
14			$this->URI = $totp->getProvisioningUri();
			0 ignored issues – show Bug introduced 2019-09-04 14:07 UTC by Report Bug Copy Issue Report The property `URI` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15			$this->save();
			0 ignored issues – show Bug introduced 2019-09-04 14:07 UTC by Report Bug Copy Issue Report It seems like `save()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16
17			return $this;
18			}
19
20			public function getTOTP(): TOTPInterface
21			{
22			return Factory::loadFromProvisioningUri($this->URI);
23			}
24
25			public function challenge($notification = null)
			0 ignored issues – show Unused Code introduced 2019-09-04 14:07 UTC by Report Bug Copy Issue Report The parameter `$notification` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
26			{
27			tap(TOTP::create(null, 360), function ($totp) {
28			$this->setTOTP($totp);
29			});
30
31			return $this;
32			}
33
34			public function verify($otp)
35			{
36			$verified = $this->getTOTP()->verify($otp);
37
38			if ($verified) $this->forceFill(['verified_at' => now()])->save();
			0 ignored issues – show Bug introduced 2019-09-04 14:07 UTC by Report Bug Copy Issue Report It seems like `forceFill()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39
40			return $this;
41			}
42
43			public function verified()
44			{
45			return $this->verified_at && $this->verified_at <= now();
			0 ignored issues – show Bug introduced 2019-09-04 14:07 UTC by Report Bug Copy Issue Report The property `verified_at` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
46			}
47			}
48

lbhurtado / missive

GitHub Access Token became invalid

HasOTP::setTOTP() A last analyzed 2019-09-14 23:35 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

HasOTP::setTOTP() A
last analyzed 2019-09-14 23:35 UTC