Issues in EngageSparkChannel.php (master) - Issues in master - lbhurtado/engagespark - Measure and Improve Code Quality continuously with Scrutinizer

Issues (11)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/EngageSparkChannel.php (2 issues)

Labels

Bug 2

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace LBHurtado\EngageSpark;

use Illuminate\Support\Arr;
use Illuminate\Notifications\Notification;
use Propaganistas\LaravelPhone\PhoneNumber;

class EngageSparkChannel
{
    /** @var string */
    private $mode;

    /** @var string */
    private $clientRef;

    /** @var EngageSpark */
    protected $smsc;

    public function __construct(EngageSpark $smsc)
    {
        $this->smsc = $smsc;
    }

    /**
     * Send the given notification.
     *
     * @param  mixed  $notifiable
     * @param  Notification  $notification
     *
     * @return void
     */
    public function send($notifiable, Notification $notification)
    {
        if (! ($to = $this->getRecipients($notifiable, $notification))) {
            return;
        }

        $message = $notification->{'toEngageSpark'}($notifiable);

        if (\is_string($message)) {
            $message = new EngageSparkMessage($message);
        }

        $this->setClientRef($notification)->sendMessage($to, $message);
    }

    /**
     * Gets a list of phones from the given notifiable.
     *
     * @param  mixed  $notifiable
     * @param  Notification  $notification
     *
     * @return string[]
     */
    protected function getRecipients($notifiable, Notification $notification)
    {
        return $this->getRecipient($notifiable, $notification);
    }

    /**
     * Gets a list of phones from the given notifiable.
     *
     * @param  mixed  $notifiable
     * @param  Notification  $notification
     *
     * @return string[]
     */
    protected function getRecipient($notifiable, Notification $notification)
    {
        $to = $notifiable->routeNotificationFor('engage_spark', $notification);

        if ($to === null || $to === false || $to === []) {
            return '';
        }

        $to = \is_array($to) ? Arr::first($to) : $to;

        return $this->getFormattedMobile($to);
    }

    protected function sendMessage($recipient, EngageSparkMessage $message)
    {
        $this->setMode($message);

        switch ($mode = $this->getMode()) {
            case 'sms':
                $params = [
                    'orgId'   => $this->getOrgId(),
                    'to'      => $recipient,
                    'message' => $message->content,
                    'from'    => $this->getSenderId($message),
                ];
                break;

            case 'topup':
                $params = [
                    'organizationId'  => $this->getOrgId(),
                    'phoneNumber'     => $recipient,
                    'maxAmount'       => $message->air_time,
                    'clientRef'       => $this->getClientRef(),
                ];
                break;

            default:
                # code...
                break;
        }

        // if ($message->sendAt instanceof \DateTimeInterface) {
        //     $params['time'] = '0'.$message->sendAt->getTimestamp();
        // }

        $this->smsc->send($params, $mode);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
    }

    protected function getWebHook(EngageSparkMessage $message)
    {
        return $this->smsc->getWebHook($message->mode);

    }

    protected function getOrgId()
    {
        return $this->smsc->getOrgId();
    }

    public function getClientRef()
    {
        return $this->clientRef;
    }

    protected function getSenderId(EngageSparkMessage $message)
    {
        return $message->sender_id ? $message->sender_id : $this->smsc->getSenderId();
    }

    protected function setClientRef(Notification $notification)
    {
        $this->clientRef = $notification->id;

        return $this;
    }

    protected function getMode()
    {
        return $this->mode;
    }

    protected function setMode(EngageSparkMessage $message)
    {
        $this->mode = $message->mode;

        return $this;
    }

    protected function getFormattedMobile($to)
    {
        return tap(PhoneNumber::make($to, 'PH')->formatE164(), function(&$recipient) {
            $recipient = preg_replace('/\D/', '', $recipient);
        });
    }
}


1			<?php
2
3			namespace LBHurtado\EngageSpark;
4
5			use Illuminate\Support\Arr;
6			use Illuminate\Notifications\Notification;
7			use Propaganistas\LaravelPhone\PhoneNumber;
8
9			class EngageSparkChannel
10			{
11			/** @var string */
12			private $mode;
13
14			/** @var string */
15			private $clientRef;
16
17			/** @var EngageSpark */
18			protected $smsc;
19
20			public function __construct(EngageSpark $smsc)
21			{
22			$this->smsc = $smsc;
23			}
24
25			/**
26			* Send the given notification.
27			*
28			* @param mixed $notifiable
29			* @param Notification $notification
30			*
31			* @return void
32			*/
33			public function send($notifiable, Notification $notification)
34			{
35			if (! ($to = $this->getRecipients($notifiable, $notification))) {
36			return;
37			}
38
39			$message = $notification->{'toEngageSpark'}($notifiable);
40
41			if (\is_string($message)) {
42			$message = new EngageSparkMessage($message);
43			}
44
45			$this->setClientRef($notification)->sendMessage($to, $message);
46			}
47
48			/**
49			* Gets a list of phones from the given notifiable.
50			*
51			* @param mixed $notifiable
52			* @param Notification $notification
53			*
54			* @return string[]
55			*/
56			protected function getRecipients($notifiable, Notification $notification)
57			{
58			return $this->getRecipient($notifiable, $notification);
59			}
60
61			/**
62			* Gets a list of phones from the given notifiable.
63			*
64			* @param mixed $notifiable
65			* @param Notification $notification
66			*
67			* @return string[]
68			*/
69			protected function getRecipient($notifiable, Notification $notification)
70			{
71			$to = $notifiable->routeNotificationFor('engage_spark', $notification);
72
73			if ($to === null \|\| $to === false \|\| $to === []) {
74			return '';
75			}
76
77			$to = \is_array($to) ? Arr::first($to) : $to;
78
79			return $this->getFormattedMobile($to);
80			}
81
82			protected function sendMessage($recipient, EngageSparkMessage $message)
83			{
84			$this->setMode($message);
85
86			switch ($mode = $this->getMode()) {
87			case 'sms':
88			$params = [
89			'orgId' => $this->getOrgId(),
90			'to' => $recipient,
91			'message' => $message->content,
92			'from' => $this->getSenderId($message),
93			];
94			break;
95
96			case 'topup':
97			$params = [
98			'organizationId' => $this->getOrgId(),
99			'phoneNumber' => $recipient,
100			'maxAmount' => $message->air_time,
101			'clientRef' => $this->getClientRef(),
102			];
103			break;
104
105			default:
106			# code...
107			break;
108			}
109
110			// if ($message->sendAt instanceof \DateTimeInterface) {
111			// $params['time'] = '0'.$message->sendAt->getTimestamp();
112			// }
113
114			$this->smsc->send($params, $mode);
			0 ignored issues – show Bug introduced 2019-05-22 03:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$params` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
115			}
116
117			protected function getWebHook(EngageSparkMessage $message)
118			{
119			return $this->smsc->getWebHook($message->mode);
			0 ignored issues – show Bug introduced 2019-05-27 15:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getWebHook()` does not seem to exist on `object<LBHurtado\EngageSpark\EngageSpark>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
120			}
121
122			protected function getOrgId()
123			{
124			return $this->smsc->getOrgId();
125			}
126
127			public function getClientRef()
128			{
129			return $this->clientRef;
130			}
131
132			protected function getSenderId(EngageSparkMessage $message)
133			{
134			return $message->sender_id ? $message->sender_id : $this->smsc->getSenderId();
135			}
136
137			protected function setClientRef(Notification $notification)
138			{
139			$this->clientRef = $notification->id;
140
141			return $this;
142			}
143
144			protected function getMode()
145			{
146			return $this->mode;
147			}
148
149			protected function setMode(EngageSparkMessage $message)
150			{
151			$this->mode = $message->mode;
152
153			return $this;
154			}
155
156			protected function getFormattedMobile($to)
157			{
158			return tap(PhoneNumber::make($to, 'PH')->formatE164(), function(&$recipient) {
159			$recipient = preg_replace('/\D/', '', $recipient);
160			});
161			}
162			}
163

GitHub Access Token became invalid

Issues (11)

Security Analysis no request data

src/EngageSparkChannel.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

lbhurtado / engagespark

GitHub Access Token became invalid

Issues (11)

Security Analysis no request data

src/EngageSparkChannel.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like