lazzard / ftp-bridge

src/Stream/ActiveDataStream.php

<?php

/**
 * This file is part of the Lazzard/ftp-bridge package.
 *
 * (c) El Amrani Chakir <elamrani.sv.laza@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Lazzard\FtpBridge\Stream;

use Lazzard\FtpBridge\Response\Response;
use Lazzard\FtpBridge\Error\ErrorTrigger;

/**
 * @since  1.0
 * @author El Amrani Chakir <elamrani.sv.laza@gmail.com>
 * 
 * @internal
 */
class ActiveDataStream extends DataStream
{
    /** @var string */
    public $activeIpAddress;

    /**
     * Opens a data stream socket.
     *
     * @param LoggerInterface $logger

The type Lazzard\FtpBridge\Stream\LoggerInterface was not found. Maybe you did not declare it correctly or list all dependencies?

     * @param StreamInterface $commandStream
     * @param string          $activeIpAddress
     */
    public function __construct($logger, $commandStream, $activeIpAddress = null)
    {
        parent::__construct($logger, $commandStream);
        $this->activeIpAddress = $activeIpAddress;
    }

    /**
     * Opens a stream socket connection that listening to the local random port sent with 
     * the PORT command.
     * 
     * {@inheritDoc}
     */
    public function open()
    {
        $ip = str_replace(".", ",", $this->activeIpAddress ?: $_SERVER['SERVER_ADDR']);

        $low  = rand(32, 255);
        $high = rand(32, 255);
        // $port = ($low * 256) + $high
        $port = ($low<<8) + $high;

        // 1- create a stream socket.
        // 2- bind the socket to a local host address.
        // 3- listen to the socket on the local port that will
        // be send along with PORT comamnd.
        // 4- send the PORT command.
        if (is_resource($stream = stream_socket_server('tcp://0.0.0.0:'.$port, $errnon, $errstr, STREAM_SERVER_BIND | STREAM_SERVER_LISTEN))) {
            $this->commandStream->write("PORT $ip,$low,$high");
            $response = new Response($this->commandStream->read());

It seems like $this->commandStream->read() can also be of type false; however, parameter $reply of Lazzard\FtpBridge\Response\Response::__construct() does only seem to accept string, maybe add an additional type check?

            if ($response->getCode() === 200) {
                $this->stream = $stream;
                return true;
            }

            return !ErrorTrigger::raise($response->getMessage());
        }

        return !ErrorTrigger::raise("Unable to open the data stream socket connection.");
    }

    /**
     * @inheritDoc
     */
    public function read()
    {
        $conn = stream_socket_accept($this->stream);
        $data = fread($conn, 8192);
        fclose($conn);

        $this->log($data);

        return $data;
    }
}