Issues in Response.php (master) - Issues in master - lazzard/ftp-bridge - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

src/Response/Response.php (1 issue)

Labels

Severity

Minor 1

<?php

/**
 * This file is part of the Lazzard/ftp-bridge package.
 *
 * (c) El Amrani Chakir <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Lazzard\FtpBridge\Response;

/**
 * Represents an FTP replay.
 *
 * @since  1.0
 * @author El Amrani Chakir <[email protected]>
 */
class Response
{
    /** @var string */
    protected $raw;

    /** @var int */
    protected $code;

    /** @var string */
    protected $message;

    /** @var bool */
    protected $multiline;

    /**
     * @param string $reply The raw FTP reply string.
     */
    public function __construct($reply)
    {
        $parser   = new ResponseParser($reply);
        $response = $parser->parseToArray();

        $this->raw       = $reply;
        $this->code      = $response['code'];
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->message   = $response['message'];
        $this->multiline = $response['multiline'];
    }

    /**
     * Gets the raw (original) reply string sent by the server.
     * 
     * @return string
     */
    public function getRaw()
    {
        return $this->raw;
    }

    /**
     * Gets reply code.
     *
     * @return int
     */
    public function getCode()
    {
        return $this->code;
    }

    /**
     * Gets reply message.
     *
     * @return string
     */
    public function getMessage()
    {
        return $this->message;
    }

    /**
     * Whether the FTP response consists of multiple lines or not.
     *
     * @return bool
     */
    public function isMultiline()
    {
        return $this->multiline;
    }

    /**
     * @return bool
     */
    public function hasCode()
    {
        return in_array($this->getCode(), func_get_args(), false);
    }
}

1			<?php
2
3			/**
4			* This file is part of the Lazzard/ftp-bridge package.
5			*
6			* (c) El Amrani Chakir <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Lazzard\FtpBridge\Response;
13
14			/**
15			* Represents an FTP replay.
16			*
17			* @since 1.0
18			* @author El Amrani Chakir <[email protected]>
19			*/
20			class Response
21			{
22			/** @var string */
23			protected $raw;
24
25			/** @var int */
26			protected $code;
27
28			/** @var string */
29			protected $message;
30
31			/** @var bool */
32			protected $multiline;
33
34			/**
35			* @param string $reply The raw FTP reply string.
36			*/
37			public function __construct($reply)
38			{
39			$parser = new ResponseParser($reply);
40			$response = $parser->parseToArray();
41
42			$this->raw = $reply;
43			$this->code = $response['code'];
			0 ignored issues – show Documentation Bug introduced 2021-06-29 16:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$response['code']` can also be of type `false`. However, the property `$code` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
44			$this->message = $response['message'];
45			$this->multiline = $response['multiline'];
46			}
47
48			/**
49			* Gets the raw (original) reply string sent by the server.
50			*
51			* @return string
52			*/
53			public function getRaw()
54			{
55			return $this->raw;
56			}
57
58			/**
59			* Gets reply code.
60			*
61			* @return int
62			*/
63			public function getCode()
64			{
65			return $this->code;
66			}
67
68			/**
69			* Gets reply message.
70			*
71			* @return string
72			*/
73			public function getMessage()
74			{
75			return $this->message;
76			}
77
78			/**
79			* Whether the FTP response consists of multiple lines or not.
80			*
81			* @return bool
82			*/
83			public function isMultiline()
84			{
85			return $this->multiline;
86			}
87
88			/**
89			* @return bool
90			*/
91			public function hasCode()
92			{
93			return in_array($this->getCode(), func_get_args(), false);
94			}
95			}

lazzard / ftp-bridge

Issues (15)

src/Response/Response.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like