Total Complexity | 56 |
Total Lines | 363 |
Duplicated Lines | 0 % |
Coverage | 98.06% |
Changes | 7 | ||
Bugs | 0 | Features | 0 |
Complex classes like ActiveLogBehavior often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ActiveLogBehavior, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
64 | class ActiveLogBehavior extends Behavior |
||
65 | { |
||
66 | /** |
||
67 | * @event MessageEvent an event that is triggered before inserting a record. |
||
68 | * You may add in to the [[MessageEvent::append]] your custom log message. |
||
69 | * @since 1.5.3 |
||
70 | */ |
||
71 | public const EVENT_BEFORE_SAVE_MESSAGE = 'beforeSaveMessage'; |
||
72 | /** |
||
73 | * @event Event an event that is triggered after inserting a record. |
||
74 | * @since 1.5.3 |
||
75 | */ |
||
76 | public const EVENT_AFTER_SAVE_MESSAGE = 'afterSaveMessage'; |
||
77 | |||
78 | public bool $softDelete = false; |
||
79 | /** @since 1.6.0 */ |
||
80 | public ?\Closure $beforeSaveMessage = null; |
||
81 | /** |
||
82 | * [ |
||
83 | * // simple attribute |
||
84 | * 'title', |
||
85 | * |
||
86 | * // simple boolean attribute |
||
87 | * 'is_publish', |
||
88 | * |
||
89 | * // the value of the attribute is a item in the list |
||
90 | * // => $this->getStatusList() |
||
91 | * 'status' => [ |
||
92 | * 'list' => 'statusList' |
||
93 | * ], |
||
94 | * |
||
95 | * // the attribute value is the [id] of the relation model |
||
96 | * 'owner_id' => [ |
||
97 | * 'relation' => 'user', |
||
98 | * 'attribute' => 'username' |
||
99 | * ] |
||
100 | * ] |
||
101 | */ |
||
102 | public array $attributes = []; |
||
103 | |||
104 | public bool $identicalAttributes = false; |
||
105 | /** |
||
106 | * A PHP callable that replaces the default implementation of [[isEmpty()]]. |
||
107 | * @since 1.5.2 |
||
108 | */ |
||
109 | public ?\Closure $isEmpty = null; |
||
110 | /** |
||
111 | * @var \Closure|array|string custom method to getEntityName |
||
112 | * the callback function must return a string |
||
113 | */ |
||
114 | public $getEntityName; |
||
115 | /** |
||
116 | * @var \Closure|array|string custom method to getEntityId |
||
117 | * the callback function can return a string or array |
||
118 | */ |
||
119 | public $getEntityId; |
||
120 | /** |
||
121 | * [ |
||
122 | * 'title' => [ |
||
123 | * 'new' => ['value' => 'New title'], |
||
124 | * ], |
||
125 | * 'is_publish' => [ |
||
126 | * 'old' => ['value' => false], |
||
127 | * 'new' => ['value' => true], |
||
128 | * ], |
||
129 | * 'status' => [ |
||
130 | * 'old' => ['id' => 0, 'value' => 'Disabled'], |
||
131 | * 'new' => ['id' => 1, 'value' => 'Active'], |
||
132 | * ], |
||
133 | * 'owner_id' => [ |
||
134 | * 'old' => ['id' => 1, 'value' => 'admin'], |
||
135 | * 'new' => ['id' => 2, 'value' => 'lucy'], |
||
136 | * ] |
||
137 | * ] |
||
138 | */ |
||
139 | private array $changedAttributes = []; |
||
140 | |||
141 | private string $action; |
||
142 | |||
143 | private ManagerInterface $logger; |
||
144 | |||
145 | 26 | public function __construct( |
|
146 | ManagerInterface $logger, |
||
147 | array $config = [] |
||
148 | ) |
||
149 | { |
||
150 | 26 | parent::__construct($config); |
|
151 | 26 | $this->logger = $logger; |
|
152 | } |
||
153 | |||
154 | 26 | public function init(): void |
|
155 | { |
||
156 | 26 | $this->initAttributes(); |
|
157 | } |
||
158 | |||
159 | 26 | private function initAttributes(): void |
|
160 | { |
||
161 | 26 | foreach ($this->attributes as $key => $value) { |
|
162 | 25 | if (is_int($key)) { |
|
163 | 25 | unset($this->attributes[$key]); |
|
164 | 25 | $this->attributes[$value] = []; |
|
165 | } |
||
166 | } |
||
167 | } |
||
168 | |||
169 | 26 | public function events(): array |
|
170 | { |
||
171 | 26 | if (false === $this->logger->isEnabled()) { |
|
172 | 1 | return []; |
|
173 | } |
||
174 | 25 | return [ |
|
175 | 25 | ActiveRecord::EVENT_BEFORE_INSERT => 'beforeSave', |
|
176 | 25 | ActiveRecord::EVENT_BEFORE_UPDATE => 'beforeSave', |
|
177 | 25 | ActiveRecord::EVENT_BEFORE_DELETE => 'beforeDelete', |
|
178 | 25 | ActiveRecord::EVENT_AFTER_INSERT => 'afterSave', |
|
179 | 25 | ActiveRecord::EVENT_AFTER_UPDATE => 'afterSave', |
|
180 | 25 | ]; |
|
181 | } |
||
182 | |||
183 | 24 | public function beforeSave(): void |
|
187 | } |
||
188 | |||
189 | 24 | public function afterSave(): void |
|
190 | { |
||
191 | 24 | if (empty($this->changedAttributes)) { |
|
192 | 4 | return; |
|
193 | } |
||
194 | 24 | $this->saveMessage($this->action, $this->changedAttributes); |
|
195 | } |
||
196 | |||
197 | 4 | public function beforeDelete(): void |
|
206 | } |
||
207 | |||
208 | 24 | private function prepareChangedAttributes(bool $unset = false): array |
|
224 | } |
||
225 | |||
226 | /** |
||
227 | * @param string|int|null $old_id |
||
228 | * @param string|int|null $new_id |
||
229 | */ |
||
230 | 24 | protected function resolveStoreValues($old_id, $new_id, array $options): array |
|
231 | { |
||
232 | 24 | if (isset($options['list'])) { |
|
233 | 24 | $value = $this->resolveListValues($old_id, $new_id, $options['list']); |
|
234 | 22 | } elseif (isset($options['relation'], $options['attribute'])) { |
|
235 | 17 | $value = $this->resolveRelationValues($old_id, $new_id, $options['relation'], $options['attribute']); |
|
236 | } else { |
||
237 | 22 | $value = $this->resolveSimpleValues($old_id, $new_id); |
|
238 | } |
||
239 | 24 | return $value; |
|
240 | } |
||
241 | |||
242 | /** |
||
243 | * @param string|int|null|ArrayExpression|JsonExpression $old_id |
||
244 | * @param string|int|null|ArrayExpression|JsonExpression $new_id |
||
245 | */ |
||
246 | 22 | private function resolveSimpleValues($old_id, $new_id): array |
|
247 | { |
||
248 | 22 | if ($old_id instanceof ArrayExpression || $old_id instanceof JsonExpression) { |
|
249 | $old_id = $old_id->getValue(); |
||
250 | } |
||
251 | 22 | if ($new_id instanceof ArrayExpression || $new_id instanceof JsonExpression) { |
|
252 | $new_id = $new_id->getValue(); |
||
253 | } |
||
254 | 22 | return [ |
|
255 | 22 | 'old' => ['value' => $old_id], |
|
256 | 22 | 'new' => ['value' => $new_id], |
|
257 | 22 | ]; |
|
258 | } |
||
259 | |||
260 | /** |
||
261 | * @param string|int|array|null $old_id |
||
262 | * @param string|int|array|null $new_id |
||
263 | */ |
||
264 | 24 | private function resolveListValues($old_id, $new_id, string $listName): array |
|
265 | { |
||
266 | 24 | $old = $new = []; |
|
267 | 24 | $old['id'] = $old_id; |
|
268 | 24 | $new['id'] = $new_id; |
|
269 | 24 | $list = []; |
|
270 | |||
271 | 24 | if (is_array($old_id) || is_array($new_id)) { |
|
272 | 1 | $list = ArrayHelper::getValue($this->owner, $listName); |
|
273 | } |
||
274 | 24 | if (is_array($old_id)) { |
|
275 | 1 | $old['value'] = array_intersect_key($list, array_flip($old_id)); |
|
276 | 24 | } elseif ($old_id) { |
|
277 | 4 | $old['value'] = ArrayHelper::getValue($this->owner, [$listName, $old_id]); |
|
278 | } else { |
||
279 | 24 | $old['value'] = null; |
|
280 | } |
||
281 | 24 | if (is_array($new_id)) { |
|
282 | 1 | $new['value'] = array_intersect_key($list, array_flip($new_id)); |
|
283 | 24 | } elseif ($new_id) { |
|
284 | 23 | $new['value'] = ArrayHelper::getValue($this->owner, [$listName, $new_id]); |
|
285 | } else { |
||
286 | 4 | $new['value'] = null; |
|
287 | } |
||
288 | 24 | return [ |
|
289 | 24 | 'old' => $old, |
|
290 | 24 | 'new' => $new |
|
291 | 24 | ]; |
|
292 | } |
||
293 | |||
294 | /** |
||
295 | * @param string|int|null $old_id |
||
296 | * @param string|int|null $new_id |
||
297 | */ |
||
298 | 17 | private function resolveRelationValues($old_id, $new_id, string $relation, string $attribute): array |
|
299 | { |
||
300 | 17 | $old = $new = []; |
|
301 | 17 | $old['id'] = $old_id; |
|
302 | 17 | $new['id'] = $new_id; |
|
303 | |||
304 | 17 | $relationQuery = clone $this->owner->getRelation($relation); |
|
305 | 17 | $relationQuery->primaryModel = null; |
|
1 ignored issue
–
show
|
|||
306 | 17 | $idAttribute = array_keys($relationQuery->link)[0]; |
|
307 | 17 | $targetId = array_filter([$old_id, $new_id]); |
|
308 | |||
309 | 17 | $relationModels = $relationQuery |
|
310 | 17 | ->where([$idAttribute => $targetId]) |
|
311 | 17 | ->indexBy($idAttribute) |
|
312 | 17 | ->limit(count($targetId)) |
|
313 | 17 | ->all(); |
|
314 | |||
315 | 17 | $old['value'] = ($old_id === null) ? null : ArrayHelper::getValue($relationModels, [$old_id, $attribute]); |
|
316 | 17 | $new['value'] = ArrayHelper::getValue($relationModels, [$new_id, $attribute]); |
|
317 | |||
318 | 17 | return [ |
|
319 | 17 | 'old' => $old, |
|
320 | 17 | 'new' => $new |
|
321 | 17 | ]; |
|
322 | } |
||
323 | |||
324 | 24 | protected function saveMessage(string $action, array $data): void |
|
325 | { |
||
326 | 24 | $data = $this->beforeSaveMessage($data); |
|
327 | 24 | $this->addLog($data, $action); |
|
328 | 24 | $this->afterSaveMessage(); |
|
329 | } |
||
330 | |||
331 | /** |
||
332 | * @param string|array $data |
||
333 | * @since 1.7.0 |
||
334 | */ |
||
335 | 24 | public function addLog($data, string $action = null): bool |
|
347 | } |
||
348 | |||
349 | /** |
||
350 | * @since 1.5.3 |
||
351 | */ |
||
352 | 24 | public function beforeSaveMessage(array $data): array |
|
353 | { |
||
354 | 24 | if (null !== $this->beforeSaveMessage) { |
|
355 | 1 | return call_user_func($this->beforeSaveMessage, $data); |
|
356 | } |
||
357 | 23 | $name = self::EVENT_BEFORE_SAVE_MESSAGE; |
|
358 | 23 | if (method_exists($this->owner, $name)) { |
|
359 | 1 | return $this->owner->$name($data); |
|
360 | } |
||
361 | 22 | $event = new MessageEvent(); |
|
362 | 22 | $event->logData = $data; |
|
363 | 22 | $this->owner->trigger($name, $event); |
|
364 | 22 | return $event->logData; |
|
365 | } |
||
366 | |||
367 | /** |
||
368 | * @since 1.5.3 |
||
369 | */ |
||
370 | 24 | public function afterSaveMessage(): void |
|
371 | { |
||
372 | 24 | $name = self::EVENT_AFTER_SAVE_MESSAGE; |
|
373 | 24 | if (method_exists($this->owner, $name)) { |
|
374 | 1 | $this->owner->$name(); |
|
375 | } else { |
||
376 | 23 | $this->owner->trigger($name); |
|
377 | } |
||
378 | } |
||
379 | |||
380 | 25 | public function getEntityName(): string |
|
381 | { |
||
382 | 25 | if (is_string($this->getEntityName)) { |
|
383 | 25 | return $this->getEntityName; |
|
384 | } |
||
385 | 1 | if (is_callable($this->getEntityName)) { |
|
386 | 1 | return call_user_func($this->getEntityName); |
|
387 | } |
||
388 | 1 | $class = get_class($this->owner); |
|
389 | 1 | $class = StringHelper::basename($class); |
|
390 | 1 | $this->getEntityName = Inflector::camel2id($class, '_'); |
|
391 | 1 | return $this->getEntityName; |
|
392 | } |
||
393 | |||
394 | 26 | public function getEntityId(): string |
|
395 | { |
||
396 | 26 | if (null === $this->getEntityId) { |
|
397 | 26 | $result = $this->owner->getPrimaryKey(); |
|
398 | 3 | } elseif (is_callable($this->getEntityId)) { |
|
399 | 3 | $result = call_user_func($this->getEntityId); |
|
400 | } else { |
||
401 | $result = $this->getEntityId; |
||
402 | } |
||
403 | 26 | if ($this->isEmpty($result)) { |
|
404 | 1 | throw new InvalidValueException('the property "entityId" can not be empty'); |
|
405 | } |
||
406 | 25 | if (is_array($result)) { |
|
407 | 1 | ksort($result); |
|
408 | 1 | $result = json_encode($result, JSON_THROW_ON_ERROR | JSON_UNESCAPED_SLASHES | JSON_UNESCAPED_UNICODE); |
|
409 | } |
||
410 | 25 | return $result; |
|
411 | } |
||
412 | |||
413 | /** |
||
414 | * Checks if the given value is empty. |
||
415 | * A value is considered empty if it is null, an empty array, or an empty string. |
||
416 | * Note that this method is different from PHP empty(). It will return false when the value is 0. |
||
417 | * @param mixed $value the value to be checked |
||
418 | * @return bool whether the value is empty |
||
419 | * @since 1.5.2 |
||
420 | */ |
||
421 | 26 | public function isEmpty($value): bool |
|
427 | } |
||
428 | } |