Issues in CreateOrderCommandHandler.php (master) - Issues in master - laudeco/bbc-dolibarr-flightlog - Measure and Improve Code Quality continuously with Scrutinizer

Issues (188)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

command/CreateOrderCommandHandler.php (21 issues)

Labels

Severity

Minor 21

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

require_once __DIR__ . '/CommandHandlerInterface.php';
require_once __DIR__ . '/CommandInterface.php';
require_once __DIR__ . '/CreateOrderCommand.php';
require_once __DIR__ . '/../../societe/class/societe.class.php';
require_once __DIR__ . '/../../commande/class/commande.class.php';
require_once __DIR__ . '/../../product/class/product.class.php';

/**
 * CreateOrderCommandHandler class
 *
 * @author Laurent De Coninck <[email protected]>
 */
class CreateOrderCommandHandler implements CommandHandlerInterface
{
    /**
     * @var DoliDB
     */
    private $db;

    /**
     * @var stdClass
     */
    private $conf;

    /**
     * @var User
     */
    private $user;

    /**
     * @var Translate
     */
    private $langs;

    /**
     * @var ModeleThirdPartyCode
     */
    private $codeFournisseurGenerator;

    /**
     * @var ModeleThirdPartyCode
     */
    private $codeClientGenerator;

    /**
     * @var Societe
     */
    private $societe;

    /**
     * @var Commande
     */
    private $order;

    /**
     * @param DoliDB               $db
     * @param stdClass             $conf
     * @param User                 $user
     * @param Translate            $langs
     * @param ModeleThirdPartyCode $codeClientGenerator
     * @param ModeleThirdPartyCode $codeFounrisseurGenerator
     */
    public function __construct(
        $db,
        $conf,
        $user,
        $langs,
        ModeleThirdPartyCode $codeClientGenerator,
        ModeleThirdPartyCode $codeFounrisseurGenerator
    ) {
        $this->db = $db;
        $this->conf = $conf->global;
        $this->user = $user;
        $this->langs = $langs;
        $this->codeClientGenerator = $codeClientGenerator;
        $this->codeFournisseurGenerator = $codeFounrisseurGenerator;
    }

    /**
     * @param CreateOrderCommand|CommandInterface $command
     *
     * @throws Exception
     */
    public function handle(CommandInterface $command)
    {
        $customerId = $this->createCustomer($command)->id;

        $this->createOrder($command, $customerId)
            ->addLine($command)
            ->addContacts()
            ->validateOrder();

        $this->order->generateDocument('einstein', $this->langs);
    }

    /**
     * @return Product
     */
    private function getProduct()
    {
        $flightProduct = new Product($this->db);

        if ($flightProduct->fetch($this->conf->BBC_FLIGHT_TYPE_CUSTOMER) <= 0) {
            throw new \InvalidArgumentException('Default product not configured');
        }

        return $flightProduct;
    }

    /**
     * @param Product   $flightProduct
     * @param float|int $pricePerPax
     *
     * @return float|int
     */
    private function computeDiscounts($flightProduct, $pricePerPax = 0)
    {
        return ($flightProduct->price_ttc - ($pricePerPax)) * 100 / $flightProduct->price_ttc;
    }

    /**
     * @param CommandInterface|CreateOrderCommand $command
     *
     * @return Societe
     * @throws Exception
     */
    private function createCustomer(CommandInterface $command)
    {
        $this->societe = new Societe($this->db);
        $name = $command->getName() . ' ' . $command->getFirstname();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $existingCustomers = $this->societe->searchByName($name);
        if(count($existingCustomers) > 0){
            $this->societe = $existingCustomers[0];
            return $this->societe;
        }

        $this->societe->particulier = 1;
        $this->societe->name = $name;
        $this->societe->civility_id = $command->getCivilityId();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->name_bis = $command->getName();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->firstname = $command->getFirstname();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->entity = $this->conf->entity;
        $this->societe->name_alias = '';
        $this->societe->address = GETPOST('address');
        $this->societe->zip = $command->getZip();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->town = $command->getTown();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->country_id = 2;
        $this->societe->state_id = $command->getState();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->phone = $command->getPhone();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->email = $command->getEmail();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->code_client = $this->codeClientGenerator->getNextValue($this->societe, 0);
        $this->societe->code_fournisseur = $this->codeFournisseurGenerator->getNextValue($this->societe, 1);
        $this->societe->tva_intra = $command->getTva();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->tva_assuj = empty($command->getTva()) ? 0 : 1;
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->societe->status = 1;
        $this->societe->client = 3; //prospect + customer
        $this->societe->fournisseur = 0;
        $this->societe->commercial_id = $this->user->id;
        $this->societe->default_lang = $command->getLanguage();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $customerId = $this->societe->create($this->user);
        if ($customerId < 0) {
            throw new Exception($this->societe->errorsToString(), $customerId);
        }

        return $this->societe;
    }

    /**
     * @param CommandInterface|CreateOrderCommand $command
     *
     * @return CreateOrderCommandHandler
     */
    private function addLine(CommandInterface $command)
    {
        $product = $this->getProduct();
        $pu_ht = price2num($product->price, 'MU');

        $this->order->addline(
            '',
            $pu_ht,
            $command->getNbrPax(),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $product->tva_tx,
            0,
            0,
            $product->id,
            $this->computeDiscounts($product, ($command->getCost() / $command->getNbrPax()))
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        );

        return $this;
    }

    /**
     * @param CommandInterface|CreateOrderCommand $command
     * @param int                                 $customerId
     *
     * @return $this
     * @throws Exception
     */
    private function createOrder(CommandInterface $command, $customerId)
    {
        $this->order = new Commande($this->db);
        $this->order->note_public = $command->isCommentPublic() ? $command->getComment() : '';
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->order->note_private = $command->isCommentPublic() ? $command->getComment() : '';
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->order->socid = $customerId;
        $this->order->cond_reglement_id = 1; // reception
        $this->order->mode_reglement_id = 2; //virement
        $this->order->demand_reason_id = $command->getOrigine();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $this->order->date = time();

        $orderId = $this->order->create($this->user);
        if ($orderId <= 0) {
            throw new Exception('Exception during the order creation');
        }

        return $this;
    }

    /**
     * Validate the order
     *
     * @throws Exception
     */
    private function validateOrder()
    {
        if ($this->order->valid($this->user) < 0) {
            throw new Exception('Validation of order failed');
        }

        return $this;
    }

    /**
     * Add sales contact
     */
    private function addContacts()
    {
        $this->order->add_contact($this->user->id, 91, 'internal');
        return $this;
    }

    /**
     * @return Societe
     */
    public function getCustomer()
    {
        return $this->societe;
    }

    /**
     * @return Commande
     */
    public function getOrder()
    {
        return $this->order;
    }

}

Issues (188)

Security Analysis not enabled

command/CreateOrderCommandHandler.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

laudeco / bbc-dolibarr-flightlog

Issues (188)

Security Analysis not enabled

command/CreateOrderCommandHandler.php (21 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like