Issues in BaseInput.php (master) - Issues in master - laudeco/bbc-dolibarr-flightlog - Measure and Improve Code Quality continuously with Scrutinizer

Issues (188)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Form/BaseInput.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 *
 */

namespace flightlog\form;

/**
 * @author Laurent De Coninck <[email protected]>
 */
abstract class BaseInput implements FormElementInterface
{
    /**
     * @var string
     */
    private $name;

    /**
     * @var array
     */
    private $options;

    /**
     * @var string|int
     */
    private $value;

    /**
     * @var string
     */
    private $type;

    /**
     * @var string[]|array
     */
    private $errors;

    /**
     * @param string $name
     * @param string $type
     * @param array  $options
     */
    public function __construct($name, $type, array $options = [])
    {
        if (empty($name)) {
            throw new \InvalidArgumentException('Name cannot be empty');
        }

        $this->name = $name;
        $this->options = $options;
        $this->type = $type;
        $this->errors = [];
    }

    /**
     * @inheritDoc
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @inheritDoc
     */
    public function getOptions()
    {
        return $this->options;
    }

    /**
     * @inheritDoc
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @inheritdoc
     */
    public function getId()
    {
        return $this->getOption('id') ?: $this->getName();

    }

    /**
     * @inheritDoc
     */
    public function getValue()
    {
        return $this->value;
    }

    /**
     * @inheritDoc
     */
    public function setValue($value)
    {
        $this->value = $value;
    }

    /**
     * @param string     $name
     * @param int|string $value
     *
     * @return $this
     */
    protected function setAttribute($name, $value)
    {
        $this->options['attr'][$name] = $value;

        return $this;
    }

    /**
     * @return $this
     */
    public function required()
    {
        $this->options['attr']['required'] = 'required';

        return $this;
    }

    /**
     * @return $this
     */
    public function disable()
    {
        $this->options['attr']['disabled'] = 'disabled';
        return $this;
    }

    /**
     * @inheritdoc
     */
    public function isDisabled()
    {
        return isset($this->options['attr']['disabled']);
    }

    /**
     * @param string $option
     *
     * @return string|int|boolean|null
     */
    public function getOption($option)
    {
        if (!isset($this->options[$option])) {
            return null;
        }

        return $this->options[$option];
    }

    /**
     * @inheritDoc
     */
    public function setErrors($errors = [])
    {
        $this->errors = $errors;
    }

    /**
     * @inheritDoc
     */
    public function hasError()
    {
        return !empty($this->errors);
    }

}

1			<?php
2			/**
3			*
4			*/
5
6			namespace flightlog\form;
7
8			/**
9			* @author Laurent De Coninck <[email protected]>
10			*/
11			abstract class BaseInput implements FormElementInterface
12			{
13			/**
14			* @var string
15			*/
16			private $name;
17
18			/**
19			* @var array
20			*/
21			private $options;
22
23			/**
24			* @var string\|int
25			*/
26			private $value;
27
28			/**
29			* @var string
30			*/
31			private $type;
32
33			/**
34			* @var string[]\|array
35			*/
36			private $errors;
37
38			/**
39			* @param string $name
40			* @param string $type
41			* @param array $options
42			*/
43			public function __construct($name, $type, array $options = [])
44			{
45			if (empty($name)) {
46			throw new \InvalidArgumentException('Name cannot be empty');
47			}
48
49			$this->name = $name;
50			$this->options = $options;
51			$this->type = $type;
52			$this->errors = [];
53			}
54
55			/**
56			* @inheritDoc
57			*/
58			public function getType()
59			{
60			return $this->type;
61			}
62
63			/**
64			* @inheritDoc
65			*/
66			public function getOptions()
67			{
68			return $this->options;
69			}
70
71			/**
72			* @inheritDoc
73			*/
74			public function getName()
75			{
76			return $this->name;
77			}
78
79			/**
80			* @inheritdoc
81			*/
82			public function getId()
83			{
84			return $this->getOption('id') ?: $this->getName();
			0 ignored issues – show Bug Compatibility introduced 2018-09-21 16:49 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$this->getOption('id') ?: $this->getName();` of type `string\|integer\|boolean` adds the type `boolean` to the return on line 84 which is incompatible with the return type declared by the interface `flightlog\form\FormElementInterface::getId` of type `string`. Loading history...
85			}
86
87			/**
88			* @inheritDoc
89			*/
90			public function getValue()
91			{
92			return $this->value;
93			}
94
95			/**
96			* @inheritDoc
97			*/
98			public function setValue($value)
99			{
100			$this->value = $value;
101			}
102
103			/**
104			* @param string $name
105			* @param int\|string $value
106			*
107			* @return $this
108			*/
109			protected function setAttribute($name, $value)
110			{
111			$this->options['attr'][$name] = $value;
112
113			return $this;
114			}
115
116			/**
117			* @return $this
118			*/
119			public function required()
120			{
121			$this->options['attr']['required'] = 'required';
122
123			return $this;
124			}
125
126			/**
127			* @return $this
128			*/
129			public function disable()
130			{
131			$this->options['attr']['disabled'] = 'disabled';
132			return $this;
133			}
134
135			/**
136			* @inheritdoc
137			*/
138			public function isDisabled()
139			{
140			return isset($this->options['attr']['disabled']);
141			}
142
143			/**
144			* @param string $option
145			*
146			* @return string\|int\|boolean\|null
147			*/
148			public function getOption($option)
149			{
150			if (!isset($this->options[$option])) {
151			return null;
152			}
153
154			return $this->options[$option];
155			}
156
157			/**
158			* @inheritDoc
159			*/
160			public function setErrors($errors = [])
161			{
162			$this->errors = $errors;
163			}
164
165			/**
166			* @inheritDoc
167			*/
168			public function hasError()
169			{
170			return !empty($this->errors);
171			}
172
173			}

laudeco / bbc-dolibarr-flightlog

Issues (188)

Security Analysis not enabled

Form/BaseInput.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like