CreateFlightCommandHandler - Code Metrics - Inspection of "multi orders on same flight" - laudeco/bbc-dolibarr-flightlog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/multi_order ( eb7707 )

by Laurent

created 2019-08-20 06:09 UTC

CreateFlightCommandHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	158
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	158
rs	10
c	0
b	0
f	0
wmc	17
lcom	1
cbo	3

4 Methods

Rating	Name	Size	Complexity
A	__construct()	13	1
A	numberOfPassengersLinkedToOrder()	19	4
B	handle()	41	6
B	handleOrder()	29	6

<?php

require_once __DIR__ . '/../exceptions/FlightNotFoundException.php';
require_once __DIR__ . '/../class/bbcvols.class.php';

/**
 * @author Laurent De Coninck <[email protected]>
 */
class CreateFlightCommandHandler implements CommandHandlerInterface
{
    /**
     * @var DoliDB
     */
    private $db;

    /**
     * @var stdClass
     */
    private $conf;

    /**
     * @var User
     */
    private $user;

    /**
     * @var Translate
     */
    private $langs;

    /**
     * @var
     */
    private $validator;

    /**
     * @param DoliDB          $db
     * @param stdClass        $conf
     * @param User            $user
     * @param Translate       $langs
     * @param FlightValidator $validator
     */
    public function __construct(
        $db,
        $conf,
        $user,
        $langs,
        FlightValidator $validator
    ) {
        $this->db = $db;
        $this->conf = $conf->global;
        $this->user = $user;
        $this->langs = $langs;
        $this->validator = $validator;
    }

    /**
     * @param CreateFlightCommand|CommandInterface $command
     *
     * @return Bbcvols
     * @throws Exception
     */
    public function handle(CommandInterface $command)
    {
        $vol = new Bbcvols($this->db);
        $vol->date = $command->getDate();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->lieuD = $command->getLieuD();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->lieuA =$command->getLieuA();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->heureD = $command->getHeureD();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->heureA = $command->getHeureA();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->BBC_ballons_idBBC_ballons = $command->getBBCBallonsIdBBCBallons();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->nbrPax = $command->getNbrPax();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->remarque = $command->getRemarque();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->incidents = $command->getIncidents();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->fk_type = $command->getFkType();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->fk_pilot =$command->getFkPilot();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->fk_organisateur = $command->getFkOrganisateur();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->kilometers = $command->getKilometers();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->cost = $command->getCost();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->fk_receiver = $command->getFkReceiver();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->justif_kilometers = $command->getJustifKilometers();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->setPassengerNames($command->getPassengerNames());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        foreach($command->getOrderIds() as $orderId => $nbrPassengers){
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $vol->addOrderId($orderId, $nbrPassengers);
        }

        if (!$this->validator->isValid($vol, $_REQUEST)) {
            throw new Exception();
        }

        if(!$vol->getFlightType()->isBillingRequired() || $vol->isLinkedToOrder()){
            $vol->is_facture = true;
        }

        $result = $vol->create($this->user);
        if($result <= 0){
            throw new Exception();
        }

        $this->handleOrder($vol);

        return $vol;
    }

    /**
     * Handles the order of a flight.
     *
     * @param Bbcvols $flight
     *
     * @throws Exception
     */
    private function handleOrder($flight)
    {
        $flight->fetch($flight->id);

        if(!$flight->isLinkedToOrder()){
            return;
        }

        foreach($flight->getOrders() as $currentOrder){
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            $currentOrder->add_object_linked('flightlog_bbcvols', $flight->getId());
            $currentOrder->fetch_lines();

            $qtyOrder = 0;
            /** @var OrderLine $currentOrderLine */
            foreach($currentOrder->lines as $currentOrderLine){
                $qtyOrder += (int)$currentOrderLine->qty;
            }

            $passangersCount = $this->numberOfPassengersLinkedToOrder($currentOrder->id);

            if($passangersCount < $qtyOrder){
                continue;
            }

            if($currentOrder->statut == Commande::STATUS_VALIDATED){
                $currentOrder->cloture($this->user);
            }
        }
    }

    /**
     * @param int $orderId
     *
     * @return int
     */
    private function numberOfPassengersLinkedToOrder($orderId)
    {
        $sql = sprintf('SELECT SUM(nbrPax) as total FROM `llx_bbc_vols_orders` WHERE order_id = %s', $orderId);

        $resql = $this->db->query($sql);

        if ($resql) {
            $num = $this->db->num_rows($resql);
            $i = 0;
            if ($num) {
                while ($i < $num) {
                    $result = $this->db->fetch_array($resql);
                    return $result['total'];
                }
            }
        }

        return 0;
    }
}

1			<?php
2
3			require_once __DIR__ . '/../exceptions/FlightNotFoundException.php';
4			require_once __DIR__ . '/../class/bbcvols.class.php';
5
6			/**
7			* @author Laurent De Coninck <[email protected]>
8			*/
9			class CreateFlightCommandHandler implements CommandHandlerInterface
10			{
11			/**
12			* @var DoliDB
13			*/
14			private $db;
15
16			/**
17			* @var stdClass
18			*/
19			private $conf;
20
21			/**
22			* @var User
23			*/
24			private $user;
25
26			/**
27			* @var Translate
28			*/
29			private $langs;
30
31			/**
32			* @var
33			*/
34			private $validator;
35
36			/**
37			* @param DoliDB $db
38			* @param stdClass $conf
39			* @param User $user
40			* @param Translate $langs
41			* @param FlightValidator $validator
42			*/
43			public function __construct(
44			$db,
45			$conf,
46			$user,
47			$langs,
48			FlightValidator $validator
49			) {
50			$this->db = $db;
51			$this->conf = $conf->global;
52			$this->user = $user;
53			$this->langs = $langs;
54			$this->validator = $validator;
55			}
56
57			/**
58			* @param CreateFlightCommand\|CommandInterface $command
59			*
60			* @return Bbcvols
61			* @throws Exception
62			*/
63			public function handle(CommandInterface $command)
64			{
65			$vol = new Bbcvols($this->db);
66			$vol->date = $command->getDate();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getDate()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
67			$vol->lieuD = $command->getLieuD();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getLieuD()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
68			$vol->lieuA =$command->getLieuA();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getLieuA()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
69			$vol->heureD = $command->getHeureD();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getHeureD()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
70			$vol->heureA = $command->getHeureA();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getHeureA()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
71			$vol->BBC_ballons_idBBC_ballons = $command->getBBCBallonsIdBBCBallons();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getBBCBallonsIdBBCBallons()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
72			$vol->nbrPax = $command->getNbrPax();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getNbrPax()` does only exist in the following implementations of said interface: `CreateFlightCommand`, `CreateOrderCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
73			$vol->remarque = $command->getRemarque();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getRemarque()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
74			$vol->incidents = $command->getIncidents();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getIncidents()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
75			$vol->fk_type = $command->getFkType();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getFkType()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
76			$vol->fk_pilot =$command->getFkPilot();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getFkPilot()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
77			$vol->fk_organisateur = $command->getFkOrganisateur();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getFkOrganisateur()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
78			$vol->kilometers = $command->getKilometers();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getKilometers()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
79			$vol->cost = $command->getCost();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getCost()` does only exist in the following implementations of said interface: `CreateFlightCommand`, `CreateOrderCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
80			$vol->fk_receiver = $command->getFkReceiver();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getFkReceiver()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
81			$vol->justif_kilometers = $command->getJustifKilometers();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getJustifKilometers()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
82			$vol->setPassengerNames($command->getPassengerNames());
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getPassengerNames()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
83			foreach($command->getOrderIds() as $orderId => $nbrPassengers){
			0 ignored issues – show Bug introduced 2019-08-20 06:10 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getOrderIds()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
84			$vol->addOrderId($orderId, $nbrPassengers);
85			}
86
87			if (!$this->validator->isValid($vol, $_REQUEST)) {
88			throw new Exception();
89			}
90
91			if(!$vol->getFlightType()->isBillingRequired() \|\| $vol->isLinkedToOrder()){
92			$vol->is_facture = true;
93			}
94
95			$result = $vol->create($this->user);
96			if($result <= 0){
97			throw new Exception();
98			}
99
100			$this->handleOrder($vol);
101
102			return $vol;
103			}
104
105			/**
106			* Handles the order of a flight.
107			*
108			* @param Bbcvols $flight
109			*
110			* @throws Exception
111			*/
112			private function handleOrder($flight)
113			{
114			$flight->fetch($flight->id);
115
116			if(!$flight->isLinkedToOrder()){
117			return;
118			}
119
120			foreach($flight->getOrders() as $currentOrder){
			0 ignored issues – show Bug introduced 2019-08-20 06:10 UTC by Report Bug Copy Issue Report The expression `$flight->getOrders()` of type `null\|array` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
121			$currentOrder->add_object_linked('flightlog_bbcvols', $flight->getId());
122			$currentOrder->fetch_lines();
123
124			$qtyOrder = 0;
125			/** @var OrderLine $currentOrderLine */
126			foreach($currentOrder->lines as $currentOrderLine){
127			$qtyOrder += (int)$currentOrderLine->qty;
128			}
129
130			$passangersCount = $this->numberOfPassengersLinkedToOrder($currentOrder->id);
131
132			if($passangersCount < $qtyOrder){
133			continue;
134			}
135
136			if($currentOrder->statut == Commande::STATUS_VALIDATED){
137			$currentOrder->cloture($this->user);
138			}
139			}
140			}
141
142			/**
143			* @param int $orderId
144			*
145			* @return int
146			*/
147			private function numberOfPassengersLinkedToOrder($orderId)
148			{
149			$sql = sprintf('SELECT SUM(nbrPax) as total FROM `llx_bbc_vols_orders` WHERE order_id = %s', $orderId);
150
151			$resql = $this->db->query($sql);
152
153			if ($resql) {
154			$num = $this->db->num_rows($resql);
155			$i = 0;
156			if ($num) {
157			while ($i < $num) {
158			$result = $this->db->fetch_array($resql);
159			return $result['total'];
160			}
161			}
162			}
163
164			return 0;
165			}
166			}

laudeco / bbc-dolibarr-flightlog

Push — feature/multi_order ( eb7707 )

CreateFlightCommandHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like