InstructionFlightQueryHandler::__invoke() - Code Metrics - Inspection of "change type into the doc" - laudeco/bbc-dolibarr-flightlog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/api ( 725c17...de88d6 )

by Laurent

created 2020-01-10 23:13 UTC

InstructionFlightQueryHandler::__invoke() B

↳ Parent: InstructionFlightQueryHandler

Complexity

Conditions	5
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
nc	3
nop	1
dl	0
loc	51
rs	8.7579
c	0
b	0
f	0

How to fix Long Method

<?php
require_once __DIR__ . '/../class/bbcvols.class.php';
require_once __DIR__ . '/InstructionFlightQuery.php';

/**
 * Returns all instruction flights of a user.
 *
 * @author Laurent De Coninck <[email protected]>
 */
class InstructionFlightQueryHandler
{
    /**
     * @var DoliDB
     */
    private $db;

    /**
     * InstructionFlightQueryHandler constructor.
     *
     * @param DoliDB $db
     */
    public function __construct(DoliDB $db)
    {
        $this->db = $db;
    }

    /**
     * @param InstructionFlightQuery $query
     *
     * @return array|Bbcvols[]
     */
    public function __invoke(InstructionFlightQuery $query)
    {
        $sql = 'SELECT flights.* FROM llx_bbc_vols as flights';
        $sql .= ' WHERE ';
        $sql .= ' flights.fk_type = 6 ';
        $sql .= ' AND flights.fk_pilot = ' . $query->getStudentId();
        $sql .= ' ORDER BY flights.date ';

        $resql = $this->db->query($sql);
        $array = [];

        if ($resql) {
            $num = $this->db->num_rows($resql);
            $i = 0;
            if ($num) {
                while ($i < $num) {
                    $obj = $this->db->fetch_object($resql);
                    if ($obj) {

                        $flight = new Bbcvols($this->db);
                        $flight->id = $obj->idBBC_vols;
                        $flight->idBBC_vols = $obj->idBBC_vols;
                        $flight->date = $this->db->jdate($obj->date);
                        $flight->lieuD = $obj->lieuD;
                        $flight->lieuA = $obj->lieuA;
                        $flight->heureD = $obj->heureD;
                        $flight->heureA = $obj->heureA;
                        $flight->BBC_ballons_idBBC_ballons = $obj->BBC_ballons_idBBC_ballons;
                        $flight->nbrPax = $obj->nbrPax;
                        $flight->remarque = $obj->remarque;
                        $flight->incidents = $obj->incidents;
                        $flight->fk_type = $obj->fk_type;
                        $flight->fk_pilot = $obj->fk_pilot;
                        $flight->fk_organisateur = $obj->fk_organisateur;
                        $flight->is_facture = $obj->is_facture;
                        $flight->kilometers = $obj->kilometers;
                        $flight->cost = $obj->cost;
                        $flight->fk_receiver = $obj->fk_receiver;
                        $flight->justif_kilometers = $obj->justif_kilometers;
                        $flight->date_creation = $obj->date_creation;
                        $flight->date_update = $obj->date_update;

                        $array[] = $flight;
                    }
                    $i++;
                }
            }
        }

        return $array;
    }

}

1			<?php
2			require_once __DIR__ . '/../class/bbcvols.class.php';
3			require_once __DIR__ . '/InstructionFlightQuery.php';
4
5			/**
6			* Returns all instruction flights of a user.
7			*
8			* @author Laurent De Coninck <[email protected]>
9			*/
10			class InstructionFlightQueryHandler
11			{
12			/**
13			* @var DoliDB
14			*/
15			private $db;
16
17			/**
18			* InstructionFlightQueryHandler constructor.
19			*
20			* @param DoliDB $db
21			*/
22			public function __construct(DoliDB $db)
23			{
24			$this->db = $db;
25			}
26
27			/**
28			* @param InstructionFlightQuery $query
29			*
30			* @return array\|Bbcvols[]
31			*/
32			public function __invoke(InstructionFlightQuery $query)
33			{
34			$sql = 'SELECT flights.* FROM llx_bbc_vols as flights';
35			$sql .= ' WHERE ';
36			$sql .= ' flights.fk_type = 6 ';
37			$sql .= ' AND flights.fk_pilot = ' . $query->getStudentId();
38			$sql .= ' ORDER BY flights.date ';
39
40			$resql = $this->db->query($sql);
41			$array = [];
42
43			if ($resql) {
44			$num = $this->db->num_rows($resql);
45			$i = 0;
46			if ($num) {
47			while ($i < $num) {
48			$obj = $this->db->fetch_object($resql);
49			if ($obj) {
50
51			$flight = new Bbcvols($this->db);
52			$flight->id = $obj->idBBC_vols;
53			$flight->idBBC_vols = $obj->idBBC_vols;
54			$flight->date = $this->db->jdate($obj->date);
55			$flight->lieuD = $obj->lieuD;
56			$flight->lieuA = $obj->lieuA;
57			$flight->heureD = $obj->heureD;
58			$flight->heureA = $obj->heureA;
59			$flight->BBC_ballons_idBBC_ballons = $obj->BBC_ballons_idBBC_ballons;
60			$flight->nbrPax = $obj->nbrPax;
61			$flight->remarque = $obj->remarque;
62			$flight->incidents = $obj->incidents;
63			$flight->fk_type = $obj->fk_type;
64			$flight->fk_pilot = $obj->fk_pilot;
65			$flight->fk_organisateur = $obj->fk_organisateur;
66			$flight->is_facture = $obj->is_facture;
67			$flight->kilometers = $obj->kilometers;
68			$flight->cost = $obj->cost;
69			$flight->fk_receiver = $obj->fk_receiver;
70			$flight->justif_kilometers = $obj->justif_kilometers;
71			$flight->date_creation = $obj->date_creation;
72			$flight->date_update = $obj->date_update;
73
74			$array[] = $flight;
75			}
76			$i++;
77			}
78			}
79			}
80
81			return $array;
82			}
83
84			}

laudeco / bbc-dolibarr-flightlog

Push — feature/api ( 725c17...de88d6 )

InstructionFlightQueryHandler::__invoke() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like