CreateFlightCommandHandler - Code Metrics - Inspection of "Create an order before a flight" - laudeco/bbc-dolibarr-flightlog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Laurent

created 2018-06-02 11:19 UTC

CreateFlightCommandHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	164
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
dl	0
loc	164
rs	10
c	0
b	0
f	0
wmc	14
lcom	1
cbo	2

5 Methods

Rating	Name	Size	Complexity
A	__construct()	13	1
B	handle()	35	3
B	handleOrder()	29	5
A	getOrderFromFlight()	5	1
A	numberOfPassengersLinkedToOrder()	19	4

<?php

require_once __DIR__ . '/../exceptions/FlightNotFoundException.php';
require_once __DIR__ . '/../class/bbcvols.class.php';

/**
 * @author Laurent De Coninck <[email protected]>
 */
class CreateFlightCommandHandler implements CommandHandlerInterface
{
    /**
     * @var DoliDB
     */
    private $db;

    /**
     * @var stdClass
     */
    private $conf;

    /**
     * @var User
     */
    private $user;

    /**
     * @var Translate
     */
    private $langs;

    /**
     * @var
     */
    private $validator;

    /**
     * @param DoliDB          $db
     * @param stdClass        $conf
     * @param User            $user
     * @param Translate       $langs
     * @param FlightValidator $validator
     */
    public function __construct(
        $db,
        $conf,
        $user,
        $langs,
        FlightValidator $validator
    ) {
        $this->db = $db;
        $this->conf = $conf->global;
        $this->user = $user;
        $this->langs = $langs;
        $this->validator = $validator;
    }

    /**
     * @param CreateFlightCommand|CommandInterface $command
     *
     * @return Bbcvols
     * @throws Exception
     */
    public function handle(CommandInterface $command)
    {
        $vol = new Bbcvols($this->db);
        $vol->date = $command->getDate();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->lieuD = $command->getLieuD();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->lieuA =$command->getLieuA();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->heureD = $command->getHeureD();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->heureA = $command->getHeureA();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->BBC_ballons_idBBC_ballons = $command->getBBCBallonsIdBBCBallons();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->nbrPax = $command->getNbrPax();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->remarque = $command->getRemarque();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->incidents = $command->getIncidents();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->fk_type = $command->getFkType();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->fk_pilot =$command->getFkPilot();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->fk_organisateur = $command->getFkOrganisateur();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->kilometers = $command->getKilometers();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->cost = $command->getCost();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->fk_receiver = $command->getFkReceiver();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->justif_kilometers = $command->getJustifKilometers();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->setPassengerNames($command->getPassengerNames());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $vol->setOrderId($command->getOrderId());
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        if (!$this->validator->isValid($vol, $_REQUEST)) {
            throw new Exception();
        }

        $result = $vol->create($this->user);
        if($result <= 0){
            throw new Exception();
        }

        $this->handleOrder($vol);

        return $vol;
    }

    /**
     * Handles the order of a flight.
     *
     * @param Bbcvols $flight
     *
     * @throws Exception
     */
    private function handleOrder($flight)
    {
        $flight->fetch($flight->id);

        if(!$flight->isLinkedToOrder()){
            return;
        }

        $order = $this->getOrderFromFlight($flight);
        $order->add_object_linked('flightlog_bbcvols', $flight->getId());

        $order->fetch_lines();

        $qtyOrder = 0;
        /** @var OrderLine $currentOrderLine */
        foreach($order->lines as $currentOrderLine){
            $qtyOrder += (int)$currentOrderLine->qty;
        }

        $passangersCount = $this->numberOfPassengersLinkedToOrder($order->id);

        if($passangersCount != $qtyOrder){
            return;
        }

        if($order->statut == Commande::STATUS_VALIDATED){
            $order->cloture($this->user);
        }
    }

    /**
     * @param Bbcvols $flight
     *
     * @return Commande
     * @throws Exception
     */
    private function getOrderFromFlight($flight)
    {
        $flight->fetchOrder();
        return $flight->getOrder();
    }

    /**
     * @param int $orderId
     *
     * @return int
     */
    private function numberOfPassengersLinkedToOrder($orderId)
    {
        $sql = sprintf('SELECT SUM(nbrPax) as total FROM `llx_bbc_vols` WHERE order_id = %s', $orderId);

        $resql = $this->db->query($sql);

        if ($resql) {
            $num = $this->db->num_rows($resql);
            $i = 0;
            if ($num) {
                while ($i < $num) {
                    $result = $this->db->fetch_array($resql);
                    return $result['total'];
                }
            }
        }

        return 0;
    }
}

1			<?php
2
3			require_once __DIR__ . '/../exceptions/FlightNotFoundException.php';
4			require_once __DIR__ . '/../class/bbcvols.class.php';
5
6			/**
7			* @author Laurent De Coninck <[email protected]>
8			*/
9			class CreateFlightCommandHandler implements CommandHandlerInterface
10			{
11			/**
12			* @var DoliDB
13			*/
14			private $db;
15
16			/**
17			* @var stdClass
18			*/
19			private $conf;
20
21			/**
22			* @var User
23			*/
24			private $user;
25
26			/**
27			* @var Translate
28			*/
29			private $langs;
30
31			/**
32			* @var
33			*/
34			private $validator;
35
36			/**
37			* @param DoliDB $db
38			* @param stdClass $conf
39			* @param User $user
40			* @param Translate $langs
41			* @param FlightValidator $validator
42			*/
43			public function __construct(
44			$db,
45			$conf,
46			$user,
47			$langs,
48			FlightValidator $validator
49			) {
50			$this->db = $db;
51			$this->conf = $conf->global;
52			$this->user = $user;
53			$this->langs = $langs;
54			$this->validator = $validator;
55			}
56
57			/**
58			* @param CreateFlightCommand\|CommandInterface $command
59			*
60			* @return Bbcvols
61			* @throws Exception
62			*/
63			public function handle(CommandInterface $command)
64			{
65			$vol = new Bbcvols($this->db);
66			$vol->date = $command->getDate();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getDate()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
67			$vol->lieuD = $command->getLieuD();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getLieuD()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
68			$vol->lieuA =$command->getLieuA();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getLieuA()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
69			$vol->heureD = $command->getHeureD();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getHeureD()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
70			$vol->heureA = $command->getHeureA();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getHeureA()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
71			$vol->BBC_ballons_idBBC_ballons = $command->getBBCBallonsIdBBCBallons();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getBBCBallonsIdBBCBallons()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
72			$vol->nbrPax = $command->getNbrPax();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getNbrPax()` does only exist in the following implementations of said interface: `CreateFlightCommand`, `CreateOrderCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
73			$vol->remarque = $command->getRemarque();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getRemarque()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
74			$vol->incidents = $command->getIncidents();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getIncidents()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
75			$vol->fk_type = $command->getFkType();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getFkType()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
76			$vol->fk_pilot =$command->getFkPilot();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getFkPilot()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
77			$vol->fk_organisateur = $command->getFkOrganisateur();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getFkOrganisateur()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
78			$vol->kilometers = $command->getKilometers();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getKilometers()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
79			$vol->cost = $command->getCost();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getCost()` does only exist in the following implementations of said interface: `CreateFlightCommand`, `CreateOrderCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
80			$vol->fk_receiver = $command->getFkReceiver();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getFkReceiver()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
81			$vol->justif_kilometers = $command->getJustifKilometers();
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getJustifKilometers()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
82			$vol->setPassengerNames($command->getPassengerNames());
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getPassengerNames()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
83			$vol->setOrderId($command->getOrderId());
			0 ignored issues – show Bug introduced 2018-06-02 09:46 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `CommandInterface` as the method `getOrderId()` does only exist in the following implementations of said interface: `CreateFlightCommand`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
84
85			if (!$this->validator->isValid($vol, $_REQUEST)) {
86			throw new Exception();
87			}
88
89			$result = $vol->create($this->user);
90			if($result <= 0){
91			throw new Exception();
92			}
93
94			$this->handleOrder($vol);
95
96			return $vol;
97			}
98
99			/**
100			* Handles the order of a flight.
101			*
102			* @param Bbcvols $flight
103			*
104			* @throws Exception
105			*/
106			private function handleOrder($flight)
107			{
108			$flight->fetch($flight->id);
109
110			if(!$flight->isLinkedToOrder()){
111			return;
112			}
113
114			$order = $this->getOrderFromFlight($flight);
115			$order->add_object_linked('flightlog_bbcvols', $flight->getId());
116
117			$order->fetch_lines();
118
119			$qtyOrder = 0;
120			/** @var OrderLine $currentOrderLine */
121			foreach($order->lines as $currentOrderLine){
122			$qtyOrder += (int)$currentOrderLine->qty;
123			}
124
125			$passangersCount = $this->numberOfPassengersLinkedToOrder($order->id);
126
127			if($passangersCount != $qtyOrder){
128			return;
129			}
130
131			if($order->statut == Commande::STATUS_VALIDATED){
132			$order->cloture($this->user);
133			}
134			}
135
136			/**
137			* @param Bbcvols $flight
138			*
139			* @return Commande
140			* @throws Exception
141			*/
142			private function getOrderFromFlight($flight)
143			{
144			$flight->fetchOrder();
145			return $flight->getOrder();
146			}
147
148			/**
149			* @param int $orderId
150			*
151			* @return int
152			*/
153			private function numberOfPassengersLinkedToOrder($orderId)
154			{
155			$sql = sprintf('SELECT SUM(nbrPax) as total FROM `llx_bbc_vols` WHERE order_id = %s', $orderId);
156
157			$resql = $this->db->query($sql);
158
159			if ($resql) {
160			$num = $this->db->num_rows($resql);
161			$i = 0;
162			if ($num) {
163			while ($i < $num) {
164			$result = $this->db->fetch_array($resql);
165			return $result['total'];
166			}
167			}
168			}
169
170			return 0;
171			}
172			}

laudeco / bbc-dolibarr-flightlog

Pull Request — master (#9)

CreateFlightCommandHandler A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like