Issues in readBalloonInc.php - All Issues - Inspection of "add energy icon" - laudeco/bbc-dolibarr-flightlog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9746a1...09623d )

by Laurent

created 2017-02-16 14:39 UTC

readBalloonInc.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * \file    mypage.php
 * \ingroup mymodule
 * \brief   Example PHP page.
 *
 * read flights
 */

// Load Dolibarr environment
if (false === (@include '../main.inc.php')) {  // From htdocs directory
    require '../../documents/custom/main.inc.php'; // From "custom" directory
}

global $db, $langs, $user;

dol_include_once('/flightLog/class/bbcvols.class.php');
dol_include_once("/flightBalloon/bbc_ballons.class.php");
dol_include_once('/flightLog/class/bbctypes.class.php');
dol_include_once("/flightLog/lib/flightLog.lib.php");

// Load translation files required by the page
$langs->load("mymodule@mymodule");

// Get parameters
$myparam = isset($_GET["myparam"])?$_GET["myparam"]:'';

// Protection if the user can't acces to the module
if (!$user->rights->flightLog->vol->access)
{
	accessforbidden();
}



/*******************************************************************
* ACTIONS
*
* Put here all code to do according to value of "action" parameter
********************************************************************/

//l'utilisateur a le droit de selectionner le ballon qu'il veut
if (($user->rights->flightLog->vol->detail))
{
	if(isset($_GET["ballon"])){
		$idBallon = $_GET['ballon'];
	}else{
		$idBallon =1;
	}
	
}else{
	
	//l'utilisateur n'a pas le choix du ballon
	//il est titulaire d'un ballon
	$query = 'SELECT * FROM llx_bbc_ballons';
	$query.= ' WHERE `fk_responsable` = '.$user->id;
	$resql = $db->query($query);
	if($resql){

		$num = $db->num_rows($resql);
		$i = 0;
		if($num){
			print'</tr>';
			while($i <$num){
				$obj = $db->fetch_object($resql); //vol
				if($obj){
					$idBallon = ($obj->rowid);
				}
			}
		}else{
			//il n'est pas titulaire d'un ballon
			accessforbidden("Vous n'&ecirc;tes pas titulaire du ballon");
		}
	}
}
if($idBallon != -1){
	
	//balloon with ID
	$ballon = New Bbc_ballons($db);
        
	if($ballon->fetch($idBallon)==-1){
		print "ERROR".$idBallon."<br/>";
	}
	//titulaire with ballon ID
        $titulaire = new User($db);
        $titulaire->fetch($ballon->fk_responsable);
        //flight with balloon ID
	$query = 'SELECT *, TIMEDIFF(heureA,heureD) AS time FROM llx_bbc_vols';
	$query.= ' WHERE `BBC_ballons_idBBC_ballons` = '.$ballon->id;
	$query.= ' AND `incidents` NOT LIKE \'RAS\'';
	$query.= ' AND `incidents` NOT LIKE \'\'';
	$query.= ' ORDER BY date';
	$resql = $db->query($query);
}



/***************************************************
* PAGE
*
* Put here all code to build page
****************************************************/

llxHeader('','Carnet de vol','');
if($msg && $idBallon != -1){
	print $msg;
}else{
	$form=new Form($db);
	
	print '<!-- debut cartouche rapport -->
	<div class="tabs">
	<a  class="tab" href="readFlightsBalloon.php?ballon='.$idBallon.'">Carnet de vol</a>
	<a id="active" class="tab" href="readBalloonInc.php?ballon='.$idBallon.'">Incidents</a>
	</div>';
	print '<div class="tabBar">';
	print "<form name='readBalloon' action=\"readFlightsBalloon.php\" method=\"get\">\n";
	print '<input type="hidden" name="mode" value="SELECT">';
	print '<table width="100%" class="border">';
	print '<tr><td>Ballon</td><td colspan="3">';
	if($user->rights->flightLog->vol->detail){
		select_balloons($idBallon);
	}else{
		print $ballon->immat;
	}
	
	print'</td></tr>';
        //titulaire
        print '<tr>';
        print '<td>Titulaire</td>';
        print '<td>'.$titulaire->getLoginUrl(1).'</td>';
        print '</tr>';
        //Vol initial
        print '<tr>';
        print '<td>Bapteme</td>';
        print '<td>'.dol_print_date($ballon->date, 'dayrfc').'</td>';
        print '</tr>';
        $num = 0;
	if($resql){

		//fetch pilot
		
		$num = $db->num_rows($resql);
                //>Nombre d'incidences
                print '<tr>';
                print '<td>Nombre d\'incidences</.td>';
                print '<td>' . $num . '</.td>';
                print '</tr>';
        }
                print '<tr><td colspan="4" align="center"><input type="submit" class="button" name="submit" value="Rafraichir"></td></tr></table>';
                print '</form></div>';


                print '<table class="border" width="100%">';
		$i = 0;
		if($num){
			print '<tr class="liste_titre">';
			print '<td class="liste_titre"> identifiant </td>';
			print '<td class="liste_titre"> Date </td>';
			print '<td class="liste_titre"> Ballon </td>';
			print '<td class="liste_titre"> Pilote </td>';
			print '<td class="liste_titre"> Lieu depart </td>';
			print '<td class="liste_titre"> Lieu arrivee </td>';
			print '<td class="liste_titre"> Heure depart</td>';
			print '<td class="liste_titre"> Heure Arrivee </td>';
			print '<td class="liste_titre"> Duree (min) </td>';
			print '<td class="liste_titre"> Nbr Pax </td>';
			print '<td class="liste_titre"> Rem </td>';
			print '<td class="liste_titre"> Incidents </td>';
			if($user->rights->flightLog->vol->status){
				print '<td class="liste_titre"> Statut </td>';
			}
			print'</tr>';
			while($i <$num){
				$obj = $db->fetch_object($resql); //vol
				print '<tr>';
				if($obj){
					$pilot = New User($db); //pilot
					$pilot->fetch($obj->fk_pilot);
					print '<td><a href="fiche.php?vol='.$obj->idBBC_vols.'">'.$obj->idBBC_vols.'</a></td>';
					print '<td>'.$obj->date.'</td>';
					print '<td>'.$ballon->immat.'</td>';
					print '<td>'.$pilot->getNomUrl().'</a></td>';
					print '<td>'.$obj->lieuD.'</td>';
					print '<td>'.$obj->lieuA.'</td>';
					print '<td>'.$obj->heureD.'</td>';
					print '<td>'.$obj->heureA.'</td>';
					print '<td>'.$obj->time.'</td>';
					print '<td>'.$obj->nbrPax.'</td>';
					print '<td>'.$obj->remarque.'</td>';
					print '<td>'.$obj->incidents.'</td>';
					if($user->rights->flightLog->vol->status){
						$vol = new Bbcvols($db);
						$vol->fetch($obj->idBBC_vols);
                        print '<td>' . $vol->getStatus().'</td>';
					}
				}
				print'</tr>';
				$i++;
			}
		}	
		print'</table>';
	
}
/***************************************************
* LINKED OBJECT BLOCK
*
* Put here code to view linked object
****************************************************/
//$somethingshown=$myobject->showLinkedObjectBlock();


// End of page
$db->close();
llxFooter('$Date: 2011/07/31 22:21:57 $ - $Revision: 1.19 $');
?>



1		<?php
2		/**
3		* \file mypage.php
4		* \ingroup mymodule
5		* \brief Example PHP page.
6		*
7		* read flights
8		*/
9
10		// Load Dolibarr environment
11		if (false === (@include '../main.inc.php')) { // From htdocs directory
12		require '../../documents/custom/main.inc.php'; // From "custom" directory
13		}
14
15		global $db, $langs, $user;
16
17		dol_include_once('/flightLog/class/bbcvols.class.php');
18		dol_include_once("/flightBalloon/bbc_ballons.class.php");
19		dol_include_once('/flightLog/class/bbctypes.class.php');
20		dol_include_once("/flightLog/lib/flightLog.lib.php");
21
22		// Load translation files required by the page
23		$langs->load("mymodule@mymodule");
24
25		// Get parameters
26		$myparam = isset($_GET["myparam"])?$_GET["myparam"]:'';
27
28		// Protection if the user can't acces to the module
29		if (!$user->rights->flightLog->vol->access)
30		{
31		accessforbidden();
32		}
33
34
35
36		/*******************************************************************
37		* ACTIONS
38		*
39		* Put here all code to do according to value of "action" parameter
40		********************************************************************/
41
42		//l'utilisateur a le droit de selectionner le ballon qu'il veut
43		if (($user->rights->flightLog->vol->detail))
44		{
45		if(isset($_GET["ballon"])){
46		$idBallon = $_GET['ballon'];
47		}else{
48		$idBallon =1;
49		}
50
51		}else{
52
53		//l'utilisateur n'a pas le choix du ballon
54		//il est titulaire d'un ballon
55		$query = 'SELECT * FROM llx_bbc_ballons';
56		$query.= ' WHERE `fk_responsable` = '.$user->id;
57		$resql = $db->query($query);
58	View Code Duplication	if($resql){
		0 ignored issues – show Duplication introduced 2017-02-16 14:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		$num = $db->num_rows($resql);
60		$i = 0;
61		if($num){
62		print'</tr>';
63		while($i <$num){
64		$obj = $db->fetch_object($resql); //vol
65		if($obj){
66		$idBallon = ($obj->rowid);
67		}
68		}
69		}else{
70		//il n'est pas titulaire d'un ballon
71		accessforbidden("Vous n'êtes pas titulaire du ballon");
72		}
73		}
74		}
75		if($idBallon != -1){
76
77		//balloon with ID
78		$ballon = New Bbc_ballons($db);
79
80		if($ballon->fetch($idBallon)==-1){
81		print "ERROR".$idBallon."<br/>";
82		}
83		//titulaire with ballon ID
84		$titulaire = new User($db);
85		$titulaire->fetch($ballon->fk_responsable);
86		//flight with balloon ID
87		$query = 'SELECT *, TIMEDIFF(heureA,heureD) AS time FROM llx_bbc_vols';
88		$query.= ' WHERE `BBC_ballons_idBBC_ballons` = '.$ballon->id;
89		$query.= ' AND `incidents` NOT LIKE \'RAS\'';
90		$query.= ' AND `incidents` NOT LIKE \'\'';
91		$query.= ' ORDER BY date';
92		$resql = $db->query($query);
93		}
94
95
96
97		/***************************************************
98		* PAGE
99		*
100		* Put here all code to build page
101		****************************************************/
102
103		llxHeader('','Carnet de vol','');
104		if($msg && $idBallon != -1){
105		print $msg;
106		}else{
107		$form=new Form($db);
108
109		print '<!-- debut cartouche rapport -->
110		<div class="tabs">
111		<a class="tab" href="readFlightsBalloon.php?ballon='.$idBallon.'">Carnet de vol</a>
112		<a id="active" class="tab" href="readBalloonInc.php?ballon='.$idBallon.'">Incidents</a>
113		</div>';
114		print '<div class="tabBar">';
115		print "<form name='readBalloon' action=\"readFlightsBalloon.php\" method=\"get\">\n";
116		print '<input type="hidden" name="mode" value="SELECT">';
117		print '<table width="100%" class="border">';
118		print '<tr><td>Ballon</td><td colspan="3">';
119		if($user->rights->flightLog->vol->detail){
120		select_balloons($idBallon);
121		}else{
122		print $ballon->immat;
123		}
124
125		print'</td></tr>';
126		//titulaire
127		print '<tr>';
128		print '<td>Titulaire</td>';
129		print '<td>'.$titulaire->getLoginUrl(1).'</td>';
130		print '</tr>';
131		//Vol initial
132		print '<tr>';
133		print '<td>Bapteme</td>';
134		print '<td>'.dol_print_date($ballon->date, 'dayrfc').'</td>';
135		print '</tr>';
136		$num = 0;
137	View Code Duplication	if($resql){
		0 ignored issues – show Duplication introduced 2017-02-16 14:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
138		//fetch pilot
139
140		$num = $db->num_rows($resql);
141		//>Nombre d'incidences
142		print '<tr>';
143		print '<td>Nombre d\'incidences</.td>';
144		print '<td>' . $num . '</.td>';
145		print '</tr>';
146		}
147		print '<tr><td colspan="4" align="center"><input type="submit" class="button" name="submit" value="Rafraichir"></td></tr></table>';
148		print '</form></div>';
149
150
151		print '<table class="border" width="100%">';
152		$i = 0;
153		if($num){
154		print '<tr class="liste_titre">';
155		print '<td class="liste_titre"> identifiant </td>';
156		print '<td class="liste_titre"> Date </td>';
157		print '<td class="liste_titre"> Ballon </td>';
158		print '<td class="liste_titre"> Pilote </td>';
159		print '<td class="liste_titre"> Lieu depart </td>';
160		print '<td class="liste_titre"> Lieu arrivee </td>';
161		print '<td class="liste_titre"> Heure depart</td>';
162		print '<td class="liste_titre"> Heure Arrivee </td>';
163		print '<td class="liste_titre"> Duree (min) </td>';
164		print '<td class="liste_titre"> Nbr Pax </td>';
165		print '<td class="liste_titre"> Rem </td>';
166		print '<td class="liste_titre"> Incidents </td>';
167		if($user->rights->flightLog->vol->status){
168		print '<td class="liste_titre"> Statut </td>';
169		}
170		print'</tr>';
171		while($i <$num){
172		$obj = $db->fetch_object($resql); //vol
173		print '<tr>';
174		if($obj){
175		$pilot = New User($db); //pilot
176		$pilot->fetch($obj->fk_pilot);
177		print '<td><a href="fiche.php?vol='.$obj->idBBC_vols.'">'.$obj->idBBC_vols.'</a></td>';
178		print '<td>'.$obj->date.'</td>';
179		print '<td>'.$ballon->immat.'</td>';
180		print '<td>'.$pilot->getNomUrl().'</a></td>';
181		print '<td>'.$obj->lieuD.'</td>';
182		print '<td>'.$obj->lieuA.'</td>';
183		print '<td>'.$obj->heureD.'</td>';
184		print '<td>'.$obj->heureA.'</td>';
185		print '<td>'.$obj->time.'</td>';
186		print '<td>'.$obj->nbrPax.'</td>';
187		print '<td>'.$obj->remarque.'</td>';
188		print '<td>'.$obj->incidents.'</td>';
189		if($user->rights->flightLog->vol->status){
190		$vol = new Bbcvols($db);
191		$vol->fetch($obj->idBBC_vols);
192		print '<td>' . $vol->getStatus().'</td>';
193		}
194		}
195		print'</tr>';
196		$i++;
197		}
198		}
199		print'</table>';
200
201		}
202		/***************************************************
203		* LINKED OBJECT BLOCK
204		*
205		* Put here code to view linked object
206		****************************************************/
207		//$somethingshown=$myobject->showLinkedObjectBlock();
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-02-16 14:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this `75%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
208
209		// End of page
210		$db->close();
211		llxFooter('$Date: 2011/07/31 22:21:57 $ - $Revision: 1.19 $');
212		?>
		0 ignored issues – show Best Practice introduced 2017-02-16 14:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
213

laudeco / bbc-dolibarr-flightlog

Push — master ( 9746a1...09623d )

readBalloonInc.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like