laudeco / bbc-dolibarr-flightlog

command/CreateFlightBillCommand.php

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
             throw new \InvalidArgumentException('Model document is missing');
         }
 
-        if(!isset($nbrPax) || !is_numeric($nbrPax) || $nbrPax != (int) $nbrPax){
+        if (!isset($nbrPax) || !is_numeric($nbrPax) || $nbrPax != (int) $nbrPax) {
             throw new \InvalidArgumentException('The number of pax is not correct, an integer is expected');
         }
 

command/CreateFlightBillCommandHandler.php

Spacing +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
     {
         $customer = new Client($this->db);
 
-        if($flight->fk_receiver) {
+        if ($flight->fk_receiver) {
             return $this->fetchCustomerFromFlight($flight);
         }
 

facture.php

Spacing +4 added lines, -4 removed lines

@@ -124,11 +124,11 @@
  * Put here all code to do according to value of "action" parameter
  */
 if ($action == EXPENSE_REPORT_GENERATOR_ACTION_GENERATE) {
-    try{
-        $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote,$bankAccount, $nbrPax);
+    try {
+        $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote, $bankAccount, $nbrPax);
         $handler->handle($command);
-    }catch (\Exception $e){
-        dol_syslog($e->getMessage(),LOG_ERR);
+    } catch (\Exception $e) {
+        dol_syslog($e->getMessage(), LOG_ERR);
         dol_htmloutput_mesg("Facture non créée", '', 'error');
     }
 }

Braces +6 added lines, -3 removed lines

@@ -127,7 +127,7 @@ 
     try{
         $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote,$bankAccount, $nbrPax);
         $handler->handle($command);
-    }catch (\Exception $e){
+    } catch (\Exception $e){
         dol_syslog($e->getMessage(),LOG_ERR);
         dol_htmloutput_mesg("Facture non créée", '', 'error');
     }
@@ -268,9 +268,12 @@ 
 
         <?php if (!$flightProduct || !$flight->hasReceiver()) : ?>
             <a class="butActionRefused" href="#">Générer</a>
-        <?php else: ?>
+        <?php else {
+    : ?>
             <button class="butAction" type="submit">Générer</button>
-        <?php endif; ?>
+        <?php endif;
+}
+?>
 
         <a class="butAction" href="<?php echo DOL_URL_ROOT . '/flightlog/card.php?id=' . $flight->id; ?>">Retour au
             vol</a>

class/bbctypes.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -645,7 +645,7 @@
     }
 
     /**
-     * @return array|BbctypesLine[]
+     * @return BbctypesLine[]
      */
     public function getLines()
     {

Spacing +1 added lines, -1 removed lines

@@ -733,7 +733,7 @@
      */
     public function getActive()
     {
-        return (boolean)$this->active;
+        return (boolean) $this->active;
     }
 
     /**

Form/FlightTypeSelect.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
      */
     private function buildOptions()
     {
-        foreach($this->flightType->getLines() as $currentFlightType){
+        foreach ($this->flightType->getLines() as $currentFlightType) {
             $this->addValueOption($currentFlightType->getId(), $currentFlightType->getLabel());
         }
     }

validators/AbstractValidator.php

Spacing +2 added lines, -2 removed lines

@@ -109,8 +109,8 @@
      *
      * @return array|string[]
      */
-    public function getError($field){
-        if(!$this->hasError($field)){
+    public function getError($field) {
+        if (!$this->hasError($field)) {
             return [];
         }
 

Form/Form.php

Spacing +16 added lines, -16 removed lines

@@ -78,7 +78,7 @@ 
     /**
      * @inheritDoc
      */
-    public function getOptions(){
+    public function getOptions() {
         return $this->options;
     }
 
@@ -98,18 +98,18 @@ 
      */
     public function validate()
     {
-        if(!$this->validator){
+        if (!$this->validator) {
             return true;
         }
 
-        if(null === $this->object){
+        if (null === $this->object) {
             throw new \InvalidArgumentException('Object not bound');
         }
 
         $validation = $this->validator->isValid($this->object, $_REQUEST);
         
-        if(!$validation){
-            foreach($this->elements as $fieldName => $field){
+        if (!$validation) {
+            foreach ($this->elements as $fieldName => $field) {
                 $field->setErrors($this->validator->getError($fieldName));
             }
         }
@@ -120,7 +120,7 @@ 
     /**
      * @return array|string[]
      */
-    public function getErrorMessages(){
+    public function getErrorMessages() {
         return $this->validator->getErrors();
     }
 
@@ -141,10 +141,10 @@ 
      */
     public function bind($object)
     {
-        foreach($this->elements as $element){
+        foreach ($this->elements as $element) {
             $name = $this->camelCase($element->getName());
-            $methodName = 'get'.$name;
-            if(!method_exists($object, $methodName)){
+            $methodName = 'get' . $name;
+            if (!method_exists($object, $methodName)) {
                 continue;
             }
 
@@ -161,24 +161,24 @@ 
      */
     public function setData(array $data)
     {
-        foreach($data as $fieldName => $currentData){
-            if(!key_exists($fieldName, $this->elements) || $this->elements[$fieldName]->isDisabled()){
+        foreach ($data as $fieldName => $currentData) {
+            if (!key_exists($fieldName, $this->elements) || $this->elements[$fieldName]->isDisabled()) {
                 continue;
             }
 
             $this->elements[$fieldName]->setValue($currentData);
 
-            $methodName = 'set'.$this->camelCase($fieldName);
-            if(null === $this->object){
+            $methodName = 'set' . $this->camelCase($fieldName);
+            if (null === $this->object) {
                 continue;
             }
 
-            if(method_exists($this->object, $methodName)){
+            if (method_exists($this->object, $methodName)) {
                 $this->object->{$methodName}($currentData);
                 continue;
             }
 
-            if(property_exists($this->object, $fieldName)){
+            if (property_exists($this->object, $fieldName)) {
                 $this->object->{$fieldName} = $currentData;
                 continue;
             }
@@ -200,7 +200,7 @@ 
      */
     public function getElement($elementName)
     {
-        if(!key_exists($elementName, $this->elements)){
+        if (!key_exists($elementName, $this->elements)) {
             throw new \InvalidArgumentException(sprintf('Element %s not found ', $elementName));
         }
 

Doc Comments +2 added lines, -1 removed lines

@@ -95,6 +95,7 @@ 
 
     /**
      * @inheritDoc
+     * @param string $fieldName
      */
     public function remove($fieldName)
     {
@@ -142,7 +143,7 @@ 
     }
 
     /**
-     * @param null|\ValidatorInterface $validator
+     * @param ValidatorInterface $validator
      *
      * @return Form
      */

Form/Select.php

Spacing +2 added lines, -2 removed lines

@@ -51,7 +51,7 @@ 
      *
      * @return $this
      */
-    public function addValueOption($key, $value){
+    public function addValueOption($key, $value) {
         $this->valueOptions[$key] = $value;
         return $this;
     }
@@ -63,7 +63,7 @@ 
     {
         parent::setValue($value);
 
-        if(!isset($this->valueOptions[$value])){
+        if (!isset($this->valueOptions[$value])) {
             $this->valueOptions[$value] = empty($value) ? ' ' : $value;
         }
     }

Form/BalloonSelect.php

Spacing +6 added lines, -6 removed lines

@@ -31,12 +31,12 @@
     private function buildOptions()
     {
         $sql = "SELECT";
-        $sql.= " t.rowid,";
-        $sql.= " t.immat,";
-        $sql.= " t.is_disable";
-        $sql.= " FROM llx_bbc_ballons as t";
-        $sql.= " WHERE t.is_disable = 0";
-        $sql.= " ORDER BY t.immat";
+        $sql .= " t.rowid,";
+        $sql .= " t.immat,";
+        $sql .= " t.is_disable";
+        $sql .= " FROM llx_bbc_ballons as t";
+        $sql .= " WHERE t.is_disable = 0";
+        $sql .= " ORDER BY t.immat";
 
         $resql = $this->db->query($sql);
         if ($resql) {