laudeco / bbc-dolibarr-flightlog

Infrastructure/Common/Repository/AbstractDomainRepository.php

Spacing +14 added lines, -14 removed lines

@@ -23,7 +23,7 @@ 
     public function __construct(\DoliDB $db, $tableName)
     {
         $this->db = $db;
-        $this->tableName = strpos($tableName, MAIN_DB_PREFIX) === 0 ? $tableName : MAIN_DB_PREFIX.$tableName;
+        $this->tableName = strpos($tableName, MAIN_DB_PREFIX) === 0 ? $tableName : MAIN_DB_PREFIX . $tableName;
     }
 
     /**
@@ -33,7 +33,7 @@ 
      *
      * @throws \Exception
      */
-    protected function write(array $elements){
+    protected function write(array $elements) {
         $columns = join(',', array_keys($elements));
         $values = join(',', array_map([$this, 'escape'], array_values($elements)));
 
@@ -44,7 +44,7 @@ 
             $lasterror = $this->db->lasterror();
             dol_syslog(__METHOD__ . ' ' . $lasterror, LOG_ERR);
             $this->db->rollback();
-            throw new \Exception("Repository error - ".$lasterror);
+            throw new \Exception("Repository error - " . $lasterror);
         }
 
         $id = $this->db->last_insert_id($this->tableName);
@@ -57,16 +57,16 @@ 
      *
      * @return int|string|null
      */
-    private function escape($value){
-        if(is_null($value)){
+    private function escape($value) {
+        if (is_null($value)) {
             return null;
         }
 
-        if(is_bool($value)){
-            return (int)$value;
+        if (is_bool($value)) {
+            return (int) $value;
         }
 
-        return is_string($value) ? $this->db->escape($value) : $value ;
+        return is_string($value) ? $this->db->escape($value) : $value;
     }
 
     /**
@@ -79,18 +79,18 @@ 
     {
         $sqlModifications = [];
 
-        foreach($elements as $field => $value){
+        foreach ($elements as $field => $value) {
             $sqlModifications[] = sprintf('%s=%s', $field, $this->escape($value));
         }
 
         $this->db->begin();
-        $resql = $this->db->query(sprintf('UPDATE %s SET %s WHERE rowid = %s ', $this->tableName, join(',',$sqlModifications), $id));
+        $resql = $this->db->query(sprintf('UPDATE %s SET %s WHERE rowid = %s ', $this->tableName, join(',', $sqlModifications), $id));
 
         if (!$resql) {
             $lasterror = $this->db->lasterror();
             dol_syslog(__METHOD__ . ' ' . $lasterror, LOG_ERR);
             $this->db->rollback();
-            throw new \Exception("Repository error - ".$lasterror);
+            throw new \Exception("Repository error - " . $lasterror);
         }
 
         $this->db->commit();
@@ -103,8 +103,8 @@ 
      *
      * @return array|null
      */
-    protected function get($id){
-        $sql = sprintf('SELECT * FROM %s WHERE rowid = %s', $this->tableName, $id );
+    protected function get($id) {
+        $sql = sprintf('SELECT * FROM %s WHERE rowid = %s', $this->tableName, $id);
 
         $resql = $this->db->query($sql);
         if (!$resql) {
@@ -116,7 +116,7 @@ 
             return null;
         }
 
-        for($i = 0; $i < $num ; $i++) {
+        for ($i = 0; $i < $num; $i++) {
             return $this->db->fetch_array($resql);
         }
 

Infrastructure/Damage/Query/Repository/GetDamagesForFlightQueryRepository.php

Spacing +4 added lines, -4 removed lines

@@ -31,15 +31,15 @@
     public function __invoke($flightId)
     {
         $sql = 'SELECT damage.rowid as id, damage.amount, author.login as author_name, damage.billed as invoiced';
-        $sql.=' FROM '.MAIN_DB_PREFIX.'bbc_flight_damages as damage';
-        $sql.=' INNER JOIN '.MAIN_DB_PREFIX.'user as author ON author.rowid = damage.author_id';
-        $sql.=' WHERE damage.flight_id = '.$this->db->escape($flightId);
+        $sql .= ' FROM ' . MAIN_DB_PREFIX . 'bbc_flight_damages as damage';
+        $sql .= ' INNER JOIN ' . MAIN_DB_PREFIX . 'user as author ON author.rowid = damage.author_id';
+        $sql .= ' WHERE damage.flight_id = ' . $this->db->escape($flightId);
 
         $resql = $this->db->query($sql);
         if ($resql) {
             $num = $this->db->num_rows($resql);
             if ($num) {
-                for($i = 0; $i < $num ; $i++) {
+                for ($i = 0; $i < $num; $i++) {
                     $properties = $this->db->fetch_array($resql);
                     yield Damage::fromArray($properties);
                 }

Infrastructure/Damage/Repository/FlightDamageRepository.php

Spacing +3 added lines, -3 removed lines

@@ -35,7 +35,7 @@ 
             'author_id' => $flightDamage->getAuthor()->getId()
         ];
 
-        if($flightDamage->getId()){
+        if ($flightDamage->getId()) {
             $this->update($flightDamage->getId()->getId(), $fields);
             return;
         }
@@ -50,10 +50,10 @@ 
      *
      * @throws \Exception
      */
-    public function getById(DamageId $id){
+    public function getById(DamageId $id) {
         $damage = $this->get($id->getId());
 
-        if(null === $damage){
+        if (null === $damage) {
             throw new \Exception('Damage not found');
         }
 

class/Damage/FlightDamage.php

Indentation +5 added lines, -5 removed lines

@@ -39,11 +39,11 @@
      */
     private function __construct(FlightId $flightId, DamageAmount $amount, $billed, AuthorId $authorId, DamageId $id = null)
     {
-       $this->flight = $flightId;
-       $this->amount = $amount;
-       $this->billed = $billed;
-       $this->author = $authorId;
-       $this->id = $id;
+        $this->flight = $flightId;
+        $this->amount = $amount;
+        $this->billed = $billed;
+        $this->author = $authorId;
+        $this->id = $id;
     }
 
     /**

Spacing +5 added lines, -5 removed lines

@@ -55,7 +55,7 @@ 
      *
      * @return FlightDamage
      */
-    public static function load(FlightId $flightId, DamageAmount $amount, $billed, AuthorId $authorId, DamageId $id = null){
+    public static function load(FlightId $flightId, DamageAmount $amount, $billed, AuthorId $authorId, DamageId $id = null) {
         return new self($flightId, $amount, $billed, $authorId, $id);
     }
 
@@ -66,7 +66,7 @@ 
      *
      * @return FlightDamage
      */
-    public static function damage(FlightId $flightId, DamageAmount $amount, AuthorId $authorId){
+    public static function damage(FlightId $flightId, DamageAmount $amount, AuthorId $authorId) {
         return new self($flightId, $amount, false, $authorId);
     }
 
@@ -81,14 +81,14 @@ 
     /**
      * @return FlightId
      */
-    public function getFlightId(){
+    public function getFlightId() {
         return $this->flight;
     }
 
     /**
      * @return DamageAmount
      */
-    public function amount(){
+    public function amount() {
         return $this->amount;
     }
 
@@ -105,7 +105,7 @@ 
      *
      * @return FlightDamage
      */
-    public function invoice(){
+    public function invoice() {
         return new self($this->flight, $this->amount, true, $this->author, $this->id);
     }
 

Http/Web/Controller/FlightDamageController.php

Spacing +4 added lines, -4 removed lines

@@ -57,7 +57,7 @@ 
 
         $url = sprintf('%s/flightlog/card_tab_damage.php?id=%s&damage=%s', DOL_URL_ROOT, $flightId, $currentDamageId);
 
-        $html = $form->formconfirm($url, 'êtes-vous sure de vouloir marquer ce dégât comme facturé?', '','confirm_bill_damage');
+        $html = $form->formconfirm($url, 'êtes-vous sure de vouloir marquer ce dégât comme facturé?', '', 'confirm_bill_damage');
 
         $this->renderHtml($html);
     }
@@ -68,12 +68,12 @@ 
         $currentDamageId = $this->request->getParam('damage');
         $confirmation = $this->request->getParam('confirm');
 
-        if(!$this->request->isPost() || $confirmation === 'no'){
-            $this->redirect($_SERVER["PHP_SELF"].'?id='.$flightId);
+        if (!$this->request->isPost() || $confirmation === 'no') {
+            $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $flightId);
             return;
         }
 
         $this->getInvoiceDamageCommandHandler()->__invoke(new InvoiceDamageCommand($currentDamageId));
-        $this->redirect($_SERVER["PHP_SELF"].'?id='.$flightId);
+        $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $flightId);
     }
 }
\ No newline at end of file

Http/Web/Controller/WebController.php

Spacing +4 added lines, -4 removed lines

@@ -24,19 +24,19 @@
         $this->request = new Request();
     }
 
-    protected function render($template, array $variables = []){
+    protected function render($template, array $variables = []) {
 
-        foreach($variables as $variableName => $variableValue){
+        foreach ($variables as $variableName => $variableValue) {
             $GLOBALS[$variableName] = $variableValue;
         }
 
-        return include __DIR__.'/../templates/'.$template;
+        return include __DIR__ . '/../templates/' . $template;
     }
 
     /**
      * @param string $html
      */
-    protected function renderHtml($html){
+    protected function renderHtml($html) {
         print $html;
     }
 

Http/Web/templates/flight_damage/view.php

Spacing +6 added lines, -6 removed lines

@@ -14,21 +14,21 @@
         <td>Montant</td>
     </tr>
     <?php $total = 0; ?>
-    <?php foreach($damages as $currentDamage):?>
+    <?php foreach ($damages as $currentDamage):?>
         <?php $total += $currentDamage->getAmount(); ?>
         <tr>
-            <td><?php echo $currentDamage->getAuthorName();?></td>
-            <td><?php echo $currentDamage->getAmount();?>€</td>
+            <td><?php echo $currentDamage->getAuthorName(); ?></td>
+            <td><?php echo $currentDamage->getAmount(); ?>€</td>
             <td>
-                <?php if($currentDamage->isInvoiced()): ?>
+                <?php if ($currentDamage->isInvoiced()): ?>
                     <i class="fas fa-check"></i>
                 <?php else: ?>
                     <i class="fas fa-times"></i>
                 <?php endif; ?>
             </td>
             <td>
-                <?php if(!$currentDamage->isInvoiced()): ?>
-                    <a href="<?php print sprintf('%s/flightlog/card_tab_damage.php?id=%s&action=%s&damage=%s', DOL_URL_ROOT, $flightId, 'bill_damage', $currentDamage->getId());?>"><i class="fas fa-file-invoice"></i></a>
+                <?php if (!$currentDamage->isInvoiced()): ?>
+                    <a href="<?php print sprintf('%s/flightlog/card_tab_damage.php?id=%s&action=%s&damage=%s', DOL_URL_ROOT, $flightId, 'bill_damage', $currentDamage->getId()); ?>"><i class="fas fa-file-invoice"></i></a>
                 <?php endif; ?>
             </td>
         </tr>

Braces +5 added lines, -2 removed lines

@@ -22,9 +22,12 @@
             <td>
                 <?php if($currentDamage->isInvoiced()): ?>
                     <i class="fas fa-check"></i>
-                <?php else: ?>
+                <?php else {
+    : ?>
                     <i class="fas fa-times"></i>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             </td>
             <td>
                 <?php if(!$currentDamage->isInvoiced()): ?>