laudeco / bbc-dolibarr-flightlog

Http/Web/Controller/AddFlightDamageController.php

Spacing +10 added lines, -10 removed lines

@@ -19,16 +19,16 @@ 
     /**
      * Display the form.
      */
-    public function view(){
+    public function view() {
         $id = $this->request->getParam('id');
 
-        if($id === null){
+        if ($id === null) {
             print '<p>Paramètre non fournis.</p>';
             return;
         }
 
         $flight = new \Bbcvols($this->db);
-        if($flight->fetch($id) <= 0){
+        if ($flight->fetch($id) <= 0) {
             print '<p>Vol non trouvé</p>';
             return;
         }
@@ -37,24 +37,24 @@ 
         $form = new DamageCreationForm('damage_creation', $this->db);
         $form->bind($command);
 
-        if($this->request->isPost()){
+        if ($this->request->isPost()) {
             $form->setData($this->request->getPostParameters());
 
-            if(!$form->validate()){
+            if (!$form->validate()) {
                 return $this->render('flight_damage/form.php', [
                     'form' => $form,
                 ]);
             }
 
-            try{
+            try {
                 $this->handle($form->getObject());
-            }catch(\Exception $e){
+            } catch (\Exception $e) {
                 print $e->getMessage();
                 dol_syslog($e->getMessage(), LOG_ERR);
             }
 
 
-            $this->redirect($_SERVER["PHP_SELF"].'?id='.$id);
+            $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $id);
             exit;
         }
 
@@ -76,14 +76,14 @@ 
     /**
      * @return CreateDamageCommandHandler
      */
-    private function getHandler(){
+    private function getHandler() {
         return new CreateDamageCommandHandler($this->db, $this->getDamageRepository());
     }
 
     /**
      * @return FlightDamageRepository
      */
-    private function getDamageRepository(){
+    private function getDamageRepository() {
         return new FlightDamageRepository($this->db);
     }
 

Braces +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
 
             try{
                 $this->handle($form->getObject());
-            }catch(\Exception $e){
+            } catch(\Exception $e){
                 print $e->getMessage();
                 dol_syslog($e->getMessage(), LOG_ERR);
             }

class/Common/ValueObject/Id.php

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
      *
      * @return Id
      */
-    public static function create($id){
+    public static function create($id) {
         return new self($id);
     }
 

class/card/TabCollection.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * @return array
      */
     public function toArray() {
-        return array_map(function(Tab $tab){
+        return array_map(function(Tab $tab) {
             return $tab->toArray();
         }, $this->tabs);
     }

Application/Damage/Command/CreateDamageCommandHandler.php

Spacing +1 added lines, -1 removed lines

@@ -55,7 +55,7 @@
      */
     private function linkSupplierInvoice($flightId, $invoiceId)
     {
-        if($invoiceId <= 0){
+        if ($invoiceId <= 0) {
             return;
         }
 

card_tab_damage.php

Braces +1 added lines, -1 removed lines

@@ -90,7 +90,7 @@
         $actionName = $routes[$action][1];
 
         call_user_func([new $controllerName($db), $actionName]);
-    }else{
+    } else{
         echo 'Route non trouvée.';
     }
 ?>

Spacing +8 added lines, -8 removed lines

@@ -49,7 +49,7 @@ 
 
 $id = GETPOST('id', 'int') ?: GETPOST('idBBC_vols', 'int');
 $action = GETPOST('action', 'alpha');
-$permissiondellink=$user->rights->flightlog->vol->financial;
+$permissiondellink = $user->rights->flightlog->vol->financial;
 
 $object = new Bbcvols($db);
 
@@ -57,8 +57,8 @@ 
 $extralabels = $extrafields->fetch_name_optionals_label($object->table_element);
 
 // Load object
-include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php';  // Must be include, not include_once  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
-include DOL_DOCUMENT_ROOT.'/core/actions_dellink.inc.php';
+include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php'; // Must be include, not include_once  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
+include DOL_DOCUMENT_ROOT . '/core/actions_dellink.inc.php';
 
 // Initialize technical object to manage hooks of modules. Note that conf->hooks_modules contains array array
 $hookmanager->initHooks(array('bbcvols'));
@@ -87,12 +87,12 @@ 
         FLIGHTLOG_ACTION_CONFIRM_BILL_DAMAGE => [FlightDamageController::class, 'handleInvoice'],
     ];
 
-    if(isset($routes[$action])){
+    if (isset($routes[$action])) {
         $controllerName = $routes[$action][0];
         $actionName = $routes[$action][1];
 
         call_user_func([new $controllerName($db), $actionName]);
-    }else{
+    } else {
         echo 'Route non trouvée.';
     }
 ?>
@@ -104,13 +104,13 @@ 
 // Buttons
 print '<div class="tabsAction">' . "\n";
 
-if($user->rights->flightlog->vol->financial){
-    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/card_tab_damage.php?id=' . $object->id.'&action='.FLIGHTLOG_ACTION_ADD_DAMAGE.'">' . $langs->trans("Ajouter") . '</a></div>' . "\n";
+if ($user->rights->flightlog->vol->financial) {
+    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/card_tab_damage.php?id=' . $object->id . '&action=' . FLIGHTLOG_ACTION_ADD_DAMAGE . '">' . $langs->trans("Ajouter") . '</a></div>' . "\n";
 }
 
 print '</div>' . "\n";
 
-if($user->rights->flightlog->vol->financial){
+if ($user->rights->flightlog->vol->financial) {
     print '<div class="fichecenter"><div class="fichehalfleft">';
     $form->showLinkedObjectBlock($object);
     print '</div></div>';

query/BillableFlightQueryHandler.php

Spacing +2 added lines, -2 removed lines

@@ -145,7 +145,7 @@ 
 
         //Total damages
         $damages = $this->pilotDamageQueryRepository->query($query->getFiscalYear());
-        foreach($damages as $currentDamage){
+        foreach ($damages as $currentDamage) {
 
             //Pilot doesn't exist
             if (!isset($pilots[$currentDamage->getAuthorId()])) {
@@ -158,7 +158,7 @@ 
             );
 
             // The damage is already invoiced. So not take into account.
-            if($currentDamage->isInvoiced()){
+            if ($currentDamage->isInvoiced()) {
                 $pilots[$currentDamage->getAuthorId()] = $pilots[$currentDamage->getAuthorId()]->addCount(
                     new FlightTypeCount('invoiced_damage', $currentDamage->getAmount(), -1)
                 );

readFlights.php

Spacing +5 added lines, -5 removed lines

@@ -230,7 +230,7 @@ 
     print '<td>' . $pilot->getCountForType('orga_T6')->getCount() . '</td>';
     print '<td>' . $pilot->getCountForType('orga_T6')->getCost()->getValue() . '</td>';
 
-    print sprintf('<td class="%s">', $pilot->getFlightBonus()->getValue() === 0?'text-muted':'text-bold'). $pilot->getFlightBonus()->getValue() . ' pts</td>';
+    print sprintf('<td class="%s">', $pilot->getFlightBonus()->getValue() === 0 ? 'text-muted' : 'text-bold') . $pilot->getFlightBonus()->getValue() . ' pts</td>';
 
     print '<td>' . $pilot->getCountForType('3')->getCount() . '</td>';
     print '<td>' . price($pilot->getCountForType('3')->getCost()->getValue()) . '€</td>';
@@ -249,8 +249,8 @@ 
     print '<td>' . price($pilot->getCountForType('damage')->getCost()->getValue()) . '€</td>';
     print '<td>' . price($pilot->getCountForType('invoiced_damage')->getCost()->getValue()) . '€</td>';
 
-    print sprintf('<td class="%s">', $pilot->getFlightsCost()->getValue() === 0?'text-muted':'text-bold'). price($pilot->getFlightsCost()->getValue()) . '€ </td>';
-    print sprintf('<td class="%s">', $pilot->isBillable(FlightBonus::zero())?'text-bold':'text-muted'). price($pilot->getTotalBill()->getValue()) . '€</td>';
+    print sprintf('<td class="%s">', $pilot->getFlightsCost()->getValue() === 0 ? 'text-muted' : 'text-bold') . price($pilot->getFlightsCost()->getValue()) . '€ </td>';
+    print sprintf('<td class="%s">', $pilot->isBillable(FlightBonus::zero()) ? 'text-bold' : 'text-muted') . price($pilot->getTotalBill()->getValue()) . '€</td>';
     print '</tr>';
 }
 
@@ -275,7 +275,7 @@ 
 print '<td>' . $totalT3 . '</td>';
 print '<td></td>';
 
-print '<td>' . $totalT4. '</td>';
+print '<td>' . $totalT4 . '</td>';
 print '<td></td>';
 
 print '<td>' . $totalT5 . '</td>';
@@ -304,7 +304,7 @@ 
 //table km
 $tauxRemb = isset($conf->global->BBC_FLIGHT_LOG_TAUX_REMB_KM) ? $conf->global->BBC_FLIGHT_LOG_TAUX_REMB_KM : 0;
 $year = GETPOST("year", 'int');
-if(empty($year)){
+if (empty($year)) {
     $year = date('Y');
 }
 

Infrastructure/Damage/Query/Repository/GetPilotDamagesQueryRepository.php

Spacing +5 added lines, -5 removed lines

@@ -35,16 +35,16 @@
     public function query($year)
     {
         $sql = 'SELECT damage.amount as amount, damage.billed as billed, damage.author_id as author, author.firstname as author_name';
-        $sql.=' FROM '.MAIN_DB_PREFIX.'bbc_flight_damages as damage';
-        $sql.=' INNER JOIN '.MAIN_DB_PREFIX.'bbc_vols as flight ON flight.rowid = damage.flight_id';
-        $sql.=' INNER JOIN '.MAIN_DB_PREFIX.'user as author ON author.rowid = damage.author_id';
-        $sql.=' WHERE YEAR(flight.date) = '.$this->db->escape($year);
+        $sql .= ' FROM ' . MAIN_DB_PREFIX . 'bbc_flight_damages as damage';
+        $sql .= ' INNER JOIN ' . MAIN_DB_PREFIX . 'bbc_vols as flight ON flight.rowid = damage.flight_id';
+        $sql .= ' INNER JOIN ' . MAIN_DB_PREFIX . 'user as author ON author.rowid = damage.author_id';
+        $sql .= ' WHERE YEAR(flight.date) = ' . $this->db->escape($year);
 
         $resql = $this->db->query($sql);
         if ($resql) {
             $num = $this->db->num_rows($resql);
             if ($num) {
-                for($i = 0; $i < $num ; $i++) {
+                for ($i = 0; $i < $num; $i++) {
                     $properties = $this->db->fetch_array($resql);
                     $damage = TotalDamage::fromArray($properties);
                     yield $damage;

Application/Damage/ViewModel/Damage.php

Spacing +2 added lines, -2 removed lines

@@ -46,11 +46,11 @@
      *
      * @return Damage
      */
-    public static function fromArray(array $properties){
+    public static function fromArray(array $properties) {
         $author = $properties['author_name'];
         $amount = $properties['amount'];
         $id = $properties['id'];
-        $invoiced = (bool)$properties['invoiced'];
+        $invoiced = (bool) $properties['invoiced'];
 
         return new self($author, $amount, $id, $invoiced);
     }