laudeco / bbc-dolibarr-flightlog

class/missions/PilotMissions.php

Spacing +7 added lines, -7 removed lines

@@ -46,7 +46,7 @@ 
         Assert::nullOrString($pilotLastname);
         Assert::nullOrString($pilotFirstname);
 
-        $this->pilotId = (int)$pilotId;
+        $this->pilotId = (int) $pilotId;
         $this->pilotFirstname = $pilotFirstname;
         $this->pilotLastname = $pilotLastname;
 
@@ -59,9 +59,9 @@ 
      * @param int $numberOfFlights
      * @param int $numberOfKilometers
      */
-    public function addQuarter($quarter, $numberOfFlights, $numberOfKilometers){
+    public function addQuarter($quarter, $numberOfFlights, $numberOfKilometers) {
         Assert::integerish($quarter);
-        $quarter = (int)$quarter;
+        $quarter = (int) $quarter;
 
         Assert::keyNotExists($this->quarterMissions, $quarter);
 
@@ -119,13 +119,13 @@ 
      *
      * @return QuarterMission
      */
-    private function getQuarterMission($quarter){
+    private function getQuarterMission($quarter) {
         Assert::integer($quarter);
         Assert::greaterThan($quarter, 0);
         Assert::lessThanEq($quarter, 4);
 
-        if(!isset($this->quarterMissions[$quarter])){
-            return new QuarterMission($quarter,0,0);
+        if (!isset($this->quarterMissions[$quarter])) {
+            return new QuarterMission($quarter, 0, 0);
         }
 
         return $this->quarterMissions[$quarter];
@@ -136,6 +136,6 @@ 
      */
     public function getPilotName()
     {
-        return $this->pilotFirstname.' '.$this->pilotLastname;
+        return $this->pilotFirstname . ' ' . $this->pilotLastname;
     }
 }
\ No newline at end of file

generateExpenseNote.php

Spacing +8 added lines, -8 removed lines

@@ -87,9 +87,9 @@ 
     try {
         $command = new CreateExpenseNoteCommand($year, $quarter, $userValidatorId, $privateNote, $publicNote);
         $commandHandler->__invoke($command);
-    } catch(PeriodNotFinishedException $e){
+    } catch (PeriodNotFinishedException $e) {
         dol_htmloutput_errors("Le quadri n'est pas encore fini !");
-    } catch(\Exception $e){
+    } catch (\Exception $e) {
         dol_syslog($e->getMessage(), LOG_ERR);
         dol_htmloutput_errors('Error : ' . $e->getMessage());
     }
@@ -105,15 +105,15 @@ 
 $form = new Form($db);
 
 $tabLinks = [];
-foreach($flightYears as $currentFlightYear){
+foreach ($flightYears as $currentFlightYear) {
     $tabLinks[] = [
-        DOL_URL_ROOT."/flightlog/generateExpenseNote.php?year=".$currentFlightYear,
+        DOL_URL_ROOT . "/flightlog/generateExpenseNote.php?year=" . $currentFlightYear,
         $currentFlightYear,
-        "tab_".$currentFlightYear
+        "tab_" . $currentFlightYear
     ];
 }
 
-dol_fiche_head($tabLinks, "tab_".$year);
+dol_fiche_head($tabLinks, "tab_" . $year);
 
 ?>
     <form method="POST">
@@ -134,7 +134,7 @@ 
         <select name="quarter" id="field_quarter">
             <option value="1" <?= ($year == $currentYear && $currentQuarter <= 1) ? 'disabled="disabled"' : "" ?>>1</option>
             <option value="2" <?= ($year == $currentYear && $currentQuarter <= 2) ? 'disabled="disabled"' : "" ?>>2</option>
-            <option value="3" <?= ($year == $currentYear && $currentQuarter <= 3) ? 'disabled="disabled"': "" ?>>3</option>
+            <option value="3" <?= ($year == $currentYear && $currentQuarter <= 3) ? 'disabled="disabled"' : "" ?>>3</option>
             <option value="4" <?= ($year == $currentYear && $currentQuarter <= 4) ? 'disabled="disabled"' : "" ?>>4</option>
         </select>
         <br/>
@@ -143,7 +143,7 @@ 
         <label><?= $langs->trans("Validateur de la note de frais")?></label><br/>
         <?php
             $include_users = $object->fetch_users_approver_expensereport();
-            print $form->select_dolusers($user->id,"fk_user_validator",1,"",0,$include_users);
+            print $form->select_dolusers($user->id, "fk_user_validator", 1, "", 0, $include_users);
         ?>
         <br/>
 

readFlights.php

Spacing +2 added lines, -2 removed lines

@@ -266,7 +266,7 @@ 
 print '<td>' . $totalT3 . '</td>';
 print '<td></td>';
 
-print '<td>' . $totalT4. '</td>';
+print '<td>' . $totalT4 . '</td>';
 print '<td></td>';
 
 print '<td>' . $totalT5 . '</td>';
@@ -292,7 +292,7 @@ 
 //table km
 $tauxRemb = isset($conf->global->BBC_FLIGHT_LOG_TAUX_REMB_KM) ? $conf->global->BBC_FLIGHT_LOG_TAUX_REMB_KM : 0;
 $year = GETPOST("year", 'int');
-if(empty($year)){
+if (empty($year)) {
     $year = date('Y');
 }
 

lib/flightLog.lib.php

Doc Comments +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
 }
 
 /**
- * @param null $year
+ * @param integer $year
  * @param null $pilotId
  * @param null $quarter
  * @param bool $groupBy

command/CreateFlightBillCommand.php

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
             throw new \InvalidArgumentException('Model document is missing');
         }
 
-        if(!isset($nbrPax) || !is_numeric($nbrPax) || $nbrPax != (int) $nbrPax){
+        if (!isset($nbrPax) || !is_numeric($nbrPax) || $nbrPax != (int) $nbrPax) {
             throw new \InvalidArgumentException('The number of pax is not correct, an integer is expected');
         }
 

command/CreateFlightBillCommandHandler.php

Spacing +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
     {
         $customer = new Client($this->db);
 
-        if($flight->fk_receiver) {
+        if ($flight->fk_receiver) {
             return $this->fetchCustomerFromFlight($flight);
         }
 

facture.php

Spacing +4 added lines, -4 removed lines

@@ -124,11 +124,11 @@
  * Put here all code to do according to value of "action" parameter
  */
 if ($action == EXPENSE_REPORT_GENERATOR_ACTION_GENERATE) {
-    try{
-        $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote,$bankAccount, $nbrPax);
+    try {
+        $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote, $bankAccount, $nbrPax);
         $handler->handle($command);
-    }catch (\Exception $e){
-        dol_syslog($e->getMessage(),LOG_ERR);
+    } catch (\Exception $e) {
+        dol_syslog($e->getMessage(), LOG_ERR);
         dol_htmloutput_mesg("Facture non créée", '', 'error');
     }
 }

Braces +6 added lines, -3 removed lines

@@ -127,7 +127,7 @@ 
     try{
         $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote,$bankAccount, $nbrPax);
         $handler->handle($command);
-    }catch (\Exception $e){
+    } catch (\Exception $e){
         dol_syslog($e->getMessage(),LOG_ERR);
         dol_htmloutput_mesg("Facture non créée", '', 'error');
     }
@@ -268,9 +268,12 @@ 
 
         <?php if (!$flightProduct || !$flight->hasReceiver()) : ?>
             <a class="butActionRefused" href="#">Générer</a>
-        <?php else: ?>
+        <?php else {
+    : ?>
             <button class="butAction" type="submit">Générer</button>
-        <?php endif; ?>
+        <?php endif;
+}
+?>
 
         <a class="butAction" href="<?php echo DOL_URL_ROOT . '/flightlog/card.php?id=' . $flight->id; ?>">Retour au
             vol</a>

class/bbctypes.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -645,7 +645,7 @@
     }
 
     /**
-     * @return array|BbctypesLine[]
+     * @return BbctypesLine[]
      */
     public function getLines()
     {

Spacing +1 added lines, -1 removed lines

@@ -733,7 +733,7 @@
      */
     public function getActive()
     {
-        return (boolean)$this->active;
+        return (boolean) $this->active;
     }
 
     /**

Form/Form.php

Doc Comments +2 added lines, -1 removed lines

@@ -95,6 +95,7 @@ 
 
     /**
      * @inheritDoc
+     * @param string $fieldName
      */
     public function remove($fieldName)
     {
@@ -142,7 +143,7 @@ 
     }
 
     /**
-     * @param null|\ValidatorInterface $validator
+     * @param ValidatorInterface $validator
      *
      * @return Form
      */