laudeco / bbc-dolibarr-flightlog

lib/flightLog.lib.php

Doc Comments +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
 }
 
 /**
- * @param null $year
+ * @param integer $year
  * @param null $pilotId
  * @param null $quarter
  * @param bool $groupBy

command/CreateFlightBillCommand.php

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
             throw new \InvalidArgumentException('Model document is missing');
         }
 
-        if(!isset($nbrPax) || !is_numeric($nbrPax) || $nbrPax != (int) $nbrPax){
+        if (!isset($nbrPax) || !is_numeric($nbrPax) || $nbrPax != (int) $nbrPax) {
             throw new \InvalidArgumentException('The number of pax is not correct, an integer is expected');
         }
 

command/CreateFlightBillCommandHandler.php

Spacing +1 added lines, -1 removed lines

@@ -112,7 +112,7 @@
     {
         $customer = new Client($this->db);
 
-        if($flight->fk_receiver) {
+        if ($flight->fk_receiver) {
             return $this->fetchCustomerFromFlight($flight);
         }
 

facture.php

Spacing +4 added lines, -4 removed lines

@@ -124,11 +124,11 @@
  * Put here all code to do according to value of "action" parameter
  */
 if ($action == EXPENSE_REPORT_GENERATOR_ACTION_GENERATE) {
-    try{
-        $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote,$bankAccount, $nbrPax);
+    try {
+        $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote, $bankAccount, $nbrPax);
         $handler->handle($command);
-    }catch (\Exception $e){
-        dol_syslog($e->getMessage(),LOG_ERR);
+    } catch (\Exception $e) {
+        dol_syslog($e->getMessage(), LOG_ERR);
         dol_htmloutput_mesg("Facture non créée", '', 'error');
     }
 }

Braces +6 added lines, -3 removed lines

@@ -127,7 +127,7 @@ 
     try{
         $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote,$bankAccount, $nbrPax);
         $handler->handle($command);
-    }catch (\Exception $e){
+    } catch (\Exception $e){
         dol_syslog($e->getMessage(),LOG_ERR);
         dol_htmloutput_mesg("Facture non créée", '', 'error');
     }
@@ -268,9 +268,12 @@ 
 
         <?php if (!$flightProduct || !$flight->hasReceiver()) : ?>
             <a class="butActionRefused" href="#">Générer</a>
-        <?php else: ?>
+        <?php else {
+    : ?>
             <button class="butAction" type="submit">Générer</button>
-        <?php endif; ?>
+        <?php endif;
+}
+?>
 
         <a class="butAction" href="<?php echo DOL_URL_ROOT . '/flightlog/card.php?id=' . $flight->id; ?>">Retour au
             vol</a>

class/bbctypes.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -645,7 +645,7 @@
     }
 
     /**
-     * @return array|BbctypesLine[]
+     * @return BbctypesLine[]
      */
     public function getLines()
     {

Spacing +1 added lines, -1 removed lines

@@ -733,7 +733,7 @@
      */
     public function getActive()
     {
-        return (boolean)$this->active;
+        return (boolean) $this->active;
     }
 
     /**

Form/Form.php

Doc Comments +2 added lines, -1 removed lines

@@ -95,6 +95,7 @@ 
 
     /**
      * @inheritDoc
+     * @param string $fieldName
      */
     public function remove($fieldName)
     {
@@ -142,7 +143,7 @@ 
     }
 
     /**
-     * @param null|\ValidatorInterface $validator
+     * @param ValidatorInterface $validator
      *
      * @return Form
      */

Form/InputDate.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      */
     public function setValue($value)
     {
-        if($value instanceof \DateTime){
+        if ($value instanceof \DateTime) {
             return parent::setValue($value->format('Y-m-d'));
         }
 

Form/FlightForm.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
      * @param array $options
      * @param \User $user
      */
-    public function __construct(\ValidatorInterface $validator, $baseObject, \DoliDB $db, $options,\User $user)
+    public function __construct(\ValidatorInterface $validator, $baseObject, \DoliDB $db, $options, \User $user)
     {
 
         parent::__construct('flight_form', FormInterface::METHOD_POST, $this->buildOptionsfromConfiguration($options));
@@ -83,7 +83,7 @@ 
         $flight = $object;
 
         // Quick fix - Fixme by a factory on this form.
-        if($this->user->rights->flightlog->vol->advanced){
+        if ($this->user->rights->flightlog->vol->advanced) {
             return parent::bind($object);
         }
 

card.php

Spacing +23 added lines, -23 removed lines

@@ -116,7 +116,7 @@ 
 $extralabels = $extrafields->fetch_name_optionals_label($object->table_element);
 
 // Load object
-include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php';  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
+include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php'; // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
 include DOL_DOCUMENT_ROOT . '/core/actions_dellink.inc.php';
 
 // Initialize technical object to manage hooks of modules. Note that conf->hooks_modules contains array array
@@ -145,7 +145,7 @@ 
 
 $parameters = array();
 $reshook = $hookmanager->executeHooks('doActions', $parameters, $object,
-    $action);    // Note that $action and $object may have been modified by some hooks
+    $action); // Note that $action and $object may have been modified by some hooks
 if ($reshook < 0) {
     setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
 }
@@ -251,7 +251,7 @@ 
 
 
 // Part to edit record
-if (($user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id )) && ($id || $ref) && $action == 'edit'): ?>
+if (($user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && ($id || $ref) && $action == 'edit'): ?>
 
     <?php $renderer = new \flightlog\form\SimpleFormRenderer(); ?>
 
@@ -268,7 +268,7 @@ 
 
         <?php echo $renderer->render($formFlight->getElement('idBBC_vols')); ?>
 
-        <?php if($formFlight->has('fk_type')): ?>
+        <?php if ($formFlight->has('fk_type')): ?>
         <section class="form-section">
             <h1 class="form-section-title"><?php echo $langs->trans('Type de vol'); ?></h1>
             <table class="border" width="50%">
@@ -282,7 +282,7 @@ 
         <?php endif; ?>
 
         <!-- Date et heures -->
-        <?php if($formFlight->has('date')): ?>
+        <?php if ($formFlight->has('date')): ?>
             <section class="form-section">
                 <h1 class="form-section-title"><?php echo $langs->trans('Date'); ?></h1>
                 <table class="border" width="50%">
@@ -294,7 +294,7 @@ 
             </section>
         <?php endif; ?>
 
-        <?php if($formFlight->has('heureD') && $formFlight->has('heureA')): ?>
+        <?php if ($formFlight->has('heureD') && $formFlight->has('heureA')): ?>
             <section class="form-section">
                 <h1 class="form-section-title"><?php echo $langs->trans('Heures'); ?></h1>
                 <table class="border" width="50%">
@@ -314,14 +314,14 @@ 
             <h1 class="form-section-title"><?php echo $langs->trans('Pilote & ballon') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('fk_pilot')): ?>
+                <?php if ($formFlight->has('fk_pilot')): ?>
                 <tr>
                     <td class="fieldrequired"> Pilote </td>
-                    <td><?php echo $renderer->render($formFlight->getElement('fk_pilot'),['ajax' => true]); ?></td>
+                    <td><?php echo $renderer->render($formFlight->getElement('fk_pilot'), ['ajax' => true]); ?></td>
                 </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('BBC_ballons_idBBC_ballons')): ?>
+                <?php if ($formFlight->has('BBC_ballons_idBBC_ballons')): ?>
                 <tr>
                     <td width="25%" class="fieldrequired">Ballon</td>
                     <td><?php echo $renderer->render($formFlight->getElement('BBC_ballons_idBBC_ballons')); ?></td>
@@ -356,7 +356,7 @@ 
             </table>
         </section>
 
-        <?php if($formFlight->has('fk_organisateur')): ?>
+        <?php if ($formFlight->has('fk_organisateur')): ?>
             <section class="form-section">
                 <h1 class="form-section-title"><span class="js-organisator-field">Organisateur</span></h1>
                 <table class="border" width="50%">
@@ -365,7 +365,7 @@ 
                         <td>
                             <?php
                             //organisateur
-                            print $renderer->render($formFlight->getElement('fk_organisateur'),['ajax' => true]);
+                            print $renderer->render($formFlight->getElement('fk_organisateur'), ['ajax' => true]);
                             ?>
                         </td>
                     </tr>
@@ -377,7 +377,7 @@ 
         <section class="form-section js-expensable-field">
             <h1 class="form-section-title"><?php echo $langs->trans('Déplacements') ?></h1>
             <table class="border" width="50%">
-                <?php if($formFlight->has('kilometers')): ?>
+                <?php if ($formFlight->has('kilometers')): ?>
                     <!-- number of kilometers done for the flight -->
                     <tr>
                         <td class="fieldrequired">Nombre de kilometres effectués pour le vol</td>
@@ -387,7 +387,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('justif_kilometers')): ?>
+                <?php if ($formFlight->has('justif_kilometers')): ?>
                     <!-- Justif Kilometers -->
                     <tr>
 
@@ -405,7 +405,7 @@ 
         <section class="form-section">
             <h1 class="form-section-title"><?php echo $langs->trans('Passager') ?></h1>
             <table class="border" width="50%">
-                <?php if($formFlight->has('nbrPax')): ?>
+                <?php if ($formFlight->has('nbrPax')): ?>
                     <tr>
                         <td class="fieldrequired"><?php echo $langs->trans('Nombre de passagers'); ?></td>
                         <td>
@@ -414,7 +414,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('passengerNames')): ?>
+                <?php if ($formFlight->has('passengerNames')): ?>
                     <!-- passenger names -->
                     <tr>
                         <td width="25%" class="fieldrequired"><?php echo $langs->trans('Noms des passagers'); ?><br/>(Séparé
@@ -424,7 +424,7 @@ 
                             <?php print $renderer->render($formFlight->getElement('passengerNames')); ?>
                         </td>
                     </tr>
-                <?php endif;?>
+                <?php endif; ?>
             </table>
         </section>
 
@@ -433,17 +433,17 @@ 
             <h1 class="form-section-title js-billable-field"><?php echo $langs->trans('Facturation') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('fk_receiver')): ?>
+                <?php if ($formFlight->has('fk_receiver')): ?>
                     <!-- Money receiver -->
                     <tr class="js-hide-order js-billable-field">
                         <td class="fieldrequired"><?php echo $langs->trans('Qui a perçu l\'argent') ?></td>
                         <td>
-                            <?php print $renderer->render($formFlight->getElement('fk_receiver'),['ajax' => true]); ?>
+                            <?php print $renderer->render($formFlight->getElement('fk_receiver'), ['ajax' => true]); ?>
                         </td>
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('cost')): ?>
+                <?php if ($formFlight->has('cost')): ?>
                     <!-- Flight cost -->
                     <tr class="js-hide-order js-billable-field">
                         <td class="fieldrequired">Montant perçu</td>
@@ -461,7 +461,7 @@ 
             <h1 class="form-section-title"><?php echo $langs->trans('Commentaires') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('remarque')): ?>
+                <?php if ($formFlight->has('remarque')): ?>
                     <!-- commentaires -->
                     <tr class="">
                         <td class="fieldrequired"> Commentaire</td>
@@ -471,7 +471,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('incidents')): ?>
+                <?php if ($formFlight->has('incidents')): ?>
                     <!-- incidents -->
                     <tr class="">
                         <td class="fieldrequired"> incidents</td>
@@ -505,7 +505,7 @@ 
         $formconfirm = $form->formconfirm($_SERVER["PHP_SELF"] . '?id=' . $object->id, $langs->trans('DeleteMyOjbect'),
             $langs->trans('êtes-vous sure de vouloir supprimer ce vol ?'), 'confirm_delete', '', 0, 1);
         print $formconfirm;
-    } elseif ($user->rights->flightlog->vol->financial  && $action == ACTION_FLAG_BILLED) {
+    } elseif ($user->rights->flightlog->vol->financial && $action == ACTION_FLAG_BILLED) {
         $formconfirm = $form->formconfirm($_SERVER["PHP_SELF"] . '?id=' . $object->id,
             $langs->trans('Marque comme facturé'),
             $langs->trans('Ce vol va être marqué comme facturé, est-ce bien le cas ?'), ACTION_CONFIRM_FLAG_BILLED, '',
@@ -537,7 +537,7 @@ 
     print '<div class="tabsAction">' . "\n";
     $parameters = array();
     $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object,
-        $action);    // Note that $action and $object may have been modified by hook
+        $action); // Note that $action and $object may have been modified by hook
     if ($reshook < 0) {
         setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
     }