laudeco / bbc-dolibarr-flightlog

validators/FlightValidator.php

Spacing +4 added lines, -4 removed lines

@@ -149,7 +149,7 @@ 
      */
     private function checkPassengersInformation($vol)
     {
-        if (!is_numeric($vol->nbrPax) || (int)$vol->nbrPax < 0) {
+        if (!is_numeric($vol->nbrPax) || (int) $vol->nbrPax < 0) {
             $this->addError('nbrPax', 'Erreur le nombre de passager est un nombre négatif.');
         }
 
@@ -241,10 +241,10 @@ 
                 $this->addError('order_id', 'Le nombre de passager par commande doit être >= 0.');
             }
 
-            $totalPassenegrs += (int)$nbrPassengers;
+            $totalPassenegrs += (int) $nbrPassengers;
         }
 
-        if ($totalPassenegrs !== (int)$vol->getNumberOfPassengers()) {
+        if ($totalPassenegrs !== (int) $vol->getNumberOfPassengers()) {
             $this->addError('nbrPax', 'Le nombre de passagers ne correspond pas au nombre entré sur les commandes');
         }
 
@@ -258,7 +258,7 @@ 
      */
     private function checkFlightDate(Bbcvols $flight)
     {
-        if($flight->getDate() > new DateTimeImmutable()){
+        if ($flight->getDate() > new DateTimeImmutable()) {
             $this->addError('date', 'La date est plus grande que la date d\'aujourd\'hui');
         }
 

facture.php

Spacing +4 added lines, -4 removed lines

@@ -123,11 +123,11 @@
  * Put here all code to do according to value of "action" parameter
  */
 if ($action == EXPENSE_REPORT_GENERATOR_ACTION_GENERATE) {
-    try{
-        $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote,$bankAccount, $nbrPax, $customerId);
+    try {
+        $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote, $bankAccount, $nbrPax, $customerId);
         $handler->handle($command);
-    }catch (\Exception $e){
-        dol_syslog($e->getMessage(),LOG_ERR);
+    } catch (\Exception $e) {
+        dol_syslog($e->getMessage(), LOG_ERR);
         dol_htmloutput_mesg("Facture non créée", '', 'error');
     }
 }

Braces +6 added lines, -3 removed lines

@@ -126,7 +126,7 @@ 
     try{
         $command = new CreateFlightBillCommand($flight->getId(), $modeReglement, $conditionReglement, $documentModel, $type, $publicNote, $privateNote,$bankAccount, $nbrPax, $customerId);
         $handler->handle($command);
-    }catch (\Exception $e){
+    } catch (\Exception $e){
         dol_syslog($e->getMessage(),LOG_ERR);
         dol_htmloutput_mesg("Facture non créée", '', 'error');
     }
@@ -311,9 +311,12 @@ 
 
         <?php if (!$flightProduct || !$flight->hasReceiver()) : ?>
             <a class="butActionRefused" href="#">Générer</a>
-        <?php else: ?>
+        <?php else {
+    : ?>
             <button class="butAction" type="submit">Générer</button>
-        <?php endif; ?>
+        <?php endif;
+}
+?>
 
         <a class="butAction" href="<?php echo DOL_URL_ROOT . '/flightlog/card.php?id=' . $flight->id; ?>">Retour au
             vol</a>

class/bbcvols.class.php

Spacing +15 added lines, -15 removed lines

@@ -259,7 +259,7 @@ 
         $sql .= ' ' . (!isset($this->justif_kilometers) ? 'NULL' : "'" . $this->db->escape($this->justif_kilometers) . "'") . ',';
         $sql .= ' ' . "'" . date('Y-m-d H:i:s') . "'" . ',';
         $sql .= ' ' . "'" . date('Y-m-d H:i:s') . "'" . ',';
-        $sql .= ' ' . "'" . $this->passengerNames . "'" ;
+        $sql .= ' ' . "'" . $this->passengerNames . "'";
         $sql .= ')';
 
         $this->db->begin();
@@ -273,7 +273,7 @@ 
 
         if (!$error) {
             $this->id = $this->db->last_insert_id(MAIN_DB_PREFIX . $this->table_element);
-            if(!$this->insertOrders()){
+            if (!$this->insertOrders()) {
                 $error++;
             }
 
@@ -299,9 +299,9 @@ 
     /**
      * Inserts the order linked to the flight
      */
-    private function insertOrders(){
+    private function insertOrders() {
 
-        if(empty($this->orderIds)){
+        if (empty($this->orderIds)) {
             return true;
         }
 
@@ -316,12 +316,12 @@ 
         
         $values = [];
 
-        foreach($this->orderIds as $orderId=>$nbrPassengers){
+        foreach ($this->orderIds as $orderId=>$nbrPassengers) {
             $values[] = sprintf(
                 $valueTemplate,
                 $orderId,
                 $this->db->escape($this->id),
-                (!isset($nbrPassengers) ? '0' :  $this->db->escape($nbrPassengers))
+                (!isset($nbrPassengers) ? '0' : $this->db->escape($nbrPassengers))
             );
         }
 
@@ -339,9 +339,9 @@ 
     /**
      * Inserts the order linked to the flight
      */
-    private function updateOrders(){
+    private function updateOrders() {
 
-        if(empty($this->orderIds)){
+        if (empty($this->orderIds)) {
             return true;
         }
 
@@ -352,9 +352,9 @@ 
     /**
      * Inserts the order linked to the flight
      */
-    private function deleteOrders(){
+    private function deleteOrders() {
 
-        if(empty($this->orderIds)){
+        if (empty($this->orderIds)) {
             return true;
         }
 
@@ -559,7 +559,7 @@ 
         $sql .= ' fk_receiver = ' . (isset($this->fk_receiver) && (int) $this->fk_receiver > 0 ? $this->fk_receiver : "null") . ',';
         $sql .= ' justif_kilometers = ' . (isset($this->justif_kilometers) ? "'" . $this->db->escape($this->justif_kilometers) . "'," : "'',");
         $sql .= ' date_update = ' . "'" . date('Y-m-d H:i:s') . "',";
-        $sql .= ' passenger_names = ' . "'" . trim($this->passengerNames)."'";
+        $sql .= ' passenger_names = ' . "'" . trim($this->passengerNames) . "'";
 
         $sql .= ' WHERE idBBC_vols=' . $this->idBBC_vols;
 
@@ -1022,8 +1022,8 @@ 
      * @param int $orderId
      * @param int $nbrPassengers
      */
-    public function addOrderId($orderId, $nbrPassengers){
-        if(!isset($this->orderIds)){
+    public function addOrderId($orderId, $nbrPassengers) {
+        if (!isset($this->orderIds)) {
             $this->orderIds = [];
         }
 
@@ -1063,7 +1063,7 @@ 
         if ($resql) {
             $numrows = $this->db->num_rows($resql);
             if ($numrows) {
-                for($i = 0 ; $i < $numrows ; $i++){
+                for ($i = 0; $i < $numrows; $i++) {
                     $obj = $this->db->fetch_object($resql);
                     $this->orderIds[$obj->order_id] = $obj->nbr_passengers;
 
@@ -1084,7 +1084,7 @@ 
      */
     public function getOrders()
     {
-        if(!isset($this->orders) || empty($this->orders)){
+        if (!isset($this->orders) || empty($this->orders)) {
             $this->fetchOrder();
         }
         return $this->orders;

class/missions/QuarterPilotMissionCollection.php

Spacing +2 added lines, -2 removed lines

@@ -41,7 +41,7 @@ 
         $numberOfKilometers
     )
     {
-        $pilotId = (int)$pilotId;
+        $pilotId = (int) $pilotId;
 
         if (!isset($this->items[$pilotId])) {
             $this->items[$pilotId] = new PilotMissions($pilotId, $pilotFirstname, $pilotLastname);
@@ -57,7 +57,7 @@ 
      */
     public function addPilot($pilotId, $pilotFirstname, $pilotLastname)
     {
-        $pilotId = (int)$pilotId;
+        $pilotId = (int) $pilotId;
 
         if (isset($this->items[$pilotId])) {
             return;

class/missions/PilotMissions.php

Spacing +7 added lines, -7 removed lines

@@ -38,7 +38,7 @@ 
      */
     public function __construct($pilotId, $pilotFirstname, $pilotLastname)
     {
-        $this->pilotId = (int)$pilotId;
+        $this->pilotId = (int) $pilotId;
         $this->pilotFirstname = $pilotFirstname;
         $this->pilotLastname = $pilotLastname;
 
@@ -51,8 +51,8 @@ 
      * @param int $numberOfFlights
      * @param int $numberOfKilometers
      */
-    public function addQuarter($quarter, $numberOfFlights, $numberOfKilometers){
-        $quarter = (int)$quarter;
+    public function addQuarter($quarter, $numberOfFlights, $numberOfKilometers) {
+        $quarter = (int) $quarter;
         $this->quarterMissions[$quarter] = new QuarterMission($quarter, $numberOfFlights, $numberOfKilometers);
     }
 
@@ -107,9 +107,9 @@ 
      *
      * @return QuarterMission
      */
-    private function getQuarterMission($quarter){
-        if(!isset($this->quarterMissions[$quarter])){
-            return new QuarterMission($quarter,0,0);
+    private function getQuarterMission($quarter) {
+        if (!isset($this->quarterMissions[$quarter])) {
+            return new QuarterMission($quarter, 0, 0);
         }
 
         return $this->quarterMissions[$quarter];
@@ -120,6 +120,6 @@ 
      */
     public function getPilotName()
     {
-        return $this->pilotFirstname.' '.$this->pilotLastname;
+        return $this->pilotFirstname . ' ' . $this->pilotLastname;
     }
 }
\ No newline at end of file

class/missions/FlightMission.php

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
      */
     public function __construct($id, $startPoint, $endPoint, $kilometersComment, $numberOfKilometers, DateTime $date)
     {
-        $this->id = (int)$id;
+        $this->id = (int) $id;
         $this->startPoint = $startPoint;
         $this->endPoint = $endPoint;
         $this->kilometersComment = $kilometersComment;

class/api_Flights.class.php

Spacing +16 added lines, -16 removed lines

@@ -26,7 +26,7 @@ 
      *
      * @throws RestException
      */
-    public function index(){
+    public function index() {
         $obj_ret = array();
 
         $sql = "SELECT ";
@@ -52,9 +52,9 @@ 
         $sql .= 'date_update,';
         $sql .= 'passenger_names';
 
-        $sql.= " FROM ".MAIN_DB_PREFIX."bbc_vols";
+        $sql .= " FROM " . MAIN_DB_PREFIX . "bbc_vols";
 
-        $sql.= ' WHERE 1=1 LIMIT 10';
+        $sql .= ' WHERE 1=1 LIMIT 10';
 
         // Add sql filters
 
@@ -64,29 +64,29 @@ 
         {
             $num = $this->connection->num_rows($result);
             $min = min($num, (-1 <= 0 ? $num : -1));
-            $i=0;
+            $i = 0;
             while ($i < $min)
             {
                 $obj = $this->connection->fetch_object($result);
 
                 $flight = new Flight();
-                $flight->rowid = (int)$obj->rowid;
+                $flight->rowid = (int) $obj->rowid;
                 $flight->date = $obj->date;
                 $flight->lieuD = $obj->lieuD;
                 $flight->lieuA = $obj->lieuA;
                 $flight->heureD = $obj->heureD;
                 $flight->heureA = $obj->heureA;
-                $flight->balloon = (int)$obj->BBC_ballons_idBBC_ballons;
-                $flight->nbrPax = (int)$obj->nbrPax;
+                $flight->balloon = (int) $obj->BBC_ballons_idBBC_ballons;
+                $flight->nbrPax = (int) $obj->nbrPax;
                 $flight->remarque = $obj->remarque;
                 $flight->incidents = $obj->incidents;
-                $flight->type = (int)$obj->fk_type;
-                $flight->pilot = (int)$obj->fk_pilot;
-                $flight->organisator = (int)$obj->fk_organisateur;
-                $flight->billed = (bool)$obj->is_facture;
-                $flight->cost = (int)$obj->cost;
-                $flight->receiver = (int)$obj->fk_receiver;
-                $flight->kilometers = (int)$obj->kilometers ;
+                $flight->type = (int) $obj->fk_type;
+                $flight->pilot = (int) $obj->fk_pilot;
+                $flight->organisator = (int) $obj->fk_organisateur;
+                $flight->billed = (bool) $obj->is_facture;
+                $flight->cost = (int) $obj->cost;
+                $flight->receiver = (int) $obj->fk_receiver;
+                $flight->kilometers = (int) $obj->kilometers;
                 $flight->justifKilometers = $obj->justif_kilometers;
                 $flight->createdAt = $obj->date_creation;
                 $flight->updatedAt = $obj->date_update;
@@ -97,10 +97,10 @@ 
             }
         }
         else {
-            throw new RestException(500, 'Error when retrieve commande list : '.$this->connection->lasterror());
+            throw new RestException(500, 'Error when retrieve commande list : ' . $this->connection->lasterror());
         }
 
-        if( ! count($obj_ret)) {
+        if (!count($obj_ret)) {
             throw new RestException(404, 'No flight found');
         }
 

Braces +1 added lines, -2 removed lines

@@ -95,8 +95,7 @@
 
                 $i++;
             }
-        }
-        else {
+        } else {
             throw new RestException(500, 'Error when retrieve commande list : '.$this->connection->lasterror());
         }