FlightDamage - Code Metrics - Inspection of "damage to flight link" - laudeco/bbc-dolibarr-flightlog - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/fixing_cost ( f58af6...414fbf )

by Laurent

created 2020-02-08 14:19 UTC

FlightDamage A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	125
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	125
rs	10
c	0
b	0
f	0
wmc	10
lcom	1
cbo	0

10 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	load()	3	1
A	damage()	3	1
A	waiting()	3	1
A	isBilled()	4	1
A	getFlightId()	3	1
A	amount()	3	1
A	getAuthor()	4	1
A	invoice()	3	1
A	getId()	4	1

<?php


namespace FlightLog\Domain\Damage;

final class FlightDamage
{
    /**
     * @var DamageId|null
     */
    private $id;

    /**
     * @var FlightId
     */
    private $flight;

    /**
     * @var DamageAmount
     */
    private $amount;

    /**
     * @var bool
     */
    private $billed;

    /**
     * @var AuthorId
     */
    private $author;

    /**
     * @param FlightId $flightId
     * @param DamageAmount $amount
     * @param $billed
     * @param AuthorId $authorId
     * @param DamageId|null $id
     */
    private function __construct(DamageAmount $amount, $billed, AuthorId $authorId, FlightId $flightId = null, DamageId $id = null)
    {
       $this->flight = $flightId;
       $this->amount = $amount;
       $this->billed = $billed;
       $this->author = $authorId;
       $this->id = $id;
    }

    /**
     * @param FlightId $flightId
     * @param DamageAmount $amount
     * @param $billed
     * @param AuthorId $authorId
     * @param DamageId|null $id
     *
     * @return FlightDamage
     */
    public static function load(FlightId $flightId, DamageAmount $amount, $billed, AuthorId $authorId, DamageId $id = null){
        return new self($amount, $billed, $authorId, $flightId, $id);
    }

    /**
     * @param FlightId $flightId
     * @param DamageAmount $amount
     * @param AuthorId $authorId
     *
     * @return FlightDamage
     */
    public static function damage(FlightId $flightId, DamageAmount $amount, AuthorId $authorId){
        return new self($amount, false, $authorId, $flightId);
    }

    /**
     * @param DamageAmount $amount
     * @param AuthorId $authorId
     *
     * @return FlightDamage
     */
    public static function waiting(DamageAmount $amount, AuthorId $authorId){
        return new self($amount, false, $authorId);
    }

    /**
     * @return bool
     */
    public function isBilled()
    {
        return $this->billed;
    }

    /**
     * @return FlightId
     */
    public function getFlightId(){
        return $this->flight;
    }

    /**
     * @return DamageAmount
     */
    public function amount(){
        return $this->amount;
    }

    /**
     * @return AuthorId
     */
    public function getAuthor()
    {
        return $this->author;
    }

    /**
     * Invoice the damage.
     *
     * @return FlightDamage
     */
    public function invoice(){
        return new self($this->flight, $this->amount, true, $this->author, $this->id);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @return DamageId|null
     */
    public function getId()
    {
        return $this->id;
    }

}

1			<?php
2
3
4			namespace FlightLog\Domain\Damage;
5
6			final class FlightDamage
7			{
8			/**
9			* @var DamageId\|null
10			*/
11			private $id;
12
13			/**
14			* @var FlightId
15			*/
16			private $flight;
17
18			/**
19			* @var DamageAmount
20			*/
21			private $amount;
22
23			/**
24			* @var bool
25			*/
26			private $billed;
27
28			/**
29			* @var AuthorId
30			*/
31			private $author;
32
33			/**
34			* @param FlightId $flightId
35			* @param DamageAmount $amount
36			* @param $billed
37			* @param AuthorId $authorId
38			* @param DamageId\|null $id
39			*/
40			private function __construct(DamageAmount $amount, $billed, AuthorId $authorId, FlightId $flightId = null, DamageId $id = null)
41			{
42			$this->flight = $flightId;
43			$this->amount = $amount;
44			$this->billed = $billed;
45			$this->author = $authorId;
46			$this->id = $id;
47			}
48
49			/**
50			* @param FlightId $flightId
51			* @param DamageAmount $amount
52			* @param $billed
53			* @param AuthorId $authorId
54			* @param DamageId\|null $id
55			*
56			* @return FlightDamage
57			*/
58			public static function load(FlightId $flightId, DamageAmount $amount, $billed, AuthorId $authorId, DamageId $id = null){
59			return new self($amount, $billed, $authorId, $flightId, $id);
60			}
61
62			/**
63			* @param FlightId $flightId
64			* @param DamageAmount $amount
65			* @param AuthorId $authorId
66			*
67			* @return FlightDamage
68			*/
69			public static function damage(FlightId $flightId, DamageAmount $amount, AuthorId $authorId){
70			return new self($amount, false, $authorId, $flightId);
71			}
72
73			/**
74			* @param DamageAmount $amount
75			* @param AuthorId $authorId
76			*
77			* @return FlightDamage
78			*/
79			public static function waiting(DamageAmount $amount, AuthorId $authorId){
80			return new self($amount, false, $authorId);
81			}
82
83			/**
84			* @return bool
85			*/
86			public function isBilled()
87			{
88			return $this->billed;
89			}
90
91			/**
92			* @return FlightId
93			*/
94			public function getFlightId(){
95			return $this->flight;
96			}
97
98			/**
99			* @return DamageAmount
100			*/
101			public function amount(){
102			return $this->amount;
103			}
104
105			/**
106			* @return AuthorId
107			*/
108			public function getAuthor()
109			{
110			return $this->author;
111			}
112
113			/**
114			* Invoice the damage.
115			*
116			* @return FlightDamage
117			*/
118			public function invoice(){
119			return new self($this->flight, $this->amount, true, $this->author, $this->id);
			0 ignored issues – show Documentation introduced 2020-02-08 14:21 UTC by Report Bug Copy Issue Report `$this->flight` is of type `object<FlightLog\Domain\Damage\FlightId>`, but the function expects a `object<FlightLog\Domain\Damage\DamageAmount>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2020-02-08 14:21 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `object<FlightLog\Domain\Damage\AuthorId>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2020-02-08 14:21 UTC by Report Bug Copy Issue Report `$this->author` is of type `object<FlightLog\Domain\Damage\AuthorId>`, but the function expects a `null\|object<FlightLog\Domain\Damage\FlightId>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
120			}
121
122			/**
123			* @return DamageId\|null
124			*/
125			public function getId()
126			{
127			return $this->id;
128			}
129
130			}

laudeco / bbc-dolibarr-flightlog

Push — feature/fixing_cost ( f58af6...414fbf )

FlightDamage A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

10 Methods

Duplication Side-by-Side

Filter issues like