laudeco / bbc-dolibarr-flightlog

Infrastructure/Flight/Query/Repository/TakeOffQueryRepository.php

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
             WHERE 
               fk_type IN (1,2)
               AND YEAR(NOW())-1 <= YEAR(llx_bbc_vols.date)
-              AND llx_bbc_vols.fk_pilot = '.$pilot.'
+              AND llx_bbc_vols.fk_pilot = '.$pilot . '
             
             GROUP BY
               llx_bbc_vols.lieuD
@@ -57,7 +57,7 @@ 
 
         $places = [];
 
-        for($i = 0; $i < $num ; $i++) {
+        for ($i = 0; $i < $num; $i++) {
             $properties = $this->db->fetch_array($resql);
             $stat = new TakeOffPlace($properties['place']);
             $places[] = $stat;

Infrastructure/Flight/Query/Repository/BalloonQueryRepository.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 
 
 use FlightLog\Application\Flight\ViewModel\Balloon;
-use FlightLog\Application\Flight\ViewModel\TakeOffPlace;
 
 final class BalloonQueryRepository
 {

Spacing +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
         $this->db = $db;
     }
 
-    public function query($params = []){
+    public function query($params = []) {
         $sql = '
             SELECT 
               balloon.rowid as id,
@@ -33,7 +33,7 @@ 
             
             WHERE 
               balloon.is_disable = false
-              AND llx_bbc_vols.fk_pilot = '.$params['pilot'].'
+              AND llx_bbc_vols.fk_pilot = '.$params['pilot'] . '
               
             GROUP BY balloon.rowid
             ORDER  BY counter DESC
@@ -50,7 +50,7 @@ 
             return new Balloon(0);
         }
 
-        for($i = 0; $i < $num ; $i++) {
+        for ($i = 0; $i < $num; $i++) {
             $properties = $this->db->fetch_array($resql);
             return Balloon::fromArray($properties);
         }

command/CreatePilotYearBillCommandHandler.php

Spacing +11 added lines, -11 removed lines

@@ -147,22 +147,22 @@ 
 
         $remainingPoints = $command->getPilot()->getFlightBonus()->addPoints(FlightPoints::create($command->getAdditionalBonus()));
 
-        foreach ($amountPerRate as $rate => $cost){
-            if($cost->getValue() <= 0){
+        foreach ($amountPerRate as $rate => $cost) {
+            if ($cost->getValue() <= 0) {
                 continue;
             }
 
-            if($cost->getValue() <= $remainingPoints->getValue()){
+            if ($cost->getValue() <= $remainingPoints->getValue()) {
                 $remainingPoints = $remainingPoints->minCosts($cost);
                 continue;
             }
 
             $subject = 'vols';
-            if((int)$rate === 21){
+            if ((int) $rate === 21) {
                 $subject = 'réparations';
             }
 
-            $this->addOrderLine($object, 'Cloture d\'année concernant les ' . $subject, $cost->minBonus($remainingPoints)->getValue(), (int)$rate, 1, $startYearTimestamp, $endYearTimestamp );
+            $this->addOrderLine($object, 'Cloture d\'année concernant les ' . $subject, $cost->minBonus($remainingPoints)->getValue(), (int) $rate, 1, $startYearTimestamp, $endYearTimestamp);
             $remainingPoints = FlightBonus::zero();
 
         }
@@ -208,7 +208,7 @@ 
      */
     private function addOrderLine($object, $title, $priceTtc, $rate, $qty, $startDate, $endDate)
     {
-        if($qty <= 0){
+        if ($qty <= 0) {
             return;
         }
 
@@ -264,35 +264,35 @@ 
 
         //T3
         $rate = $this->t3->getService()->tva_tx;
-        if(!isset($costs[$rate])){
+        if (!isset($costs[$rate])) {
             $costs[$rate] = FlightCost::zero();
         }
         $costs[$rate] = $costs[$rate]->addCost($pilot->getCountForType('3')->getCost());
 
         //T4
         $rate = $this->t4->getService()->tva_tx;
-        if(!isset($costs[$rate])){
+        if (!isset($costs[$rate])) {
             $costs[$rate] = FlightCost::zero();
         }
         $costs[$rate] = $costs[$rate]->addCost($pilot->getCountForType('4')->getCost());
 
         //T6
         $rate = $this->t6->getService()->tva_tx;
-        if(!isset($costs[$rate])){
+        if (!isset($costs[$rate])) {
             $costs[$rate] = FlightCost::zero();
         }
         $costs[$rate] = $costs[$rate]->addCost($pilot->getCountForType('6')->getCost());
 
         //T7
         $rate = $this->t7->getService()->tva_tx;
-        if(!isset($costs[$rate])){
+        if (!isset($costs[$rate])) {
             $costs[$rate] = FlightCost::zero();
         }
         $costs[$rate] = $costs[$rate]->addCost($pilot->getCountForType('7')->getCost());
 
         //Damages
         $rate = 21;
-        if(!isset($costs[$rate])){
+        if (!isset($costs[$rate])) {
             $costs[$rate] = FlightCost::zero();
         }
         $costs[$rate] = $costs[$rate]->addCost($pilot->damageCost()->minCost($pilot->invoicedDamageCost()->multiply(-1)));

class/flight/FlightBonus.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
     public function minCosts(FlightCost $cost)
     {
         $bonusAmount = $this->bonusAmount - $cost->getValue();
-        if($bonusAmount < 0){
+        if ($bonusAmount < 0) {
             return FlightBonus::zero();
         }
 

class/bbcvols.class.php

Spacing +25 added lines, -25 removed lines

@@ -124,7 +124,7 @@ 
      */
     public function getIdBBCVols()
     {
-        return (int)$this->idBBC_vols;
+        return (int) $this->idBBC_vols;
     }
 
     /**
@@ -132,7 +132,7 @@ 
      */
     public function getId()
     {
-        return (int)$this->getIdBBCVols();
+        return (int) $this->getIdBBCVols();
     }
 
     /**
@@ -269,13 +269,13 @@ 
         $sql .= ' ' . (!isset($this->nbrPax) ? 'NULL' : "'" . $this->db->escape($this->nbrPax) . "'") . ',';
         $sql .= ' ' . (!isset($this->remarque) ? 'NULL' : "'" . $this->db->escape($this->remarque) . "'") . ',';
         $sql .= ' ' . (!isset($this->incidents) ? 'NULL' : "'" . $this->db->escape($this->incidents) . "'") . ',';
-        $sql .= ' ' . (!isset($this->fk_type) || (int)$this->fk_type === -1 ? 'NULL' : $this->fk_type) . ',';
-        $sql .= ' ' . (!isset($this->fk_pilot) || (int)$this->fk_pilot === -1 ? 'NULL' : $this->fk_pilot) . ',';
-        $sql .= ' ' . (!isset($this->fk_organisateur) || (int)$this->fk_organisateur === -1 ? 'NULL' : $this->fk_organisateur) . ',';
+        $sql .= ' ' . (!isset($this->fk_type) || (int) $this->fk_type === -1 ? 'NULL' : $this->fk_type) . ',';
+        $sql .= ' ' . (!isset($this->fk_pilot) || (int) $this->fk_pilot === -1 ? 'NULL' : $this->fk_pilot) . ',';
+        $sql .= ' ' . (!isset($this->fk_organisateur) || (int) $this->fk_organisateur === -1 ? 'NULL' : $this->fk_organisateur) . ',';
         $sql .= ' ' . (!isset($this->is_facture) ? '0' : $this->is_facture) . ',';
         $sql .= ' ' . (!isset($this->kilometers) || empty($this->kilometers) ? '0' : $this->kilometers) . ',';
         $sql .= ' ' . (!isset($this->cost) ? 'NULL' : "'" . $this->db->escape($this->cost) . "'") . ',';
-        $sql .= ' ' . (!isset($this->fk_receiver) || (int)$this->fk_receiver === -1 ? 'NULL' : $this->fk_receiver) . ',';
+        $sql .= ' ' . (!isset($this->fk_receiver) || (int) $this->fk_receiver === -1 ? 'NULL' : $this->fk_receiver) . ',';
         $sql .= ' ' . (!isset($this->justif_kilometers) ? 'NULL' : "'" . $this->db->escape($this->justif_kilometers) . "'") . ',';
         $sql .= ' ' . "'" . date('Y-m-d H:i:s') . "'" . ',';
         $sql .= ' ' . "'" . date('Y-m-d H:i:s') . "'" . ',';
@@ -450,23 +450,23 @@ 
 
                 $this->id = $obj->idBBC_vols;
 
-                $this->idBBC_vols = (int)$obj->idBBC_vols;
+                $this->idBBC_vols = (int) $obj->idBBC_vols;
                 $this->date = $this->db->jdate($obj->date);
                 $this->lieuD = $obj->lieuD;
                 $this->lieuA = $obj->lieuA;
                 $this->heureD = $obj->heureD;
                 $this->heureA = $obj->heureA;
-                $this->BBC_ballons_idBBC_ballons = (int)$obj->BBC_ballons_idBBC_ballons;
+                $this->BBC_ballons_idBBC_ballons = (int) $obj->BBC_ballons_idBBC_ballons;
                 $this->nbrPax = $obj->nbrPax;
                 $this->remarque = $obj->remarque;
                 $this->incidents = $obj->incidents;
-                $this->fk_type = (int)$obj->fk_type;
-                $this->fk_pilot = (int)$obj->fk_pilot;
-                $this->fk_organisateur = (int)$obj->fk_organisateur;
-                $this->statut = $this->is_facture = (int)$obj->is_facture;
+                $this->fk_type = (int) $obj->fk_type;
+                $this->fk_pilot = (int) $obj->fk_pilot;
+                $this->fk_organisateur = (int) $obj->fk_organisateur;
+                $this->statut = $this->is_facture = (int) $obj->is_facture;
                 $this->kilometers = $obj->kilometers;
                 $this->total_ttc = $this->cost = $obj->cost;
-                $this->fk_receiver = (int)$obj->fk_receiver;
+                $this->fk_receiver = (int) $obj->fk_receiver;
                 $this->justif_kilometers = $obj->justif_kilometers;
                 $this->date_creation = $obj->date_creation;
                 $this->date_update = $obj->date_update;
@@ -582,13 +582,13 @@ 
         $sql .= ' nbrPax = ' . (isset($this->nbrPax) ? "'" . $this->db->escape($this->nbrPax) . "'" : "null") . ',';
         $sql .= ' remarque = ' . (isset($this->remarque) ? "'" . $this->db->escape($this->remarque) . "'" : "null") . ',';
         $sql .= ' incidents = ' . (isset($this->incidents) ? "'" . $this->db->escape($this->incidents) . "'" : "null") . ',';
-        $sql .= ' fk_type = ' . (isset($this->fk_type) && (int)$this->fk_type > 0 ? $this->fk_type : "null") . ',';
-        $sql .= ' fk_pilot = ' . (isset($this->fk_pilot) && (int)$this->fk_pilot > 0 ? $this->fk_pilot : "null") . ',';
-        $sql .= ' fk_organisateur = ' . (isset($this->fk_organisateur) && (int)$this->fk_organisateur > 0 ? $this->fk_organisateur : "null") . ',';
+        $sql .= ' fk_type = ' . (isset($this->fk_type) && (int) $this->fk_type > 0 ? $this->fk_type : "null") . ',';
+        $sql .= ' fk_pilot = ' . (isset($this->fk_pilot) && (int) $this->fk_pilot > 0 ? $this->fk_pilot : "null") . ',';
+        $sql .= ' fk_organisateur = ' . (isset($this->fk_organisateur) && (int) $this->fk_organisateur > 0 ? $this->fk_organisateur : "null") . ',';
         $sql .= ' is_facture = ' . (isset($this->is_facture) ? $this->is_facture : "0") . ',';
         $sql .= ' kilometers = ' . (!empty($this->kilometers) ? $this->kilometers : "0") . ',';
         $sql .= ' cost = ' . (isset($this->cost) ? "'" . $this->db->escape($this->cost) . "'" : "''") . ',';
-        $sql .= ' fk_receiver = ' . (isset($this->fk_receiver) && (int)$this->fk_receiver > 0 ? $this->fk_receiver : "null") . ',';
+        $sql .= ' fk_receiver = ' . (isset($this->fk_receiver) && (int) $this->fk_receiver > 0 ? $this->fk_receiver : "null") . ',';
         $sql .= ' justif_kilometers = ' . (isset($this->justif_kilometers) ? "'" . $this->db->escape($this->justif_kilometers) . "'," : "'',");
         $sql .= ' date_update = ' . "'" . date('Y-m-d H:i:s') . "',";
         $sql .= ' is_night = ' . ($this->nightFlight ? 1 : 0) . ',';
@@ -886,7 +886,7 @@ 
      */
     public function getPilotId()
     {
-        return (int)$this->fk_pilot;
+        return (int) $this->fk_pilot;
     }
 
     /**
@@ -894,7 +894,7 @@ 
      */
     public function getOrganisatorId()
     {
-        return (int)$this->fk_organisateur;
+        return (int) $this->fk_organisateur;
     }
 
     /**
@@ -931,7 +931,7 @@ 
      */
     public function hasPax()
     {
-        return (int)$this->nbrPax > 0;
+        return (int) $this->nbrPax > 0;
     }
 
     /**
@@ -1000,7 +1000,7 @@ 
      */
     public function getKilometers()
     {
-        return (int)$this->kilometers;
+        return (int) $this->kilometers;
     }
 
     /**
@@ -1043,7 +1043,7 @@ 
      */
     public function getNumberOfPassengers()
     {
-        return (int)$this->nbrPax;
+        return (int) $this->nbrPax;
     }
 
     /**
@@ -1246,7 +1246,7 @@ 
      */
     public function getBBCBallonsIdBBCBallons()
     {
-        return (int)$this->BBC_ballons_idBBC_ballons;
+        return (int) $this->BBC_ballons_idBBC_ballons;
     }
 
     /**
@@ -1322,7 +1322,7 @@ 
      */
     public function getFkType()
     {
-        return (int)$this->fk_type;
+        return (int) $this->fk_type;
     }
 
     /**
@@ -1417,7 +1417,7 @@ 
      */
     public function getFkReceiver()
     {
-        return (int)$this->fk_receiver;
+        return (int) $this->fk_receiver;
     }
 
     /**

card.php

Spacing +43 added lines, -43 removed lines

@@ -137,7 +137,7 @@ 
 $extralabels = $extrafields->fetch_name_optionals_label($object->table_element);
 
 // Load object
-include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php';  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
+include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php'; // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
 include DOL_DOCUMENT_ROOT . '/core/actions_dellink.inc.php';
 
 // Initialize technical object to manage hooks of modules. Note that conf->hooks_modules contains array array
@@ -166,7 +166,7 @@ 
 
 $parameters = array();
 $reshook = $hookmanager->executeHooks('doActions', $parameters, $object,
-    $action);    // Note that $action and $object may have been modified by some hooks
+    $action); // Note that $action and $object may have been modified by some hooks
 if ($reshook < 0) {
     setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
 }
@@ -243,7 +243,7 @@ 
     }
 
     // toggle is static flight
-    if(($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && $action == ACTION_CONFIRM_TOGGLE_STATIC){
+    if (($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && $action == ACTION_CONFIRM_TOGGLE_STATIC) {
         $result = $object
             ->toggleStaticFlight()
             ->update($user);
@@ -260,7 +260,7 @@ 
         }
     }
     // toggle is night flight
-    if(($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && $action == ACTION_CONFIRM_TOGGLE_NIGHT){
+    if (($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && $action == ACTION_CONFIRM_TOGGLE_NIGHT) {
         $result = $object
             ->toggleNightFlight()
             ->update($user);
@@ -277,7 +277,7 @@ 
         }
     }
     // toggle is exams
-    if(($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && $action == ACTION_CONFIRM_TOGGLE_EXAM){
+    if (($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && $action == ACTION_CONFIRM_TOGGLE_EXAM) {
         $result = $object
             ->toggleExamFlight()
             ->update($user);
@@ -294,7 +294,7 @@ 
         }
     }
     // toggle is refresh
-    if(($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && $action == ACTION_CONFIRM_TOGGLE_REFRESH){
+    if (($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && $action == ACTION_CONFIRM_TOGGLE_REFRESH) {
         $result = $object
             ->toggleRefreshFlight()
             ->update($user);
@@ -313,12 +313,12 @@ 
 
     // Action to classify in a project
     if (!empty($conf->projet->enabled) && $user->rights->projet->creer && $action === ACTION_CLASSIN) {
-        try{
+        try {
             $handler = new \flightlog\command\ClassifyFlightHandler($db, $conf, $langs, $user);
             $handler->handle(new \flightlog\command\ClassifyFlight($id, GETPOST('projectid')));
             $object->fetch($id);
             $action = 'show';
-        }catch(Exception $e){
+        } catch (Exception $e) {
             setEventMessages($e->getMessage(), null, 'errors');
         }
     }
@@ -351,7 +351,7 @@ 
 
 
 // Part to edit record
-if (($user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id )) && ($id || $ref) && $action == 'edit'): ?>
+if (($user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)) && ($id || $ref) && $action == 'edit'): ?>
 
     <?php $renderer = new \flightlog\form\SimpleFormRenderer(); ?>
 
@@ -365,11 +365,11 @@ 
 
     <form class="flight-form js-form" name='add' action="card.php?rowid=<?php echo $object->getId(); ?>" method="POST">
         <input type="hidden" name="action" value="update"/>
-        <input type="hidden" name="token" value="<?php echo newToken();?>"/>
+        <input type="hidden" name="token" value="<?php echo newToken(); ?>"/>
 
         <?php echo $renderer->render($formFlight->getElement('idBBC_vols')); ?>
 
-        <?php if($formFlight->has('fk_type')): ?>
+        <?php if ($formFlight->has('fk_type')): ?>
         <section class="form-section">
             <h1 class="form-section-title"><?php echo $langs->trans('Type de vol'); ?></h1>
             <table class="border" width="50%">
@@ -383,7 +383,7 @@ 
         <?php endif; ?>
 
         <!-- Date et heures -->
-        <?php if($formFlight->has('date')): ?>
+        <?php if ($formFlight->has('date')): ?>
             <section class="form-section">
                 <h1 class="form-section-title"><?php echo $langs->trans('Date'); ?></h1>
                 <table class="border" width="50%">
@@ -395,7 +395,7 @@ 
             </section>
         <?php endif; ?>
 
-        <?php if($formFlight->has('heureD') && $formFlight->has('heureA')): ?>
+        <?php if ($formFlight->has('heureD') && $formFlight->has('heureA')): ?>
             <section class="form-section">
                 <h1 class="form-section-title"><?php echo $langs->trans('Heures'); ?></h1>
                 <table class="border" width="50%">
@@ -415,14 +415,14 @@ 
             <h1 class="form-section-title"><?php echo $langs->trans('Pilote & ballon') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('fk_pilot')): ?>
+                <?php if ($formFlight->has('fk_pilot')): ?>
                 <tr>
                     <td class="fieldrequired"> Pilote </td>
-                    <td><?php echo $renderer->render($formFlight->getElement('fk_pilot'),['ajax' => true]); ?></td>
+                    <td><?php echo $renderer->render($formFlight->getElement('fk_pilot'), ['ajax' => true]); ?></td>
                 </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('BBC_ballons_idBBC_ballons')): ?>
+                <?php if ($formFlight->has('BBC_ballons_idBBC_ballons')): ?>
                 <tr>
                     <td width="25%" class="fieldrequired">Ballon</td>
                     <td><?php echo $renderer->render($formFlight->getElement('BBC_ballons_idBBC_ballons')); ?></td>
@@ -457,7 +457,7 @@ 
             </table>
         </section>
 
-        <?php if($formFlight->has('fk_organisateur')): ?>
+        <?php if ($formFlight->has('fk_organisateur')): ?>
             <section class="form-section">
                 <h1 class="form-section-title"><span class="js-organisator-field">Organisateur</span></h1>
                 <table class="border" width="50%">
@@ -466,7 +466,7 @@ 
                         <td>
                             <?php
                             //organisateur
-                            print $renderer->render($formFlight->getElement('fk_organisateur'),['ajax' => true]);
+                            print $renderer->render($formFlight->getElement('fk_organisateur'), ['ajax' => true]);
                             ?>
                         </td>
                     </tr>
@@ -478,7 +478,7 @@ 
         <section class="form-section js-expensable-field">
             <h1 class="form-section-title"><?php echo $langs->trans('Déplacements') ?></h1>
             <table class="border" width="50%">
-                <?php if($formFlight->has('kilometers')): ?>
+                <?php if ($formFlight->has('kilometers')): ?>
                     <!-- number of kilometers done for the flight -->
                     <tr>
                         <td class="fieldrequired">Nombre de kilometres effectués pour le vol</td>
@@ -488,7 +488,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('justif_kilometers')): ?>
+                <?php if ($formFlight->has('justif_kilometers')): ?>
                     <!-- Justif Kilometers -->
                     <tr>
 
@@ -506,7 +506,7 @@ 
         <section class="form-section">
             <h1 class="form-section-title"><?php echo $langs->trans('Passager') ?></h1>
             <table class="border" width="50%">
-                <?php if($formFlight->has('nbrPax')): ?>
+                <?php if ($formFlight->has('nbrPax')): ?>
                     <tr>
                         <td class="fieldrequired"><?php echo $langs->trans('Nombre de passagers'); ?></td>
                         <td>
@@ -515,7 +515,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('passengerNames')): ?>
+                <?php if ($formFlight->has('passengerNames')): ?>
                     <!-- passenger names -->
                     <tr>
                         <td width="25%" class="fieldrequired"><?php echo $langs->trans('Noms des passagers'); ?><br/>(Séparé
@@ -525,7 +525,7 @@ 
                             <?php print $renderer->render($formFlight->getElement('passengerNames')); ?>
                         </td>
                     </tr>
-                <?php endif;?>
+                <?php endif; ?>
             </table>
         </section>
 
@@ -534,17 +534,17 @@ 
             <h1 class="form-section-title js-billable-field"><?php echo $langs->trans('Facturation') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('fk_receiver')): ?>
+                <?php if ($formFlight->has('fk_receiver')): ?>
                     <!-- Money receiver -->
                     <tr class="js-hide-order js-billable-field">
                         <td class="fieldrequired"><?php echo $langs->trans('Qui a perçu l\'argent') ?></td>
                         <td>
-                            <?php print $renderer->render($formFlight->getElement('fk_receiver'),['ajax' => true]); ?>
+                            <?php print $renderer->render($formFlight->getElement('fk_receiver'), ['ajax' => true]); ?>
                         </td>
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('cost')): ?>
+                <?php if ($formFlight->has('cost')): ?>
                     <!-- Flight cost -->
                     <tr class="js-hide-order js-billable-field">
                         <td class="fieldrequired">Montant perçu</td>
@@ -565,7 +565,7 @@ 
             <h1 class="form-section-title"><?php echo $langs->trans('Commentaires') ?></h1>
             <table class="border" width="50%">
 
-                <?php if($formFlight->has('remarque')): ?>
+                <?php if ($formFlight->has('remarque')): ?>
                     <!-- commentaires -->
                     <tr class="">
                         <td class="fieldrequired"> Commentaire</td>
@@ -575,7 +575,7 @@ 
                     </tr>
                 <?php endif; ?>
 
-                <?php if($formFlight->has('incidents')): ?>
+                <?php if ($formFlight->has('incidents')): ?>
                     <!-- incidents -->
                     <tr class="">
                         <td class="fieldrequired"> incidents</td>
@@ -609,7 +609,7 @@ 
         $formconfirm = $form->formconfirm($_SERVER["PHP_SELF"] . '?id=' . $object->id, $langs->trans('DeleteMyOjbect'),
             $langs->trans('êtes-vous sure de vouloir supprimer ce vol ?'), 'confirm_delete', '', 0, 1);
         print $formconfirm;
-    } elseif ($user->rights->flightlog->vol->financial  && $action == ACTION_FLAG_BILLED) {
+    } elseif ($user->rights->flightlog->vol->financial && $action == ACTION_FLAG_BILLED) {
         $formconfirm = $form->formconfirm($_SERVER["PHP_SELF"] . '?id=' . $object->id,
             $langs->trans('Marque comme facturé'),
             $langs->trans('Ce vol va être marqué comme facturé, est-ce bien le cas ?'), ACTION_CONFIRM_FLAG_BILLED, '',
@@ -657,29 +657,29 @@ 
     print '<tr><td class="fieldrequired">' . $langs->trans("Fieldfk_pilot") . '</td><td>' . $pilot->getNomUrl(1) . '</td></tr>';
     print '<tr><td class="fieldrequired">' . $langs->trans("Fieldfk_organisateur") . '</td><td>' . $organisator->getNomUrl(1) . '</td></tr>';
 
-    if (! empty($conf->projet->enabled))
+    if (!empty($conf->projet->enabled))
     {
         print '<tr><td class="fieldrequired">' . $langs->trans("Project") . '</td><td>';
         $morehtmlref = '';
         if ($user->rights->projet->creer)
         {
             if ($action !== ACTION_CLASSIFY) {
-                $morehtmlref .= '<a href="' . $_SERVER['PHP_SELF'] . '?action='.ACTION_CLASSIFY.'&amp;id=' . $object->id . '">' . img_edit($langs->transnoentitiesnoconv('SetProject')) . '</a> ';
+                $morehtmlref .= '<a href="' . $_SERVER['PHP_SELF'] . '?action=' . ACTION_CLASSIFY . '&amp;id=' . $object->id . '">' . img_edit($langs->transnoentitiesnoconv('SetProject')) . '</a> ';
             }
             if ($action === ACTION_CLASSIFY) {
-                $morehtmlref.='<form method="post" action="'.$_SERVER['PHP_SELF'].'?id='.$object->id.'">';
-                $morehtmlref.='<input type="hidden" name="action" value="'.ACTION_CLASSIN.'">';
-                $morehtmlref.='<input type="hidden" name="token" value="'.$_SESSION['newtoken'].'">';
-                $morehtmlref.=$formproject->select_projects((empty($conf->global->PROJECT_CAN_ALWAYS_LINK_TO_ALL_SUPPLIERS)?$object->socid:-1), $object->fk_project, 'projectid', 80, 0, 1, 0, 1, 0, 0, '', 1);
-                $morehtmlref.='<input type="submit" class="button valignmiddle" value="'.$langs->trans("Modify").'">';
-                $morehtmlref.='</form>';
+                $morehtmlref .= '<form method="post" action="' . $_SERVER['PHP_SELF'] . '?id=' . $object->id . '">';
+                $morehtmlref .= '<input type="hidden" name="action" value="' . ACTION_CLASSIN . '">';
+                $morehtmlref .= '<input type="hidden" name="token" value="' . $_SESSION['newtoken'] . '">';
+                $morehtmlref .= $formproject->select_projects((empty($conf->global->PROJECT_CAN_ALWAYS_LINK_TO_ALL_SUPPLIERS) ? $object->socid : -1), $object->fk_project, 'projectid', 80, 0, 1, 0, 1, 0, 0, '', 1);
+                $morehtmlref .= '<input type="submit" class="button valignmiddle" value="' . $langs->trans("Modify") . '">';
+                $morehtmlref .= '</form>';
             }
         }
 
         if ($object->hasProject()) {
             $proj = new Project($db);
             $proj->fetch($object->fk_project);
-            $morehtmlref.=$proj->getNomUrl(1);
+            $morehtmlref .= $proj->getNomUrl(1);
         }
         print $morehtmlref . '</td>';
     }
@@ -694,7 +694,7 @@ 
     print '<div class="tabsAction">' . "\n";
     $parameters = array();
     $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object,
-        $action);    // Note that $action and $object may have been modified by hook
+        $action); // Note that $action and $object may have been modified by hook
     if ($reshook < 0) {
         setEventMessages($hookmanager->error, $hookmanager->errors, 'errors');
     }
@@ -723,10 +723,10 @@ 
     <?php endif; ?>
 
     <!-- Toggle static flight -->
-    <?php if($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)): ?>
+    <?php if ($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)): ?>
         <div class="inline-block divButAction">
             <a class="butAction" href="<?php echo sprintf('%s?id=%s&action=%s', $_SERVER["PHP_SELF"], $object->id, ACTION_TOGGLE_STATIC); ?>">
-                <?php if(!$object->isStaticFlight()): ?>
+                <?php if (!$object->isStaticFlight()): ?>
                     <?php echo $langs->trans("Vol static") ?>
                 <?php else: ?>
                     <?php echo $langs->trans("Non static") ?>
@@ -736,10 +736,10 @@ 
     <?php endif; ?>
 
     <!-- Toggle night flight -->
-    <?php if($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)): ?>
+    <?php if ($user->rights->flightlog->vol->advanced || $user->rights->flightlog->pilot->edit || $user->rights->flightlog->vol->edit || ($user->rights->flightlog->vol->add && $object->fk_pilot == $user->id)): ?>
         <div class="inline-block divButAction">
             <a class="butAction" href="<?php echo sprintf('%s?id=%s&action=%s', $_SERVER["PHP_SELF"], $object->id, ACTION_TOGGLE_NIGHT); ?>">
-                <?php if(!$object->isNightFlight()): ?>
+                <?php if (!$object->isNightFlight()): ?>
                     <?php echo $langs->trans("Vol de nuit") ?>
                 <?php else: ?>
                     <?php echo $langs->trans("Non nuit") ?>

Braces +11 added lines, -5 removed lines

@@ -318,7 +318,7 @@ 
             $handler->handle(new \flightlog\command\ClassifyFlight($id, GETPOST('projectid')));
             $object->fetch($id);
             $action = 'show';
-        }catch(Exception $e){
+        } catch(Exception $e){
             setEventMessages($e->getMessage(), null, 'errors');
         }
     }
@@ -728,9 +728,12 @@ 
             <a class="butAction" href="<?php echo sprintf('%s?id=%s&action=%s', $_SERVER["PHP_SELF"], $object->id, ACTION_TOGGLE_STATIC); ?>">
                 <?php if(!$object->isStaticFlight()): ?>
                     <?php echo $langs->trans("Vol static") ?>
-                <?php else: ?>
+                <?php else {
+    : ?>
                     <?php echo $langs->trans("Non static") ?>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             </a>
         </div>
     <?php endif; ?>
@@ -741,9 +744,12 @@ 
             <a class="butAction" href="<?php echo sprintf('%s?id=%s&action=%s', $_SERVER["PHP_SELF"], $object->id, ACTION_TOGGLE_NIGHT); ?>">
                 <?php if(!$object->isNightFlight()): ?>
                     <?php echo $langs->trans("Vol de nuit") ?>
-                <?php else: ?>
+                <?php else {
+    : ?>
                     <?php echo $langs->trans("Non nuit") ?>
-                <?php endif; ?>
+                <?php endif;
+}
+?>
             </a>
         </div>
     <?php endif; ?>

Http/Web/Controller/PilotEditController.php

Unused Use Statements -3 removed lines

@@ -4,12 +4,9 @@
 namespace FlightLog\Http\Web\Controller;
 
 
-use FlightLog\Application\Damage\Command\CreateDamageCommand;
-use FlightLog\Application\Damage\Command\CreateDamageCommandHandler;
 use FlightLog\Application\Pilot\Command\CreateUpdatePilotInformationCommand;
 use FlightLog\Application\Pilot\Command\CreateUpdatePilotInformationCommandHandler;
 use FlightLog\Domain\Pilot\ValueObject\PilotId;
-use FlightLog\Http\Web\Form\DamageCreationForm;
 use FlightLog\Http\Web\Form\PilotForm;
 use FlightLog\Infrastructure\Pilot\Repository\PilotRepository;
 

Spacing +9 added lines, -9 removed lines

@@ -16,17 +16,17 @@ 
 final class PilotEditController extends WebController
 {
 
-    public function index(){
+    public function index() {
         $id = $this->request->getParam('id');
 
-        if($id === null){
+        if ($id === null) {
             $this->renderHtml('<p>Paramètre ID non fournis.</p>');
             return;
         }
 
         $command = new CreateUpdatePilotInformationCommand($id);
 
-        if($this->getPilotRepository()->exist(PilotId::create($id))){
+        if ($this->getPilotRepository()->exist(PilotId::create($id))) {
             $command->fromPilot($this->getPilotRepository()->getById(PilotId::create($id)));
         }
 
@@ -36,19 +36,19 @@ 
         $user = new \User($this->db);
         $user->fetch($id);
 
-        if($this->request->isPost()){
+        if ($this->request->isPost()) {
             $form->setData($this->request->getPostParameters());
 
-            if(!$form->validate()){
+            if (!$form->validate()) {
                 return $this->render('pilot/edit.phtml', [
                     'form' => $form,
                 ]);
             }
 
-            try{
+            try {
                 $this->handle($form->getObject());
-                return $this->redirect($_SERVER["PHP_SELF"].'?id='.$id.'&r=list_members');
-            }catch(\Exception $e){
+                return $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $id . '&r=list_members');
+            } catch (\Exception $e) {
                 print $e->getMessage();
                 dol_syslog($e->getMessage(), LOG_ERR);
             }
@@ -76,7 +76,7 @@ 
     /**
      * @return CreateUpdatePilotInformationCommandHandler()
      */
-    private function getHandler(){
+    private function getHandler() {
         return new CreateUpdatePilotInformationCommandHandler($this->getPilotRepository());
     }
 

Braces +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
             try{
                 $this->handle($form->getObject());
                 return $this->redirect($_SERVER["PHP_SELF"].'?id='.$id.'&r=list_members');
-            }catch(\Exception $e){
+            } catch(\Exception $e){
                 print $e->getMessage();
                 dol_syslog($e->getMessage(), LOG_ERR);
             }

Http/Web/Form/PilotForm.php

Doc Comments +1 added lines, -1 removed lines

@@ -75,7 +75,7 @@
     }
 
     /**
-     * @return CreateUpdatePilotInformationCommand|\stdClass|null
+     * @return CreateUpdatePilotInformationCommand
      */
     public function getObject()
     {

Unused Use Statements -3 removed lines

@@ -4,7 +4,6 @@ 
 namespace FlightLog\Http\Web\Form;
 
 
-use FlightLog\Application\Damage\Command\CreateDamageCommand;
 use FlightLog\Application\Pilot\Command\CreateUpdatePilotInformationCommand;
 use flightlog\form\Csrf;
 use flightlog\form\Form;
@@ -13,8 +12,6 @@ 
 use flightlog\form\Input;
 use flightlog\form\InputCheckBox;
 use flightlog\form\InputDate;
-use flightlog\form\Number;
-use flightlog\form\UserSelect;
 
 final class PilotForm extends Form
 {

Http/Web/Controller/PilotListController.php

Spacing +1 added lines, -1 removed lines

@@ -14,7 +14,7 @@
 final class PilotListController extends WebController
 {
 
-    public function index(){
+    public function index() {
 
         $members = $this->getPilotRepository()->query();