laudeco / bbc-dolibarr-flightlog

Http/Web/Controller/DamageController.php

Braces +1 added lines, -1 removed lines

@@ -31,7 +31,7 @@
                 'form' => new Form($this->db),
                 'flight' => $flight
             ]);
-        }catch (\Exception $e){
+        } catch (\Exception $e){
             echo $e->getMessage();
         }
     }

Spacing +6 added lines, -6 removed lines

@@ -13,14 +13,14 @@ 
     /**
      * @return GetDamageQueryRepository
      */
-    private function getDamageRepository(){
+    private function getDamageRepository() {
         return new GetDamageQueryRepository($this->db);
     }
 
-    public function view(){
+    public function view() {
         $damageId = $this->request->getParam('id');
 
-        try{
+        try {
             $damage = $this->getDamageRepository()->query($damageId);
 
             $flight = new \Bbcvols($this->db);
@@ -31,16 +31,16 @@ 
                 'form' => new Form($this->db),
                 'flight' => $flight
             ]);
-        }catch (\Exception $e){
+        } catch (\Exception $e) {
             echo $e->getMessage();
         }
     }
 
-    public function invoice(){
+    public function invoice() {
         $damageId = $this->request->getParam('id');
 
 
 
-        return $this->redirect($_SERVER["PHP_SELF"].'?id='.$damageId);
+        return $this->redirect($_SERVER["PHP_SELF"] . '?id=' . $damageId);
     }
 }
\ No newline at end of file

Infrastructure/Damage/Query/Repository/GetDamageQueryRepository.php

Braces +13 added lines, -26 removed lines

@@ -37,29 +37,21 @@ 
 
         if ($objectType == 'facture') {
             $classpath = 'compta/facture/class';
-        }
-        elseif ($objectType == 'facturerec') {
+        } elseif ($objectType == 'facturerec') {
             $classpath = 'compta/facture/class';
-        }
-        elseif ($objectType == 'propal') {
+        } elseif ($objectType == 'propal') {
             $classpath = 'comm/propal/class';
-        }
-        elseif ($objectType == 'supplier_proposal') {
+        } elseif ($objectType == 'supplier_proposal') {
             $classpath = 'supplier_proposal/class';
-        }
-        elseif ($objectType == 'shipping') {
+        } elseif ($objectType == 'shipping') {
             $classpath = 'expedition/class'; $subelement = 'expedition';
-        }
-        elseif ($objectType == 'delivery') {
+        } elseif ($objectType == 'delivery') {
             $classpath = 'livraison/class'; $subelement = 'livraison';
-        }
-        elseif ($objectType == 'invoice_supplier' || $objectType == 'order_supplier') {
+        } elseif ($objectType == 'invoice_supplier' || $objectType == 'order_supplier') {
             $classpath = 'fourn/class';
-        }
-        elseif ($objectType == 'fichinter') {
+        } elseif ($objectType == 'fichinter') {
             $classpath = 'fichinter/class'; $subelement = 'fichinter';
-        }
-        elseif ($objectType == 'subscription') {
+        } elseif ($objectType == 'subscription') {
             $classpath = 'adherents/class';
         }
 
@@ -68,20 +60,15 @@ 
 
         if ($objectType == 'order') {
             $classfile = 'commande'; $classname = 'Commande';
-        }
-        elseif ($objectType == 'invoice_supplier') {
+        } elseif ($objectType == 'invoice_supplier') {
             $classfile = 'fournisseur.facture'; $classname = 'FactureFournisseur';
-        }
-        elseif ($objectType == 'order_supplier') {
+        } elseif ($objectType == 'order_supplier') {
             $classfile = 'fournisseur.commande'; $classname = 'CommandeFournisseur';
-        }
-        elseif ($objectType == 'supplier_proposal') {
+        } elseif ($objectType == 'supplier_proposal') {
             $classfile = 'supplier_proposal'; $classname = 'SupplierProposal';
-        }
-        elseif ($objectType == 'facturerec') {
+        } elseif ($objectType == 'facturerec') {
             $classfile = 'facture-rec'; $classname = 'FactureRec';
-        }
-        elseif ($objectType == 'subscription') {
+        } elseif ($objectType == 'subscription') {
             $classfile = 'subscription'; $classname = 'Subscription';
         }
 

Spacing +12 added lines, -12 removed lines

@@ -22,7 +22,7 @@ 
         $this->db = $db;
     }
 
-    private function element($objectType, $rowid){
+    private function element($objectType, $rowid) {
         $element = null;
         $subelement = null;
 
@@ -33,7 +33,7 @@ 
             $subelement = $regs[2];
         }
 
-        $classpath = $element.'/class';
+        $classpath = $element . '/class';
 
         if ($objectType == 'facture') {
             $classpath = 'compta/facture/class';
@@ -85,7 +85,7 @@ 
             $classfile = 'subscription'; $classname = 'Subscription';
         }
 
-        dol_include_once('/'.$classpath.'/'.$classfile.'.class.php');
+        dol_include_once('/' . $classpath . '/' . $classfile . '.class.php');
         if (!class_exists($classname))
         {
             return null;
@@ -104,14 +104,14 @@ 
      *
      * @throws \Exception
      */
-    public function query($damageId){
+    public function query($damageId) {
 
         $sql = 'SELECT damage.author_id as  author_id, damage.rowid as id, damage.amount, CONCAT(author.firstname, " " , author.lastname) as author_name, damage.billed as invoiced, damage.flight_id as flight_id';
-        $sql.= ', element.rowid as element_id ,element.fk_target as element_fk_target, element.targettype as element_target_type';
-        $sql.=' FROM '.MAIN_DB_PREFIX.'bbc_flight_damages as damage';
-        $sql.=' INNER JOIN '.MAIN_DB_PREFIX.'user as author ON author.rowid = damage.author_id';
-        $sql.=' LEFT JOIN '.MAIN_DB_PREFIX.'element_element as element ON (element.fk_source = damage.rowid AND element.sourcetype = "flightlog_damage")';
-        $sql.=' WHERE damage.rowid = '.$damageId;
+        $sql .= ', element.rowid as element_id ,element.fk_target as element_fk_target, element.targettype as element_target_type';
+        $sql .= ' FROM ' . MAIN_DB_PREFIX . 'bbc_flight_damages as damage';
+        $sql .= ' INNER JOIN ' . MAIN_DB_PREFIX . 'user as author ON author.rowid = damage.author_id';
+        $sql .= ' LEFT JOIN ' . MAIN_DB_PREFIX . 'element_element as element ON (element.fk_source = damage.rowid AND element.sourcetype = "flightlog_damage")';
+        $sql .= ' WHERE damage.rowid = ' . $damageId;
 
         $resql = $this->db->query($sql);
         if (!$resql) {
@@ -125,13 +125,13 @@ 
 
         /** @var Damage $damage */
         $damage = null;
-        for($i = 0; $i < $num ; $i++) {
+        for ($i = 0; $i < $num; $i++) {
             $properties = $this->db->fetch_array($resql);
-            if(!$damage){
+            if (!$damage) {
                 $damage = Damage::fromArray($properties);
             }
 
-            if(!isset($properties['element_id'])){
+            if (!isset($properties['element_id'])) {
                 continue;
             }
 

Infrastructure/Common/Routes/guards.conf.php

Unused Use Statements -3 removed lines

@@ -1,9 +1,6 @@
 <?php
 
-use FlightLog\Http\Web\Controller\DamageController;
-use FlightLog\Http\Web\Controller\FlightController;
 use FlightLog\Infrastructure\Common\Routes\Guard;
-use FlightLog\Infrastructure\Common\Routes\Route;
 
 global $db;
 

Spacing +1 added lines, -1 removed lines

@@ -8,7 +8,7 @@
 global $db;
 
 return [
-    new Guard('get_one_damage', function(User $user){
+    new Guard('get_one_damage', function(User $user) {
         return $user->rights->flightlog->vol->financial;
     }),
 ];

Http/Web/Controller/WebController.php

Spacing +4 added lines, -4 removed lines

@@ -32,19 +32,19 @@
      *
      * @return Response
      */
-    protected function render($template, array $variables = []){
+    protected function render($template, array $variables = []) {
 
-        foreach($variables as $variableName => $variableValue){
+        foreach ($variables as $variableName => $variableValue) {
             $GLOBALS[$variableName] = $variableValue;
         }
 
-        return new Response(__DIR__.'/../templates/'.$template);
+        return new Response(__DIR__ . '/../templates/' . $template);
     }
 
     /**
      * @param string $html
      */
-    protected function renderHtml($html){
+    protected function renderHtml($html) {
         print $html;
     }
 

Http/Web/Controller/FlightController.php

Spacing +2 added lines, -2 removed lines

@@ -6,9 +6,9 @@
 
 final class FlightController extends WebController
 {
-    public function view(){
+    public function view() {
         $id = $this->request->getParam('id');
-        return $this->redirect(DOL_URL_ROOT.'/flightlog/card.php?id='.$id);
+        return $this->redirect(DOL_URL_ROOT . '/flightlog/card.php?id=' . $id);
     }
 
 }
\ No newline at end of file

Http/Web/Response/Redirect.php

Spacing +1 added lines, -1 removed lines

@@ -25,7 +25,7 @@
      *
      * @return Redirect
      */
-    public static function create($url){
+    public static function create($url) {
         return new self($url);
     }
 

card_tab_damage.php

Spacing +9 added lines, -9 removed lines

@@ -49,7 +49,7 @@ 
 
 $id = GETPOST('id', 'int') ?: GETPOST('idBBC_vols', 'int');
 $action = GETPOST('action', 'alpha');
-$permissiondellink=$user->rights->flightlog->vol->financial;
+$permissiondellink = $user->rights->flightlog->vol->financial;
 
 $object = new Bbcvols($db);
 
@@ -57,8 +57,8 @@ 
 $extralabels = $extrafields->fetch_name_optionals_label($object->table_element);
 
 // Load object
-include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php';  // Must be include, not include_once  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
-include DOL_DOCUMENT_ROOT.'/core/actions_dellink.inc.php';
+include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php'; // Must be include, not include_once  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
+include DOL_DOCUMENT_ROOT . '/core/actions_dellink.inc.php';
 
 // Initialize technical object to manage hooks of modules. Note that conf->hooks_modules contains array array
 $hookmanager->initHooks(array('bbcvols'));
@@ -85,13 +85,13 @@ 
         FLIGHTLOG_ACTION_HANDLE_ADD_DAMAGE => [AddFlightDamageController::class, 'view'],
     ];
 
-    if(isset($routes[$action])){
+    if (isset($routes[$action])) {
         $controllerName = $routes[$action][0];
         $actionName = $routes[$action][1];
 
         $response = call_user_func([new $controllerName($db), $actionName]);
 
-        if($response instanceof \FlightLog\Http\Web\Response\Redirect){
+        if ($response instanceof \FlightLog\Http\Web\Response\Redirect) {
             if (headers_sent()) {
                 echo(sprintf("<script>location.href='%s'</script>", $response->getUrl()));
                 exit;
@@ -102,7 +102,7 @@ 
         }
 
         include $response->getTemplate();
-    }else{
+    } else {
         echo 'Route non trouvée.';
     }
 ?>
@@ -114,13 +114,13 @@ 
 // Buttons
 print '<div class="tabsAction">' . "\n";
 
-if($user->rights->flightlog->vol->financial){
-    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/card_tab_damage.php?id=' . $object->id.'&action='.FLIGHTLOG_ACTION_ADD_DAMAGE.'">' . $langs->trans("Ajouter") . '</a></div>' . "\n";
+if ($user->rights->flightlog->vol->financial) {
+    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/card_tab_damage.php?id=' . $object->id . '&action=' . FLIGHTLOG_ACTION_ADD_DAMAGE . '">' . $langs->trans("Ajouter") . '</a></div>' . "\n";
 }
 
 print '</div>' . "\n";
 
-if($user->rights->flightlog->vol->financial){
+if ($user->rights->flightlog->vol->financial) {
     print '<div class="fichecenter"><div class="fichehalfleft">';
     $form->showLinkedObjectBlock($object);
     print '</div></div>';

Braces +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
         }
 
         include $response->getTemplate();
-    }else{
+    } else{
         echo 'Route non trouvée.';
     }
 ?>

index.php

Spacing +3 added lines, -3 removed lines

@@ -53,7 +53,7 @@ 
 $routesGuards = require './Infrastructure/Common/Routes/guards.conf.php';
 
 $response = null;
-try{
+try {
     $routeName = GETPOST('r');
 
     $routeManager = new \FlightLog\Infrastructure\Common\Routes\RouteManager($db);
@@ -62,7 +62,7 @@ 
 
     $response = $routeManager->__invoke($routeName, $user);
 
-    if($response instanceof \FlightLog\Http\Web\Response\Redirect){
+    if ($response instanceof \FlightLog\Http\Web\Response\Redirect) {
         if (headers_sent()) {
             echo(sprintf("<script>location.href='%s'</script>", $response->getUrl()));
             exit;
@@ -72,7 +72,7 @@ 
         exit;
     }
 
-}catch (\Exception $e){
+} catch (\Exception $e) {
     dol_syslog($e->getMessage(), LOG_ERR);
     $response = new \FlightLog\Http\Web\Response\Response($e->getMessage());
 }

Braces +1 added lines, -1 removed lines

@@ -72,7 +72,7 @@
         exit;
     }
 
-}catch (\Exception $e){
+} catch (\Exception $e){
     dol_syslog($e->getMessage(), LOG_ERR);
     $response = new \FlightLog\Http\Web\Response\Response($e->getMessage());
 }

Infrastructure/Common/Routes/RouteManager.php

Spacing +9 added lines, -9 removed lines

@@ -38,8 +38,8 @@ 
      *
      * @throws \Exception
      */
-    public function add(Route $route){
-        if(isset($this->routes[$route->getName()])){
+    public function add(Route $route) {
+        if (isset($this->routes[$route->getName()])) {
             throw new \Exception('Route exists');
         }
 
@@ -51,8 +51,8 @@ 
      *
      * @throws \Exception
      */
-    public function load(array $routes){
-        foreach($routes as $currentRoute){
+    public function load(array $routes) {
+        foreach ($routes as $currentRoute) {
             $this->add($currentRoute);
         }
     }
@@ -62,7 +62,7 @@ 
      */
     public function loadGuards($routesGuards)
     {
-        foreach($routesGuards as $guard){
+        foreach ($routesGuards as $guard) {
             $this->guards[$guard->getRouteName()] = $guard;
         }
     }
@@ -73,8 +73,8 @@ 
      * @param $routeName
      * @return bool
      */
-    public function isAuthorized(User $user, $routeName){
-        if(!isset($this->guards[$routeName])){
+    public function isAuthorized(User $user, $routeName) {
+        if (!isset($this->guards[$routeName])) {
             return true;
         }
 
@@ -92,11 +92,11 @@ 
      */
     public function __invoke($name, User $user)
     {
-        if(!isset($this->routes[$name])){
+        if (!isset($this->routes[$name])) {
             throw new \Exception('Route not found');
         }
 
-        if(!$this->isAuthorized($user, $name)){
+        if (!$this->isAuthorized($user, $name)) {
             throw new \Exception('Action not allowed');
         }