laudeco / bbc-dolibarr-flightlog

class/card/TabCollection.php

Spacing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
      * @return array
      */
     public function toArray() {
-        return array_map(function(Tab $tab){
+        return array_map(function(Tab $tab) {
             return $tab->toArray();
         }, $this->tabs);
     }

query/BillableFlightQueryHandler.php

Spacing +2 added lines, -2 removed lines

@@ -145,7 +145,7 @@ 
 
         //Total damages
         $damages = $this->pilotDamageQueryRepository->query($query->getFiscalYear());
-        foreach($damages as $currentDamage){
+        foreach ($damages as $currentDamage) {
 
             //Pilot doesn't exist
             if (!isset($pilots[$currentDamage->getAuthorId()])) {
@@ -158,7 +158,7 @@ 
             );
 
             // The damage is already invoiced. So not take into account.
-            if($currentDamage->isInvoiced()){
+            if ($currentDamage->isInvoiced()) {
                 $pilots[$currentDamage->getAuthorId()] = $pilots[$currentDamage->getAuthorId()]->addCount(
                     new FlightTypeCount('invoiced_damage', $currentDamage->getAmount(), -1)
                 );

readFlights.php

Spacing +5 added lines, -5 removed lines

@@ -230,7 +230,7 @@ 
     print '<td>' . $pilot->getCountForType('orga_T6')->getCount() . '</td>';
     print '<td>' . $pilot->getCountForType('orga_T6')->getCost()->getValue() . '</td>';
 
-    print sprintf('<td class="%s">', $pilot->getFlightBonus()->getValue() === 0?'text-muted':'text-bold'). $pilot->getFlightBonus()->getValue() . ' pts</td>';
+    print sprintf('<td class="%s">', $pilot->getFlightBonus()->getValue() === 0 ? 'text-muted' : 'text-bold') . $pilot->getFlightBonus()->getValue() . ' pts</td>';
 
     print '<td>' . $pilot->getCountForType('3')->getCount() . '</td>';
     print '<td>' . price($pilot->getCountForType('3')->getCost()->getValue()) . '€</td>';
@@ -249,8 +249,8 @@ 
     print '<td>' . price($pilot->getCountForType('damage')->getCost()->getValue()) . '€</td>';
     print '<td>' . price($pilot->getCountForType('invoiced_damage')->getCost()->getValue()) . '€</td>';
 
-    print sprintf('<td class="%s">', $pilot->getFlightsCost()->getValue() === 0?'text-muted':'text-bold'). price($pilot->getFlightsCost()->getValue()) . '€ </td>';
-    print sprintf('<td class="%s">', $pilot->isBillable(FlightBonus::zero())?'text-bold':'text-muted'). price($pilot->getTotalBill()->getValue()) . '€</td>';
+    print sprintf('<td class="%s">', $pilot->getFlightsCost()->getValue() === 0 ? 'text-muted' : 'text-bold') . price($pilot->getFlightsCost()->getValue()) . '€ </td>';
+    print sprintf('<td class="%s">', $pilot->isBillable(FlightBonus::zero()) ? 'text-bold' : 'text-muted') . price($pilot->getTotalBill()->getValue()) . '€</td>';
     print '</tr>';
 }
 
@@ -275,7 +275,7 @@ 
 print '<td>' . $totalT3 . '</td>';
 print '<td></td>';
 
-print '<td>' . $totalT4. '</td>';
+print '<td>' . $totalT4 . '</td>';
 print '<td></td>';
 
 print '<td>' . $totalT5 . '</td>';
@@ -304,7 +304,7 @@ 
 //table km
 $tauxRemb = isset($conf->global->BBC_FLIGHT_LOG_TAUX_REMB_KM) ? $conf->global->BBC_FLIGHT_LOG_TAUX_REMB_KM : 0;
 $year = GETPOST("year", 'int');
-if(empty($year)){
+if (empty($year)) {
     $year = date('Y');
 }
 

Infrastructure/Damage/Query/Repository/GetPilotDamagesQueryRepository.php

Spacing +5 added lines, -5 removed lines

@@ -35,16 +35,16 @@
     public function query($year)
     {
         $sql = 'SELECT damage.amount as amount, damage.billed as billed, damage.author_id as author, author.firstname as author_name';
-        $sql.=' FROM '.MAIN_DB_PREFIX.'bbc_flight_damages as damage';
-        $sql.=' INNER JOIN '.MAIN_DB_PREFIX.'bbc_vols as flight ON flight.rowid = damage.flight_id';
-        $sql.=' INNER JOIN '.MAIN_DB_PREFIX.'user as author ON author.rowid = damage.author_id';
-        $sql.=' WHERE YEAR(flight.date) = '.$this->db->escape($year);
+        $sql .= ' FROM ' . MAIN_DB_PREFIX . 'bbc_flight_damages as damage';
+        $sql .= ' INNER JOIN ' . MAIN_DB_PREFIX . 'bbc_vols as flight ON flight.rowid = damage.flight_id';
+        $sql .= ' INNER JOIN ' . MAIN_DB_PREFIX . 'user as author ON author.rowid = damage.author_id';
+        $sql .= ' WHERE YEAR(flight.date) = ' . $this->db->escape($year);
 
         $resql = $this->db->query($sql);
         if ($resql) {
             $num = $this->db->num_rows($resql);
             if ($num) {
-                for($i = 0; $i < $num ; $i++) {
+                for ($i = 0; $i < $num; $i++) {
                     $properties = $this->db->fetch_array($resql);
                     $damage = TotalDamage::fromArray($properties);
                     yield $damage;

Application/Damage/Command/InvoiceDamageCommandHandler.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      *
      * @throws \Exception
      */
-    public function __invoke(InvoiceDamageCommand $command){
+    public function __invoke(InvoiceDamageCommand $command) {
         $damage = $this->damageRepository->getById(DamageId::create($command->getDamageId()));
         $damage = $damage->invoice();
         $this->damageRepository->save($damage);

Infrastructure/Common/Repository/AbstractDomainRepository.php

Spacing +14 added lines, -14 removed lines

@@ -23,7 +23,7 @@ 
     public function __construct(\DoliDB $db, $tableName)
     {
         $this->db = $db;
-        $this->tableName = strpos($tableName, MAIN_DB_PREFIX) === 0 ? $tableName : MAIN_DB_PREFIX.$tableName;
+        $this->tableName = strpos($tableName, MAIN_DB_PREFIX) === 0 ? $tableName : MAIN_DB_PREFIX . $tableName;
     }
 
     /**
@@ -33,7 +33,7 @@ 
      *
      * @throws \Exception
      */
-    protected function write(array $elements){
+    protected function write(array $elements) {
         $columns = join(',', array_keys($elements));
         $values = join(',', array_map([$this, 'escape'], array_values($elements)));
 
@@ -44,7 +44,7 @@ 
             $lasterror = $this->db->lasterror();
             dol_syslog(__METHOD__ . ' ' . $lasterror, LOG_ERR);
             $this->db->rollback();
-            throw new \Exception("Repository error - ".$lasterror);
+            throw new \Exception("Repository error - " . $lasterror);
         }
 
         $id = $this->db->last_insert_id($this->tableName);
@@ -57,16 +57,16 @@ 
      *
      * @return int|string|null
      */
-    private function escape($value){
-        if(is_null($value)){
+    private function escape($value) {
+        if (is_null($value)) {
             return null;
         }
 
-        if(is_bool($value)){
-            return (int)$value;
+        if (is_bool($value)) {
+            return (int) $value;
         }
 
-        return is_string($value) ? $this->db->escape($value) : $value ;
+        return is_string($value) ? $this->db->escape($value) : $value;
     }
 
     /**
@@ -79,18 +79,18 @@ 
     {
         $sqlModifications = [];
 
-        foreach($elements as $field => $value){
+        foreach ($elements as $field => $value) {
             $sqlModifications[] = sprintf('%s=%s', $field, $this->escape($value));
         }
 
         $this->db->begin();
-        $resql = $this->db->query(sprintf('UPDATE %s SET %s WHERE rowid = %s ', $this->tableName, join(',',$sqlModifications), $id));
+        $resql = $this->db->query(sprintf('UPDATE %s SET %s WHERE rowid = %s ', $this->tableName, join(',', $sqlModifications), $id));
 
         if (!$resql) {
             $lasterror = $this->db->lasterror();
             dol_syslog(__METHOD__ . ' ' . $lasterror, LOG_ERR);
             $this->db->rollback();
-            throw new \Exception("Repository error - ".$lasterror);
+            throw new \Exception("Repository error - " . $lasterror);
         }
 
         $this->db->commit();
@@ -103,8 +103,8 @@ 
      *
      * @return array|null
      */
-    protected function get($id){
-        $sql = sprintf('SELECT * FROM %s WHERE rowid = %s', $this->tableName, $id );
+    protected function get($id) {
+        $sql = sprintf('SELECT * FROM %s WHERE rowid = %s', $this->tableName, $id);
 
         $resql = $this->db->query($sql);
         if (!$resql) {
@@ -116,7 +116,7 @@ 
             return null;
         }
 
-        for($i = 0; $i < $num ; $i++) {
+        for ($i = 0; $i < $num; $i++) {
             return $this->db->fetch_array($resql);
         }
 

Application/Damage/Command/CreateDamageCommand.php

Doc Comments +3 added lines

@@ -27,6 +27,9 @@
      */
     private $billId;
 
+    /**
+     * @param integer $authorId
+     */
     public function __construct($authorId)
     {
         $this->authorId = $authorId;

Infrastructure/Common/Routes/Route.php

Doc Comments -1 removed lines

@@ -61,7 +61,6 @@
     }
 
     /**
-     * @param string $action
      *
      * @return bool
      */

Unused Use Statements -2 removed lines

@@ -4,8 +4,6 @@
 namespace FlightLog\Infrastructure\Common\Routes;
 
 
-use FlightLog\Http\Web\Controller\WebController;
-
 final class Route
 {
 

Spacing +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
      *
      * @return bool
      */
-    public function match($route){
+    public function match($route) {
         return $this->name === $route;
     }
 

Application/Damage/Command/CreateDamageCommandHandler.php

Spacing +6 added lines, -6 removed lines

@@ -41,7 +41,7 @@ 
     public function __invoke(CreateDamageCommand $command)
     {
         $damage = FlightDamage::waiting(new DamageAmount($command->getAmount()), AuthorId::create($command->getAuthorId()));
-        if(null !== $command->getFlightId()){
+        if (null !== $command->getFlightId()) {
             $damage = FlightDamage::damage(FlightId::create($command->getFlightId()), new DamageAmount($command->getAmount()), AuthorId::create($command->getAuthorId()));
         }
 
@@ -59,7 +59,7 @@ 
      */
     private function linkSupplierInvoice($damageId, $invoiceId)
     {
-        if($invoiceId <= 0){
+        if ($invoiceId <= 0) {
             return;
         }
 
@@ -80,8 +80,8 @@ 
      * @param int $targetId
      * @param string $targetType
      */
-    private function insertLinks($damageId, $targetId, $targetType){
-        $sql = "INSERT INTO ".MAIN_DB_PREFIX."element_element (";
+    private function insertLinks($damageId, $targetId, $targetType) {
+        $sql = "INSERT INTO " . MAIN_DB_PREFIX . "element_element (";
         $sql .= "fk_source";
         $sql .= ", sourcetype";
         $sql .= ", fk_target";
@@ -89,8 +89,8 @@ 
         $sql .= ") VALUES (";
         $sql .= $damageId;
         $sql .= ", 'flightlog_damage'";
-        $sql .= ", ".$targetId;
-        $sql .= ", '".$targetType."'";
+        $sql .= ", " . $targetId;
+        $sql .= ", '" . $targetType . "'";
         $sql .= ")";
 
         if ($this->db->query($sql))