Completed
Push — feature/number_enhancement ( b65f30 )
by Laurent
01:38
created
card_tab_financial.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
 
44 44
 $id = GETPOST('id', 'int') ?: GETPOST('idBBC_vols', 'int');
45 45
 $action = GETPOST('action', 'alpha');
46
-$permissiondellink=$user->rights->flightlog->vol->financial;
46
+$permissiondellink = $user->rights->flightlog->vol->financial;
47 47
 
48 48
 $object = new Bbcvols($db);
49 49
 $extrafields = new ExtraFields($db);
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
62 62
 $extralabels = $extrafields->fetch_name_optionals_label($object->table_element);
63 63
 
64 64
 // Load object
65
-include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php';  // Must be include, not include_once  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
66
-include DOL_DOCUMENT_ROOT.'/core/actions_dellink.inc.php';
65
+include DOL_DOCUMENT_ROOT . '/core/actions_fetchobject.inc.php'; // Must be include, not include_once  // Must be include, not include_once. Include fetch and fetch_thirdparty but not fetch_optionals
66
+include DOL_DOCUMENT_ROOT . '/core/actions_dellink.inc.php';
67 67
 
68 68
 // Initialize technical object to manage hooks of modules. Note that conf->hooks_modules contains array array
69 69
 $hookmanager->initHooks(array('bbcvols'));
@@ -99,20 +99,20 @@  discard block
 block discarded – undo
99 99
 print '<tr><td class="fieldrequired">' . $langs->trans("Fielddate") . '</td><td>' . dol_print_date($object->date) . '</td></tr>';
100 100
 
101 101
 if ($user->rights->flightlog->vol->financial) {
102
-    print '<tr><td class="fieldrequired">' . $langs->trans("Fieldis_facture") . '</td><td>' . $object->getLibStatut(5). '</td></tr>';
102
+    print '<tr><td class="fieldrequired">' . $langs->trans("Fieldis_facture") . '</td><td>' . $object->getLibStatut(5) . '</td></tr>';
103 103
 }
104 104
 
105 105
 print '<tr><td class="fieldrequired">' . $langs->trans("Fieldkilometers") . '</td><td>' . $object->kilometers . ' KM</td></tr>';
106 106
 print '<tr><td class="fieldrequired">' . $langs->trans("Fieldjustif_kilometers") . '</td><td>' . $object->justif_kilometers . '</td></tr>';
107
-if($object->hasReceiver()){
107
+if ($object->hasReceiver()) {
108 108
     print '<tr><td class="fieldrequired">' . $langs->trans("Fieldcost") . '</td><td>' . $object->cost . " " . $langs->getCurrencySymbol($conf->currency) . '</td></tr>';
109 109
     print '<tr><td class="fieldrequired">' . $langs->trans("Fieldfk_receiver") . '</td><td>' . $receiver->getNomUrl(1) . '</td></tr>';
110 110
 }
111 111
 
112
-if($object->isLinkedToOrder()){
112
+if ($object->isLinkedToOrder()) {
113 113
     print '<tr><td class="fieldrequired">' . $langs->trans("Order") . '</td><td><ul>';
114
-    foreach($object->getOrders() as $currentOrder){
115
-        print '<li>'.$currentOrder->getNomUrl(1).'</li>';
114
+    foreach ($object->getOrders() as $currentOrder) {
115
+        print '<li>' . $currentOrder->getNomUrl(1) . '</li>';
116 116
     }
117 117
     print '</ul></td></tr>';
118 118
 }
@@ -124,18 +124,18 @@  discard block
 block discarded – undo
124 124
 print '<div class="tabsAction">' . "\n";
125 125
 
126 126
 // Make invoice
127
-if($user->rights->flightlog->vol->financial && $object->fk_type == 2 && !$object->hasFacture()){
128
-    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/facture.php?id=' . $object->id.'">' . $langs->trans("Facturer") . '</a></div>' . "\n";
127
+if ($user->rights->flightlog->vol->financial && $object->fk_type == 2 && !$object->hasFacture()) {
128
+    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/facture.php?id=' . $object->id . '">' . $langs->trans("Facturer") . '</a></div>' . "\n";
129 129
 }
130 130
 
131 131
 // Open
132
-if($object->isBilled() && $object->isBillingRequired()){
133
-    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/card_tab_financial.php?action=open&id=' . $object->id.'">' . $langs->trans("Ouvrir") . '</a></div>' . "\n";
132
+if ($object->isBilled() && $object->isBillingRequired()) {
133
+    print '<div class="inline-block divButAction"><a class="butAction" href="' . DOL_URL_ROOT . '/flightlog/card_tab_financial.php?action=open&id=' . $object->id . '">' . $langs->trans("Ouvrir") . '</a></div>' . "\n";
134 134
 }
135 135
 
136 136
 print '</div>' . "\n";
137 137
 
138
-if($user->rights->flightlog->vol->financial){
138
+if ($user->rights->flightlog->vol->financial) {
139 139
     print '<div class="fichecenter"><div class="fichehalfleft">';
140 140
     $form->showLinkedObjectBlock($object);
141 141
     print '</div></div>';
Please login to merge, or discard this patch.
command/CreateFlightCommandHandler.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $vol = new Bbcvols($this->db);
66 66
         $vol->date = $command->getDate()->getTimestamp();
67 67
         $vol->lieuD = $command->getLieuD();
68
-        $vol->lieuA =$command->getLieuA();
68
+        $vol->lieuA = $command->getLieuA();
69 69
         $vol->heureD = $command->getHeureD()->format('Hi');
70 70
         $vol->heureA = $command->getHeureA()->format('Hi');
71 71
         $vol->BBC_ballons_idBBC_ballons = $command->getBBCBallonsIdBBCBallons();
@@ -73,14 +73,14 @@  discard block
 block discarded – undo
73 73
         $vol->remarque = $command->getRemarque();
74 74
         $vol->incidents = $command->getIncidents();
75 75
         $vol->fk_type = $command->getFkType();
76
-        $vol->fk_pilot =$command->getFkPilot();
76
+        $vol->fk_pilot = $command->getFkPilot();
77 77
         $vol->fk_organisateur = $command->getFkOrganisateur();
78 78
         $vol->kilometers = $command->getKilometers();
79 79
         $vol->cost = $command->getCost();
80 80
         $vol->fk_receiver = $command->getFkReceiver();
81 81
         $vol->justif_kilometers = $command->getJustifKilometers();
82 82
         $vol->setPassengerNames($command->getPassengerNames());
83
-        foreach($command->getOrderIds() as $orderId => $nbrPassengers){
83
+        foreach ($command->getOrderIds() as $orderId => $nbrPassengers) {
84 84
             $vol->addOrderId($orderId, $nbrPassengers);
85 85
         }
86 86
 
@@ -88,12 +88,12 @@  discard block
 block discarded – undo
88 88
             throw new Exception();
89 89
         }
90 90
 
91
-        if(!$vol->isBillingRequired() || ($vol->isLinkedToOrder() && $vol->hasReceiver())){
91
+        if (!$vol->isBillingRequired() || ($vol->isLinkedToOrder() && $vol->hasReceiver())) {
92 92
             $vol->is_facture = true;
93 93
         }
94 94
 
95 95
         $result = $vol->create($this->user);
96
-        if($result <= 0){
96
+        if ($result <= 0) {
97 97
             throw new Exception();
98 98
         }
99 99
 
@@ -113,27 +113,27 @@  discard block
 block discarded – undo
113 113
     {
114 114
         $flight->fetch($flight->id);
115 115
 
116
-        if(!$flight->isLinkedToOrder()){
116
+        if (!$flight->isLinkedToOrder()) {
117 117
             return;
118 118
         }
119 119
 
120
-        foreach($flight->getOrders() as $currentOrder){
120
+        foreach ($flight->getOrders() as $currentOrder) {
121 121
             $currentOrder->add_object_linked('flightlog_bbcvols', $flight->getId());
122 122
             $currentOrder->fetch_lines();
123 123
 
124 124
             $qtyOrder = 0;
125 125
             /** @var OrderLine $currentOrderLine */
126
-            foreach($currentOrder->lines as $currentOrderLine){
127
-                $qtyOrder += (int)$currentOrderLine->qty;
126
+            foreach ($currentOrder->lines as $currentOrderLine) {
127
+                $qtyOrder += (int) $currentOrderLine->qty;
128 128
             }
129 129
 
130 130
             $passangersCount = $this->numberOfPassengersLinkedToOrder($currentOrder->id);
131 131
 
132
-            if($passangersCount < $qtyOrder){
132
+            if ($passangersCount < $qtyOrder) {
133 133
                 continue;
134 134
             }
135 135
 
136
-            if($currentOrder->statut == Commande::STATUS_VALIDATED){
136
+            if ($currentOrder->statut == Commande::STATUS_VALIDATED) {
137 137
                 $currentOrder->cloture($this->user);
138 138
             }
139 139
         }
Please login to merge, or discard this patch.
validators/FlightValidator.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
      */
152 152
     private function checkPassengersInformation($vol)
153 153
     {
154
-        if (!is_numeric($vol->nbrPax) || (int)$vol->nbrPax < 0) {
154
+        if (!is_numeric($vol->nbrPax) || (int) $vol->nbrPax < 0) {
155 155
             $this->addError('nbrPax', 'Erreur le nombre de passager est un nombre négatif.');
156 156
         }
157 157
 
@@ -203,13 +203,13 @@  discard block
 block discarded – undo
203 203
      */
204 204
     private function checkFlightInformation($vol)
205 205
     {
206
-        if(empty($vol->getHeureD()) || $vol->getHeureD() === '0000'){
206
+        if (empty($vol->getHeureD()) || $vol->getHeureD() === '0000') {
207 207
             $this->addError('heureD', "L'heure depart est vide");
208 208
         }
209 209
         if (!$this->isHourValid($vol->heureD)) {
210 210
             $this->addError('heureD', "L'heure depart n'est pas correcte");
211 211
         }
212
-        if(empty($vol->getHeureA()) || $vol->getHeureA() === '0000'){
212
+        if (empty($vol->getHeureA()) || $vol->getHeureA() === '0000') {
213 213
             $this->addError('heureD', "L'heure d'arrivée est vide");
214 214
         }
215 215
 
@@ -249,10 +249,10 @@  discard block
 block discarded – undo
249 249
                 $this->addError('order_id', 'Le nombre de passager par commande doit être >= 0.');
250 250
             }
251 251
 
252
-            $totalPassenegrs += (int)$nbrPassengers;
252
+            $totalPassenegrs += (int) $nbrPassengers;
253 253
         }
254 254
 
255
-        if (!$vol->hasReceiver() && $totalPassenegrs !== (int)$vol->getNumberOfPassengers()) {
255
+        if (!$vol->hasReceiver() && $totalPassenegrs !== (int) $vol->getNumberOfPassengers()) {
256 256
             $this->addError('nbrPax', 'Le nombre de passagers ne correspond pas au nombre entré sur les commandes');
257 257
         }
258 258
 
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
278 278
 
279 279
     private function checkBalloon(Bbcvols $flight)
280 280
     {
281
-        if($flight->getBBCBallonsIdBBCBallons() > 0){
281
+        if ($flight->getBBCBallonsIdBBCBallons() > 0) {
282 282
             return $this;
283 283
         }
284 284
 
Please login to merge, or discard this patch.
class/bbcvols.class.php 1 patch
Spacing   +18 added lines, -18 removed lines patch added patch discarded remove patch
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
259 259
         $sql .= ' ' . (!isset($this->justif_kilometers) ? 'NULL' : "'" . $this->db->escape($this->justif_kilometers) . "'") . ',';
260 260
         $sql .= ' ' . "'" . date('Y-m-d H:i:s') . "'" . ',';
261 261
         $sql .= ' ' . "'" . date('Y-m-d H:i:s') . "'" . ',';
262
-        $sql .= ' ' . "'" . $this->passengerNames . "'" ;
262
+        $sql .= ' ' . "'" . $this->passengerNames . "'";
263 263
         $sql .= ')';
264 264
 
265 265
         $this->db->begin();
@@ -273,7 +273,7 @@  discard block
 block discarded – undo
273 273
 
274 274
         if (!$error) {
275 275
             $this->id = $this->db->last_insert_id(MAIN_DB_PREFIX . $this->table_element);
276
-            if(!$this->insertOrders()){
276
+            if (!$this->insertOrders()) {
277 277
                 $error++;
278 278
             }
279 279
 
@@ -299,9 +299,9 @@  discard block
 block discarded – undo
299 299
     /**
300 300
      * Inserts the order linked to the flight
301 301
      */
302
-    private function insertOrders(){
302
+    private function insertOrders() {
303 303
 
304
-        if(empty($this->orderIds)){
304
+        if (empty($this->orderIds)) {
305 305
             return true;
306 306
         }
307 307
 
@@ -316,12 +316,12 @@  discard block
 block discarded – undo
316 316
         
317 317
         $values = [];
318 318
 
319
-        foreach($this->orderIds as $orderId=>$nbrPassengers){
319
+        foreach ($this->orderIds as $orderId=>$nbrPassengers) {
320 320
             $values[] = sprintf(
321 321
                 $valueTemplate,
322 322
                 $orderId,
323 323
                 $this->db->escape($this->id),
324
-                (!isset($nbrPassengers) ? '0' :  $this->db->escape($nbrPassengers))
324
+                (!isset($nbrPassengers) ? '0' : $this->db->escape($nbrPassengers))
325 325
             );
326 326
         }
327 327
 
@@ -339,9 +339,9 @@  discard block
 block discarded – undo
339 339
     /**
340 340
      * Inserts the order linked to the flight
341 341
      */
342
-    private function updateOrders(){
342
+    private function updateOrders() {
343 343
 
344
-        if(empty($this->orderIds)){
344
+        if (empty($this->orderIds)) {
345 345
             return true;
346 346
         }
347 347
 
@@ -352,9 +352,9 @@  discard block
 block discarded – undo
352 352
     /**
353 353
      * Inserts the order linked to the flight
354 354
      */
355
-    private function deleteOrders(){
355
+    private function deleteOrders() {
356 356
 
357
-        if(empty($this->orderIds)){
357
+        if (empty($this->orderIds)) {
358 358
             return true;
359 359
         }
360 360
 
@@ -559,7 +559,7 @@  discard block
 block discarded – undo
559 559
         $sql .= ' fk_receiver = ' . (isset($this->fk_receiver) && (int) $this->fk_receiver > 0 ? $this->fk_receiver : "null") . ',';
560 560
         $sql .= ' justif_kilometers = ' . (isset($this->justif_kilometers) ? "'" . $this->db->escape($this->justif_kilometers) . "'," : "'',");
561 561
         $sql .= ' date_update = ' . "'" . date('Y-m-d H:i:s') . "',";
562
-        $sql .= ' passenger_names = ' . "'" . trim($this->passengerNames)."'";
562
+        $sql .= ' passenger_names = ' . "'" . trim($this->passengerNames) . "'";
563 563
 
564 564
         $sql .= ' WHERE idBBC_vols=' . $this->idBBC_vols;
565 565
 
@@ -1022,8 +1022,8 @@  discard block
 block discarded – undo
1022 1022
      * @param int $orderId
1023 1023
      * @param int $nbrPassengers
1024 1024
      */
1025
-    public function addOrderId($orderId, $nbrPassengers){
1026
-        if(!isset($this->orderIds)){
1025
+    public function addOrderId($orderId, $nbrPassengers) {
1026
+        if (!isset($this->orderIds)) {
1027 1027
             $this->orderIds = [];
1028 1028
         }
1029 1029
 
@@ -1063,7 +1063,7 @@  discard block
 block discarded – undo
1063 1063
         if ($resql) {
1064 1064
             $numrows = $this->db->num_rows($resql);
1065 1065
             if ($numrows) {
1066
-                for($i = 0 ; $i < $numrows ; $i++){
1066
+                for ($i = 0; $i < $numrows; $i++) {
1067 1067
                     $obj = $this->db->fetch_object($resql);
1068 1068
                     $this->orderIds[$obj->order_id] = $obj->nbr_passengers;
1069 1069
 
@@ -1084,7 +1084,7 @@  discard block
 block discarded – undo
1084 1084
      */
1085 1085
     public function getOrders()
1086 1086
     {
1087
-        if(!isset($this->orders) || empty($this->orders)){
1087
+        if (!isset($this->orders) || empty($this->orders)) {
1088 1088
             $this->fetchOrder();
1089 1089
         }
1090 1090
         return $this->orders;
@@ -1209,7 +1209,7 @@  discard block
 block discarded – undo
1209 1209
      */
1210 1210
     public function getBBCBallonsIdBBCBallons()
1211 1211
     {
1212
-        return (int)$this->BBC_ballons_idBBC_ballons;
1212
+        return (int) $this->BBC_ballons_idBBC_ballons;
1213 1213
     }
1214 1214
 
1215 1215
     /**
@@ -1285,7 +1285,7 @@  discard block
 block discarded – undo
1285 1285
      */
1286 1286
     public function getFkType()
1287 1287
     {
1288
-        return (int)$this->fk_type;
1288
+        return (int) $this->fk_type;
1289 1289
     }
1290 1290
 
1291 1291
     /**
@@ -1380,7 +1380,7 @@  discard block
 block discarded – undo
1380 1380
      */
1381 1381
     public function getFkReceiver()
1382 1382
     {
1383
-        return (int)$this->fk_receiver;
1383
+        return (int) $this->fk_receiver;
1384 1384
     }
1385 1385
 
1386 1386
     /**
Please login to merge, or discard this patch.
lib/card.lib.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
         'Vol',
34 34
         'Finances',
35 35
         'Dégâts',
36
-        'Remarques '.($flight->hasComment() ? ' - <span class="fa fa-comment" title="'.$flight->getComment().'"></span>' : '').($flight->hasIncidents() ? ' - <span class="fa fa-exclamation" title="'.$flight->getIncident().'"></span>' : ''),
36
+        'Remarques ' . ($flight->hasComment() ? ' - <span class="fa fa-comment" title="' . $flight->getComment() . '"></span>' : '') . ($flight->hasIncidents() ? ' - <span class="fa fa-exclamation" title="' . $flight->getIncident() . '"></span>' : ''),
37 37
         'Suivis',
38 38
     ];
39 39
 
Please login to merge, or discard this patch.
Infrastructure/Flight/Query/Repository/TakeOffQueryRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
             WHERE 
36 36
               fk_type IN (1,2)
37 37
               AND YEAR(NOW())-1 <= YEAR(llx_bbc_vols.date)
38
-              AND llx_bbc_vols.fk_pilot = '.$pilot.'
38
+              AND llx_bbc_vols.fk_pilot = '.$pilot . '
39 39
             
40 40
             GROUP BY
41 41
               llx_bbc_vols.lieuD
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
         $places = [];
59 59
 
60
-        for($i = 0; $i < $num ; $i++) {
60
+        for ($i = 0; $i < $num; $i++) {
61 61
             $properties = $this->db->fetch_array($resql);
62 62
             $stat = new TakeOffPlace($properties['place']);
63 63
             $places[] = $stat;
Please login to merge, or discard this patch.