laudeco / bbc-dolibarr-flightlog

lib/flightLog.lib.php

Doc Comments +1 added lines, -1 removed lines

@@ -108,7 +108,7 @@
 }
 
 /**
- * @param null $year
+ * @param integer $year
  * @param null $pilotId
  * @param null $quarter
  * @param bool $groupBy

Spacing +5 added lines, -5 removed lines

@@ -90,11 +90,11 @@ 
         if ($num) {
             while ($i < $num) {
                 $obj = $db->fetch_object($resql);
-                $currentValue = substr($obj->immat, 0,2);
+                $currentValue = substr($obj->immat, 0, 2);
 
                 if ($obj) {
-                    if(true === $group && $currentValue !== $lastValue){
-                        print '<optgroup label="'.$currentValue.'">';
+                    if (true === $group && $currentValue !== $lastValue) {
+                        print '<optgroup label="' . $currentValue . '">';
                     }
 
                     $lastValue = $currentValue;
@@ -111,8 +111,8 @@ 
                     echo strtoupper($obj->immat);
                     print "</option>";
 
-                    if(true === $group && $currentValue !== $lastValue){
-                        print '<optgroup label="'.$currentValue.'">';
+                    if (true === $group && $currentValue !== $lastValue) {
+                        print '<optgroup label="' . $currentValue . '">';
                     }
 
 

command/CreateFlightBillCommand.php

Spacing +1 added lines, -1 removed lines

@@ -91,7 +91,7 @@
             throw new \InvalidArgumentException('Model document is missing');
         }
 
-        if(!isset($nbrPax) || !is_numeric($nbrPax) || $nbrPax != (int) $nbrPax){
+        if (!isset($nbrPax) || !is_numeric($nbrPax) || $nbrPax != (int) $nbrPax) {
             throw new \InvalidArgumentException('The number of pax is not correct, an integer is expected');
         }
 

class/bbctypes.class.php

Doc Comments +1 added lines, -1 removed lines

@@ -645,7 +645,7 @@
     }
 
     /**
-     * @return array|BbctypesLine[]
+     * @return BbctypesLine[]
      */
     public function getLines()
     {

Spacing +1 added lines, -1 removed lines

@@ -733,7 +733,7 @@
      */
     public function getActive()
     {
-        return (boolean)$this->active;
+        return (boolean) $this->active;
     }
 
     /**

Form/Form.php

Doc Comments +2 added lines, -1 removed lines

@@ -95,6 +95,7 @@ 
 
     /**
      * @inheritDoc
+     * @param string $fieldName
      */
     public function remove($fieldName)
     {
@@ -142,7 +143,7 @@ 
     }
 
     /**
-     * @param null|\ValidatorInterface $validator
+     * @param ValidatorInterface $validator
      *
      * @return Form
      */

Spacing +2 added lines, -2 removed lines

@@ -87,7 +87,7 @@ 
      */
     public function add(FormElementInterface $element)
     {
-        if(array_key_exists($element->getName(), $this->elements)){
+        if (array_key_exists($element->getName(), $this->elements)) {
             throw new \InvalidArgumentException('Element already exists');
         }
         $this->elements[$element->getName()] = $element;
@@ -141,7 +141,7 @@ 
      */
     public function getErrorMessages()
     {
-        if(!$this->validator){
+        if (!$this->validator) {
             return [];
         }
 

Form/InputDate.php

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
      */
     public function setValue($value)
     {
-        if($value instanceof \DateTime){
+        if ($value instanceof \DateTime) {
             return parent::setValue($value->format('Y-m-d'));
         }
 

Form/FlightForm.php

Spacing +2 added lines, -2 removed lines

@@ -27,7 +27,7 @@ 
      * @param array $options
      * @param \User $user
      */
-    public function __construct(\ValidatorInterface $validator, $baseObject, \DoliDB $db, $options,\User $user)
+    public function __construct(\ValidatorInterface $validator, $baseObject, \DoliDB $db, $options, \User $user)
     {
 
         parent::__construct('flight_form', FormInterface::METHOD_POST, $this->buildOptionsfromConfiguration($options));
@@ -83,7 +83,7 @@ 
         $flight = $object;
 
         // Quick fix - Fixme by a factory on this form.
-        if($this->user->rights->flightlog->vol->advanced){
+        if ($this->user->rights->flightlog->vol->advanced) {
             return parent::bind($object);
         }
 

command/CreateExpenseNoteCommandHandler.php

Spacing +1 added lines, -1 removed lines

@@ -272,7 +272,7 @@
         $expenseNoteUser = new User($this->db);
         $expenseNoteUser->id = $currentMissionUserId;
         $id = $expenseNote->create($expenseNoteUser);
-        if($id < 0){
+        if ($id < 0) {
             return null;
         }
 

query/GetPilotsWithMissionsQueryHandler.php

Spacing +3 added lines, -3 removed lines

@@ -52,9 +52,9 @@ 
                         $pilotLastname = $obj->lastname;
                         $pilotFirstname = $obj->firstname;
 
-                        if($query->isPilotsOnly()){
+                        if ($query->isPilotsOnly()) {
                             $result->addPilot($pilotId, $pilotFirstname, $pilotLastname);
-                        }else{
+                        } else {
                             $result->addMission($obj->quartil, $pilotId, $pilotFirstname, $pilotLastname,
                                 $obj->number_flights, $obj->total_kilometers);
                         }
@@ -79,7 +79,7 @@ 
         $sql .= " , SUM(VOL.kilometers) as total_kilometers ";
         $sql .= " , COUNT(VOL.idBBC_vols) as number_flights";
 
-        if(!$query->isPilotsOnly()){
+        if (!$query->isPilotsOnly()) {
             $sql .= " , QUARTER(VOL.date) as quartil ";
         }
 

Braces +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
 
                         if($query->isPilotsOnly()){
                             $result->addPilot($pilotId, $pilotFirstname, $pilotLastname);
-                        }else{
+                        } else{
                             $result->addMission($obj->quartil, $pilotId, $pilotFirstname, $pilotLastname,
                                 $obj->number_flights, $obj->total_kilometers);
                         }

command/CreateFlightCommand.php

Spacing +1 added lines, -1 removed lines

@@ -397,7 +397,7 @@
     /**
      * @return bool
      */
-    public function hasOrderId(){
+    public function hasOrderId() {
         return count($this->orderIds) > 0;
     }
 }
\ No newline at end of file