Client::getTaxesForOrder() - Code Metrics - Inspection of "Add PSR-6 Caching" - lashowroom/taxjar-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3229d6...c9eeb2 )

by Baldur

created 2017-02-01 20:36 UTC

Client::getTaxesForOrder() A

↳ Parent: Client

Complexity

Conditions	3
Paths	3

Size

Total Lines	17
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	9
cts	9
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	9
nc	3
nop	1
crap	3

<?php

namespace LAShowroom\TaxJarBundle;

use LAShowroom\TaxJarBundle\Model\Order;
use LAShowroom\TaxJarBundle\Model\Response\TaxResponse;
use Psr\Cache\CacheItemPoolInterface;
use TaxJar\Client as TaxJarClient;

class Client
{
    /**
     * @var TaxJarClient
     */
    private $apiClient;

    /**
     * @var CacheItemPoolInterface
     */
    private $cacheItemPool;

    /**
     * @param TaxJarClient $apiClient
     */
    public function __construct(TaxJarClient $apiClient)
    {
        $this->apiClient = $apiClient;
    }

    /**
     * @param Order $order
     *
     * @return TaxResponse
     */
    public function getTaxesForOrder(Order $order)
    {
        if (null === $this->cacheItemPool) {
            return new TaxResponse($this->apiClient->taxForOrder($order->toArray()));
        }

        /** @var \Symfony\Component\Cache\CacheItem $cacheItem */
        $cacheItem = $this->cacheItemPool->getItem($order->getCacheKey());

        if (!$cacheItem->isHit()) {
            $cacheItem->set(new TaxResponse($this->apiClient->taxForOrder($order->toArray())));
            $this->cacheItemPool->save($cacheItem);
            $cacheItem->expiresAt(new \DateTime('+1 day'));
        }

        return $cacheItem->get();
    }

    /**
     * @param CacheItemPoolInterface $cacheItemPool
     */
    public function setCacheItemPool(CacheItemPoolInterface $cacheItemPool)
    {
        $this->cacheItemPool = $cacheItemPool;
    }
}


1		<?php
2
3		namespace LAShowroom\TaxJarBundle;
4
5		use LAShowroom\TaxJarBundle\Model\Order;
6		use LAShowroom\TaxJarBundle\Model\Response\TaxResponse;
7		use Psr\Cache\CacheItemPoolInterface;
8		use TaxJar\Client as TaxJarClient;
9
10		class Client
11		{
12		/**
13		* @var TaxJarClient
14		*/
15		private $apiClient;
16
17		/**
18		* @var CacheItemPoolInterface
19		*/
20		private $cacheItemPool;
21
22		/**
23		* @param TaxJarClient $apiClient
24		*/
25	6	public function __construct(TaxJarClient $apiClient)
26		{
27	6	$this->apiClient = $apiClient;
28	6	}
29
30		/**
31		* @param Order $order
32		*
33		* @return TaxResponse
34		*/
35	6	public function getTaxesForOrder(Order $order)
36		{
37	6	if (null === $this->cacheItemPool) {
38	4	return new TaxResponse($this->apiClient->taxForOrder($order->toArray()));
39		}
40
41		/** @var \Symfony\Component\Cache\CacheItem $cacheItem */
42	4	$cacheItem = $this->cacheItemPool->getItem($order->getCacheKey());
43
44	4	if (!$cacheItem->isHit()) {
45	2	$cacheItem->set(new TaxResponse($this->apiClient->taxForOrder($order->toArray())));
46	2	$this->cacheItemPool->save($cacheItem);
47	2	$cacheItem->expiresAt(new \DateTime('+1 day'));
48		}
49
50	4	return $cacheItem->get();
51		}
52
53		/**
54		* @param CacheItemPoolInterface $cacheItemPool
55		*/
56	4	public function setCacheItemPool(CacheItemPoolInterface $cacheItemPool)
57		{
58	4	$this->cacheItemPool = $cacheItemPool;
59	4	}
60		}
61

lashowroom / taxjar-bundle

Push — master ( 3229d6...c9eeb2 )

Client::getTaxesForOrder() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like