las93 / venus3

bundles/core/Config.php

Doc Comments +3 added lines, -3 removed lines

@@ -196,8 +196,8 @@ 
 	 *
 	 * @access private
 	 * @param  string $sFileToMerge file to get
-	 * @param  object $base base
-	 * @return object
+	 * @param  stdClass $base base
+	 * @return stdClass
 	 */
 	private static function  _mergeAndGetConf(string $sFileToMerge, \StdClass $base) : \StdClass
 	{
@@ -222,7 +222,7 @@ 
 	 *
 	 * @access private
 	 * @param  $oConfFiles
-	 * @param  StdClass $base
+	 * @param  stdClass $base
 	 * @return multitype:array multitype:array
 	 */
 	private static function _recursiveGet($oConfFiles, StdClass $base) : array

bundles/core/Mother.php

Doc Comments +2 added lines, -2 removed lines

@@ -118,7 +118,7 @@ 
 	 *
 	 * @access public
 	 * @param  mixed $mKey
-	 * @return void
+	 * @return boolean
 	 */
 	public function __isset($mKey)
 	{
@@ -130,7 +130,7 @@ 
 	 *
 	 * @access public
 	 * @param  mixed $mOffset
-	 * @return mixed
+	 * @return boolean
 	 */
 	function offsetExists($mOffset)
 	{

bundles/core/Router.php

Doc Comments +2 added lines, -2 removed lines

@@ -90,7 +90,7 @@ 
 	 * run the routeur
 	 *
 	 * @access public
-	 * @return void
+	 * @return null|boolean
 	 */
 	public function run() 
 	{
@@ -378,7 +378,7 @@ 
 	 * load a route
 	 *
 	 * @access private
-	 * @param  stdClass $oRoute one route
+	 * @param  \stdClass $oRoute one route
 	 * @param  string $RequestUri URI
 	 * @return void
 	 */

Spacing +4 added lines, -4 removed lines

@@ -194,7 +194,7 @@ 
     					}
     					else if (isset($oHost->routes)) {
     
-    						foreach($oHost->routes as $sKey => $oRoute) {
+    						foreach ($oHost->routes as $sKey => $oRoute) {
 
     							$mReturn = $this->_route($oRoute, $_SERVER['REQUEST_URI']);
 
@@ -328,7 +328,7 @@ 
 						$this->_sBaseUri = preg_replace('#^[^/]+#', '', $sHost);
 					}
 
-					foreach($oHost->routes as $sKey => $oRoute) {
+					foreach ($oHost->routes as $sKey => $oRoute) {
 
 						$this->_route($oRoute, $sRoute);
 					}
@@ -392,7 +392,7 @@ 
 
 			$sFinalRoute = preg_replace_callback(
 				'|\[/{0,1}:([a-zA-Z_]+)\]|',
-				function ($aMatches) use ($oRoute) {
+				function($aMatches) use ($oRoute) {
 					return "/{0,1}(?P<".$aMatches[1].">".$oRoute->constraints->{$aMatches[1]}.")";
 				},
 				$sRoute
@@ -432,7 +432,7 @@ 
 
 			// create the $_GET by the URL
 
-			foreach($aMatch as $mKey => $sResults) {
+			foreach ($aMatch as $mKey => $sResults) {
 
 				if (is_string($mKey)) {
 

bundles/core/Security.php

Doc Comments +1 added lines, -1 removed lines

@@ -63,7 +63,7 @@
 	 * check security of access
 	 *
 	 * @access public
-	 * @return void
+	 * @return null|boolean
 	 */
 
 	public function checkSecurity() {

bundles/core/UrlManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
 	 * @access public
 	 * @param  string $sCode code of the url between "routes" and "route" in Route.conf
 	 * @param  array $aParams parameters to create the url
-	 * @return void
+	 * @return string
 	 *
 	 * @tutorial	If I have this route I could make my URL:
 	 *

Spacing +3 added lines, -3 removed lines

@@ -82,7 +82,7 @@ 
 
 						$aRoutes = array();
 
-						foreach($oHost->routes as $sKey => $oRoute) {
+						foreach ($oHost->routes as $sKey => $oRoute) {
 
 							if ($sKey === $sCode) {
 
@@ -135,8 +135,8 @@ 
 			throw new \Exception();
 		}
 		
-		$sStringToEncode = str_replace(['à','á','â','ã','ä','ç','è','é','ê','ë','ì','í','î','ï','ñ','ò','ó','ô','õ','ö','ù','ú','û','ü','ý','ÿ','À','Á','Â','Ã','Ä','Ç','È','É','Ê','Ë','Ì','Í','Î','Ï','Ñ','Ò','Ó','Ô','Õ','Ö','Ù','Ú','Û','Ü','Ý'],
-			['a','a','a','a','a','c','e','e','e','e','i','i','i','i','n','o','o','o','o','o','u','u','u','u','y','y','A','A','A','A','A','C','E','E','E','E','I','I','I','I','N','O','O','O','O','O','U','U','U','U','Y'],
+		$sStringToEncode = str_replace(['à', 'á', 'â', 'ã', 'ä', 'ç', 'è', 'é', 'ê', 'ë', 'ì', 'í', 'î', 'ï', 'ñ', 'ò', 'ó', 'ô', 'õ', 'ö', 'ù', 'ú', 'û', 'ü', 'ý', 'ÿ', 'À', 'Á', 'Â', 'Ã', 'Ä', 'Ç', 'È', 'É', 'Ê', 'Ë', 'Ì', 'Í', 'Î', 'Ï', 'Ñ', 'Ò', 'Ó', 'Ô', 'Õ', 'Ö', 'Ù', 'Ú', 'Û', 'Ü', 'Ý'],
+			['a', 'a', 'a', 'a', 'a', 'c', 'e', 'e', 'e', 'e', 'i', 'i', 'i', 'i', 'n', 'o', 'o', 'o', 'o', 'o', 'u', 'u', 'u', 'u', 'y', 'y', 'A', 'A', 'A', 'A', 'A', 'C', 'E', 'E', 'E', 'E', 'I', 'I', 'I', 'I', 'N', 'O', 'O', 'O', 'O', 'O', 'U', 'U', 'U', 'U', 'Y'],
 				$sStringToEncode);
 
 		$sStringToEncode = preg_replace('/[^a-zA-Z0-9_]+/', '_', preg_quote($sStringToEncode));

bundles/ext/facebook/base_facebook.php

Doc Comments +6 added lines, -2 removed lines

@@ -503,7 +503,7 @@ 
    * Get the UID of the connected user, or 0
    * if the Facebook user is not connected.
    *
-   * @return string the UID if available.
+   * @return integer the UID if available.
    */
   public function getUser() {
     if ($this->user !== null) {
@@ -757,6 +757,7 @@ 
    * either logged in to Facebook or has granted an offline access permission.
    *
    * @param string $code An authorization code.
+   * @param string $redirect_uri
    * @return mixed An access token exchanged for the authorization code, or
    *               false if an access token could not be generated.
    */
@@ -1135,7 +1136,7 @@ 
   /**
    * Build the URL for given domain alias, path and parameters.
    *
-   * @param $name string The name of the domain
+   * @param string $name string The name of the domain
    * @param $path string Optional path (without a leading slash)
    * @param $params array Optional query parameters
    *
@@ -1402,6 +1403,9 @@ 
     return self::endsWith($big, '.'.$small);
   }
 
+  /**
+   * @param string $small
+   */
   protected static function endsWith($big, $small) {
     $len = strlen($small);
     if ($len === 0) {

Spacing +16 added lines, -16 removed lines

@@ -98,11 +98,11 @@ 
    * @return string The string representation of the error
    */
   public function __toString() {
-    $str = $this->getType() . ': ';
+    $str = $this->getType().': ';
     if ($this->code != 0) {
-      $str .= $this->code . ': ';
+      $str .= $this->code.': ';
     }
-    return $str . $this->message;
+    return $str.$this->message;
   }
 }
 
@@ -530,7 +530,7 @@ 
       if (array_key_exists('user_id', $signed_request)) {
         $user = $signed_request['user_id'];
 
-        if($user != $this->getPersistentData('user_id')){
+        if ($user != $this->getPersistentData('user_id')) {
           $this->clearAllPersistentData();
         }
 
@@ -576,7 +576,7 @@ 
    * @param array $params Provide custom parameters
    * @return string The URL for the login flow
    */
-  public function getLoginUrl($params=array()) {
+  public function getLoginUrl($params = array()) {
     $this->establishCSRFTokenState();
     $currentUrl = $this->getCurrentUrl();
 
@@ -605,7 +605,7 @@ 
    * @param array $params Provide custom parameters
    * @return string The URL for the logout flow
    */
-  public function getLogoutUrl($params=array()) {
+  public function getLogoutUrl($params = array()) {
     return $this->getUrl(
       'www',
       'logout.php',
@@ -627,7 +627,7 @@ 
    * @param array $params Provide custom parameters
    * @return string The URL for the logout flow
    */
-  public function getLoginStatusUrl($params=array()) {
+  public function getLoginStatusUrl($params = array()) {
     return $this->getUrl(
       'www',
       'extern/login_status.php',
@@ -937,7 +937,7 @@ 
    *
    * @return string The response text
    */
-  protected function makeRequest($url, $params, $ch=null) {
+  protected function makeRequest($url, $params, $ch = null) {
     if (!$ch) {
       $ch = curl_init();
     }
@@ -967,7 +967,7 @@ 
       self::errorLog('Invalid or no certificate authority found, '.
                      'using bundled information');
       curl_setopt($ch, CURLOPT_CAINFO,
-                  dirname(__FILE__) . '/fb_ca_chain_bundle.crt');
+                  dirname(__FILE__).'/fb_ca_chain_bundle.crt');
       $result = curl_exec($ch);
     }
 
@@ -1020,7 +1020,7 @@ 
 
     if (strtoupper($data['algorithm']) !== self::SIGNED_REQUEST_ALGORITHM) {
       self::errorLog(
-        'Unknown algorithm. Expected ' . self::SIGNED_REQUEST_ALGORITHM);
+        'Unknown algorithm. Expected '.self::SIGNED_REQUEST_ALGORITHM);
       return null;
     }
 
@@ -1044,7 +1044,7 @@ 
   protected function makeSignedRequest($data) {
     if (!is_array($data)) {
       throw new InvalidArgumentException(
-        'makeSignedRequest expects an array. Got: ' . print_r($data, true));
+        'makeSignedRequest expects an array. Got: '.print_r($data, true));
     }
     $data['algorithm'] = self::SIGNED_REQUEST_ALGORITHM;
     $data['issued_at'] = time();
@@ -1141,7 +1141,7 @@ 
    *
    * @return string The URL for the given parameters
    */
-  protected function getUrl($name, $path='', $params=array()) {
+  protected function getUrl($name, $path = '', $params = array()) {
     $url = self::$DOMAIN_MAP[$name];
     if ($path) {
       if ($path[0] === '/') {
@@ -1150,7 +1150,7 @@ 
       $url .= $path;
     }
     if ($params) {
-      $url .= '?' . http_build_query($params, null, '&');
+      $url .= '?'.http_build_query($params, null, '&');
     }
 
     return $url;
@@ -1206,7 +1206,7 @@ 
    * @return string The current URL
    */
   protected function getCurrentUrl() {
-    $protocol = $this->getHttpProtocol() . '://';
+    $protocol = $this->getHttpProtocol().'://';
     $host = $this->getHttpHost();
     $currentUrl = $protocol.$host.$_SERVER['REQUEST_URI'];
     $parts = parse_url($currentUrl);
@@ -1232,10 +1232,10 @@ 
       isset($parts['port']) &&
       (($protocol === 'http://' && $parts['port'] !== 80) ||
        ($protocol === 'https://' && $parts['port'] !== 443))
-      ? ':' . $parts['port'] : '';
+      ? ':'.$parts['port'] : '';
 
     // rebuild
-    return $protocol . $parts['host'] . $port . $parts['path'] . $query;
+    return $protocol.$parts['host'].$port.$parts['path'].$query;
   }
 
   /**

bundles/ext/facebook/facebook.php

Doc Comments +3 added lines

@@ -150,6 +150,9 @@
     return self::FBSS_COOKIE_NAME . '_' . $this->getAppId();
   }
 
+  /**
+   * @param string $key
+   */
   protected function constructSessionVariableName($key) {
     $parts = array('fb', $this->getAppId(), $key);
     if ($this->sharedSessionID) {

Spacing +1 added lines, -1 removed lines

@@ -147,7 +147,7 @@
   }
 
   protected function getSharedSessionCookieName() {
-    return self::FBSS_COOKIE_NAME . '_' . $this->getAppId();
+    return self::FBSS_COOKIE_NAME.'_'.$this->getAppId();
   }
 
   protected function constructSessionVariableName($key) {

bundles/lib/Cache/File.php

Doc Comments +2 added lines, -3 removed lines

@@ -97,7 +97,7 @@ 
 	 *
 	 * @access public
 	 * @param  string $sName name of the session
-	 * @return mixed
+	 * @return boolean
 	 */
 	public function delete(string $sName)
 	{
@@ -108,7 +108,6 @@ 
 	 * flush the cache
 	 *
 	 * @access public
-	 * @param  string $sName name of the session
 	 * @return mixed
 	 */
 	public function flush()
@@ -121,7 +120,7 @@ 
 	 *
 	 * @access public
 	 * @param  string $sName name of the session
-	 * @return mixed
+	 * @return string
 	 */
 	private function _getSubDirectory($sName)
 	{

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
 	 * @param  int $iTimeout expiration of cache
 	 * @return mixed
 	 */
-	public function get(string $sName, int &$iFlags = null, int $iTimeout = 0)
+	public function get(string $sName, int&$iFlags = null, int $iTimeout = 0)
 	{ 
 	    return parent::get($sName);
 	}

bundles/lib/Cache/Mock.php

Doc Comments +5 added lines, -6 removed lines

@@ -37,7 +37,7 @@ 
 	 * @param  string $sName name of the session
 	 * @param  int $iFlags flags
 	 * @param  int $iTimeout expiration of cache
-	 * @return mixed
+	 * @return boolean
 	 */
 	public function get(string $sName, int &$iFlags = null, int $iTimeout = 0)
 	{ 
@@ -52,7 +52,7 @@ 
 	 * @param  mixed $mValue value of this sesion var
 	 * @param  int $iFlag unused
 	 * @param  int $iExpire expiration of cache
-	 * @return \Venus\lib\Cache\Apc
+	 * @return boolean
 	 */
 	public function set(string $sName, $mValue, int $iFlag = 0, int $iExpire = false)
 	{ 
@@ -63,7 +63,7 @@ 
 	 * flush the cache
 	 *
 	 * @access public
-	 * @return mixed
+	 * @return boolean
 	 */
 	public function flush()
 	{
@@ -75,7 +75,7 @@ 
 	 *
 	 * @access public
 	 * @param  string $sName name of the session
-	 * @return mixed
+	 * @return boolean
 	 */
 	public function delete(string $sName)
 	{
@@ -88,9 +88,8 @@ 
 	 * @access public
 	 * @param  string $sName name of the session
 	 * @param  mixed $mValue value of this sesion var
-	 * @param  int $iFlag unused
 	 * @param  int $iExpire expiration of cache
-	 * @return mixed
+	 * @return boolean
 	 */
 	public function add($sName, $mValue, $iExpire = false)
 	{ 

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
 	 * @param  int $iTimeout expiration of cache
 	 * @return mixed
 	 */
-	public function get(string $sName, int &$iFlags = null, int $iTimeout = 0)
+	public function get(string $sName, int&$iFlags = null, int $iTimeout = 0)
 	{ 
 	    return parent::get($sName);
 	}