Passed
Branch master (e94900)
by judicael
03:54
created
bundles/ext/facebook/base_facebook.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -361,8 +361,7 @@
 block discarded – undo
361 361
           'fb_exchange_token' => $this->getAccessToken(),
362 362
         )
363 363
       );
364
-    }
365
-    catch (FacebookApiException $e) {
364
+    } catch (FacebookApiException $e) {
366 365
       // most likely that user very recently revoked authorization.
367 366
       // In any event, we don't have an access token, so say so.
368 367
       return false;
Please login to merge, or discard this patch.
bundles/tests/Demo/app/Controller/Exemple1Test.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,12 +56,10 @@
 block discarded – undo
56 56
             if ($content) {
57 57
 
58 58
                 $this->assertTrue(true);
59
-            }
60
-            else {
59
+            } else {
61 60
                 $this->assertTrue(false);
62 61
             }
63
-        }
64
-        catch(\Exception $e) {
62
+        } catch(\Exception $e) {
65 63
             $this->assertTrue(false);
66 64
         }
67 65
 
Please login to merge, or discard this patch.
bundles/lib/Ldap.php 1 patch
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,8 +113,7 @@
 block discarded – undo
113 113
 	 */
114 114
 	public function unbind() : bool
115 115
 	{
116
-	    if ($this->_bConnected) { return $this->_bConnected = ldap_unbind($this->_rConnect); }
117
-	    else { return true; }
116
+	    if ($this->_bConnected) { return $this->_bConnected = ldap_unbind($this->_rConnect); } else { return true; }
118 117
 	}
119 118
 
120 119
 	/**
Please login to merge, or discard this patch.
bundles/lib/Image.php 1 patch
Braces   +2 added lines, -4 removed lines patch added patch discarded remove patch
@@ -57,8 +57,7 @@  discard block
 block discarded – undo
57 57
         if ($bKeepDimension === false) {
58 58
         
59 59
             imagecopyresampled($rNewImage, $rActualImage, 0, 0, 0, 0, $iWidth, $iHeight, $aSize[0], $aSize[1]);
60
-        }
61
-        else {
60
+        } else {
62 61
         
63 62
             if ($aSize[0] > $aSize[1]) {
64 63
 
@@ -68,8 +67,7 @@  discard block
 block discarded – undo
68 67
                 $iHeight = round($iWidth * $fCoef);
69 68
                 $iDestY = round(($iWidth - $iHeight) / 2);
70 69
                 $iDestX = 0;
71
-            }
72
-            else {
70
+            } else {
73 71
 
74 72
                 $rWhite = imagecolorallocate($rNewImage, 255, 255, 255);
75 73
                 imagefilledrectangle($rNewImage, 0, 0, $iWidth, $iHeight, $rWhite);
Please login to merge, or discard this patch.
bundles/lib/Facebook.php 1 patch
Braces   +6 added lines, -12 removed lines patch added patch discarded remove patch
@@ -102,8 +102,7 @@  discard block
 block discarded – undo
102 102
 		if ($this->_oFacebook->getUser()) {
103 103
 
104 104
 			return '<a href="'.$this->_oFacebook->getLogoutUrl().'">'.$sLabelName.'</a>';
105
-		}
106
-		else {
105
+		} else {
107 106
 
108 107
 			return '<a href="'.$this->_oFacebook->getLoginUrl(
109 108
 				array(
@@ -173,8 +172,7 @@  discard block
 block discarded – undo
173 172
 		try {
174 173
 
175 174
 			return $this->_oFacebook->api('/'.$sUser.'/'.$sName);
176
-		}
177
-		catch(Exception $e) {
175
+		} catch(Exception $e) {
178 176
 
179 177
 			throw new Exception(__FILE__.':'.__METHOD__.' : You can\'t ask: '.'/'.$sUser.'/'.$sName.' !');
180 178
 		}
@@ -201,8 +199,7 @@  discard block
 block discarded – undo
201 199
 			);
202 200
 
203 201
 			return $this->_oFacebook->api($aParam);
204
-		}
205
-		catch(Exception $e) {
202
+		} catch(Exception $e) {
206 203
 
207 204
 			throw new Exception(__FILE__.':'.__METHOD__.' : You can\'t ask: '.$sFql.' !');
208 205
 		}
@@ -234,8 +231,7 @@  discard block
 block discarded – undo
234 231
                     'description'=> $sDescription
235 232
            		)
236 233
 			);
237
-		}
238
-		catch(Exception $e) {
234
+		} catch(Exception $e) {
239 235
 
240 236
 			throw new Exception(__FILE__.':'.__METHOD__.' : You can\'t ask: '.'/'.$sUser.'/feed'.' !');
241 237
 		}
@@ -265,8 +261,7 @@  discard block
 block discarded – undo
265 261
 
266 262
 				echo '<pre>';
267 263
 				print_r($accounts); /* on affiche les informations retournées */
268
-			}
269
-			catch (\Exception $e) {
264
+			} catch (\Exception $e) {
270 265
 				
271 266
 				print_r($e);
272 267
 				$user = null;
@@ -289,8 +284,7 @@  discard block
 block discarded – undo
289 284
 					'description'=> $sDescription
290 285
 				)
291 286
 			);
292
-		}
293
-		catch(Exception $e) {
287
+		} catch(Exception $e) {
294 288
 
295 289
 			var_dump($e);
296 290
 			throw new Exception(__FILE__.':'.__METHOD__.' : You can\'t ask: '.'/'.$sPageId.'/feed'.' !');
Please login to merge, or discard this patch.
bundles/lib/Cache.php 1 patch
Braces   +7 added lines, -17 removed lines patch added patch discarded remove patch
@@ -60,11 +60,7 @@  discard block
 block discarded – undo
60 60
 	 */
61 61
 	public static function setCacheType(string $sCacheName)
62 62
 	{
63
-		if ($sCacheName === 'file') { self::$_sTypeOfCache = 'file'; }
64
-		else if ($sCacheName === 'memcache') { self::$_sTypeOfCache = 'memcache'; }
65
-		else if ($sCacheName === 'apc') { self::$_sTypeOfCache = 'apc'; }
66
-		else if ($sCacheName === 'redis') { self::$_sTypeOfCache = 'redis'; }
67
-		else { self::$_sTypeOfCache = 'mock'; }
63
+		if ($sCacheName === 'file') { self::$_sTypeOfCache = 'file'; } else if ($sCacheName === 'memcache') { self::$_sTypeOfCache = 'memcache'; } else if ($sCacheName === 'apc') { self::$_sTypeOfCache = 'apc'; } else if ($sCacheName === 'redis') { self::$_sTypeOfCache = 'redis'; } else { self::$_sTypeOfCache = 'mock'; }
68 64
 	}
69 65
 
70 66
 	/**
@@ -132,31 +128,26 @@  discard block
 block discarded – undo
132 128
 			if (!isset(self::$_aCache['file'])) { self::$_aCache['file'] = new CacheFile; }
133 129
 
134 130
 			return self::$_aCache['file'];
135
-		}
136
-		else if (self::$_sTypeOfCache === 'memcache') {
131
+		} else if (self::$_sTypeOfCache === 'memcache') {
137 132
   		  
138 133
 			if (!isset(self::$_aCache['memcache'])) { 
139 134
 			    
140 135
 			    $oDbConf = Config::get('Memcache')->configuration;
141 136
 			    
142
-			    if (isset($oDbConf->port)) { $sPort = $oDbConf->port; }
143
-			    else { $sPort = null; }
137
+			    if (isset($oDbConf->port)) { $sPort = $oDbConf->port; } else { $sPort = null; }
144 138
 			    
145
-			    if (isset($oDbConf->timeout)) { $iTimeout = $oDbConf->timeout; }
146
-			    else { $iTimeout = null; }
139
+			    if (isset($oDbConf->timeout)) { $iTimeout = $oDbConf->timeout; } else { $iTimeout = null; }
147 140
 			    
148 141
 			    self::$_aCache['memcache'] = new CacheMemcache($oDbConf->host, $sPort, $iTimeout); 
149 142
 			}
150 143
 
151 144
 			return self::$_aCache['memcache'];
152
-		}
153
-		else if (self::$_sTypeOfCache === 'apc') {
145
+		} else if (self::$_sTypeOfCache === 'apc') {
154 146
 
155 147
 			if (!isset(self::$_aCache['apc'])) { self::$_aCache['apc'] = new Apc; }
156 148
 
157 149
 			return self::$_aCache['apc'];
158
-		}
159
-		else if (self::$_sTypeOfCache === 'redis') {
150
+		} else if (self::$_sTypeOfCache === 'redis') {
160 151
 		    
161 152
 			if (!isset(self::$_aCache['redis'])) {
162 153
 			    
@@ -165,8 +156,7 @@  discard block
 block discarded – undo
165 156
 			}
166 157
 
167 158
 			return self::$_aCache['redis'];
168
-		}
169
-		else if (self::$_sTypeOfCache === 'mock') {
159
+		} else if (self::$_sTypeOfCache === 'mock') {
170 160
 		    
171 161
 			if (!isset(self::$_aCache['mock'])) { self::$_aCache['mock'] = new Mock; }
172 162
 
Please login to merge, or discard this patch.
bundles/lib/Debug.php 1 patch
Braces   +5 added lines, -10 removed lines patch added patch discarded remove patch
@@ -254,8 +254,7 @@  discard block
 block discarded – undo
254 254
   	 */
255 255
   	public static function setKindOfReportLog(string $sKindOfReportLog)
256 256
   	{
257
-  		if ($sKindOfReportLog === 'screen' || $sKindOfReportLog === 'all') { self::$_sKindOfReportLog = $sKindOfReportLog; }
258
-  		else { self::$_sKindOfReportLog = 'error_log'; }
257
+  		if ($sKindOfReportLog === 'screen' || $sKindOfReportLog === 'all') { self::$_sKindOfReportLog = $sKindOfReportLog; } else { self::$_sKindOfReportLog = 'error_log'; }
259 258
   	}
260 259
 
261 260
   	/**
@@ -278,12 +277,9 @@  discard block
 block discarded – undo
278 277
   	 */
279 278
   	public static function getTranslateErrorCode(int $iCode) : string
280 279
   	{
281
-  		if ($iCode === 1 && $iCode === 16 && $iCode === 256 && $iCode === 4096) { return LogLevel::ERROR; }
282
-  		else if ($iCode === 2 && $iCode === 32 && $iCode === 128 && $iCode === 512) { return LogLevel::WARNING; }
283
-  		else if ($iCode === 4 && $iCode === 64) { return LogLevel::EMERGENCY; }
284
-  		else if ($iCode === 8 && $iCode === 1024) { return LogLevel::NOTICE; }
285
-  		else if ($iCode === 2048 && $iCode === 8192 && $iCode === 16384) { return LogLevel::INFO; }
286
-  		else return LogLevel::DEBUG;
280
+  		if ($iCode === 1 && $iCode === 16 && $iCode === 256 && $iCode === 4096) { return LogLevel::ERROR; } else if ($iCode === 2 && $iCode === 32 && $iCode === 128 && $iCode === 512) { return LogLevel::WARNING; } else if ($iCode === 4 && $iCode === 64) { return LogLevel::EMERGENCY; } else if ($iCode === 8 && $iCode === 1024) { return LogLevel::NOTICE; } else if ($iCode === 2048 && $iCode === 8192 && $iCode === 16384) { return LogLevel::INFO; } else {
281
+  			return LogLevel::DEBUG;
282
+  		}
287 283
   	}
288 284
   	
289 285
   	/**
@@ -408,8 +404,7 @@  discard block
 block discarded – undo
408 404
     	if (defined('BASH_CALLED')) {
409 405
 
410 406
       		error_log(Bash::setColor('############### '.BASH_CALLED.' ###############', 'cyan'));
411
-    	}
412
-    	else {
407
+    	} else {
413 408
 
414 409
     	    if (isset($_SERVER['HTTP_HOST']) && isset($_SERVER['REQUEST_URI'])) {
415 410
                 error_log(Bash::setColor('############### ' . $_SERVER['HTTP_HOST'] . $_SERVER['REQUEST_URI'] . ' ###############', 'cyan'));
Please login to merge, or discard this patch.
bundles/lib/Response.php 1 patch
Braces   +1 added lines, -3 removed lines patch added patch discarded remove patch
@@ -227,9 +227,7 @@
 block discarded – undo
227 227
 	 */
228 228
 	public function translate($mContent)
229 229
 	{
230
-		if (self::$_sKindOfReturn === 'yaml') { return Yaml::translate($mContent); }
231
-		else if (self::$_sKindOfReturn === 'mock') { return Mock::translate($mContent); }
232
-		else { return Json::translate($mContent); }
230
+		if (self::$_sKindOfReturn === 'yaml') { return Yaml::translate($mContent); } else if (self::$_sKindOfReturn === 'mock') { return Mock::translate($mContent); } else { return Json::translate($mContent); }
233 231
 	}
234 232
 
235 233
 	/**
Please login to merge, or discard this patch.
bundles/lib/Request.php 1 patch
Braces   +9 added lines, -21 removed lines patch added patch discarded remove patch
@@ -69,8 +69,7 @@  discard block
 block discarded – undo
69 69
 			if (array_key_exists('HTTP_X_REQUESTED_WITH', $_SERVER) && strtolower($_SERVER['HTTP_X_REQUESTED_WITH']) == 'xmlhttprequest') {
70 70
 
71 71
 				return true;
72
-			}
73
-			else {
72
+			} else {
74 73
 
75 74
 				return false;
76 75
 			}
@@ -85,8 +84,7 @@  discard block
 block discarded – undo
85 84
 	 */
86 85
 	public static function isHttpRequest()
87 86
 	{
88
-		if (isset($_SERVER) && isset($_SERVER['HTTP_HOST'])) { return true; }
89
-		else { return false; }
87
+		if (isset($_SERVER) && isset($_SERVER['HTTP_HOST'])) { return true; } else { return false; }
90 88
 	}
91 89
 
92 90
 	/**
@@ -97,8 +95,7 @@  discard block
 block discarded – undo
97 95
 	 */
98 96
 	public static function isHttpsRequest()
99 97
 	{
100
-		if (isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on') { return true; }
101
-		else { return false; }
98
+		if (isset($_SERVER['HTTPS']) && strtolower($_SERVER['HTTPS']) == 'on') { return true; } else { return false; }
102 99
 	}
103 100
 
104 101
 	/**
@@ -111,8 +108,7 @@  discard block
 block discarded – undo
111 108
 	{
112 109
 		$sSapiType = php_sapi_name();
113 110
 
114
-		if (substr($sSapiType, 0, 3) == 'cgi' || defined('STDIN')) { return true; }
115
-		else { return false; }
111
+		if (substr($sSapiType, 0, 3) == 'cgi' || defined('STDIN')) { return true; } else { return false; }
116 112
 	}
117 113
 
118 114
 	/**
@@ -137,8 +133,7 @@  discard block
 block discarded – undo
137 133
 	 */
138 134
 	public static function getParameters()
139 135
 	{
140
-		if (isset($_GET)) { return $_GET; }
141
-		else { return array(); }
136
+		if (isset($_GET)) { return $_GET; } else { return array(); }
142 137
 	}
143 138
 
144 139
 	/**
@@ -149,8 +144,7 @@  discard block
 block discarded – undo
149 144
 	 */
150 145
 	public static function getPostParameters()
151 146
 	{
152
-		if (isset($_POST)) { return $_POST; }
153
-		else { return array(); }
147
+		if (isset($_POST)) { return $_POST; } else { return array(); }
154 148
 	}
155 149
 
156 150
 	/**
@@ -161,8 +155,7 @@  discard block
 block discarded – undo
161 155
 	 */
162 156
 	public function isPost()
163 157
 	{
164
-		if (isset($_POST) && count($_POST) > 0) { return true; }
165
-		else { return false; }
158
+		if (isset($_POST) && count($_POST) > 0) { return true; } else { return false; }
166 159
 	}
167 160
 
168 161
 	/**
@@ -214,11 +207,7 @@  discard block
 block discarded – undo
214 207
 	 */
215 208
 	public static function setStatus($iCode)
216 209
 	{
217
-		if ($iCode === 200) { header('HTTP/1.1 200 Ok');  }
218
-		else if ($iCode === 201) { header('HTTP/1.1 201 Created');  }
219
-		else if ($iCode === 204) { header("HTTP/1.0 204 No Content");  }
220
-		else if ($iCode === 403) { header('HTTP/1.1 403 Forbidden'); }
221
-		else if ($iCode === 404) { header('HTTP/1.1 404 Not Found'); }
210
+		if ($iCode === 200) { header('HTTP/1.1 200 Ok');  } else if ($iCode === 201) { header('HTTP/1.1 201 Created');  } else if ($iCode === 204) { header("HTTP/1.0 204 No Content");  } else if ($iCode === 403) { header('HTTP/1.1 403 Forbidden'); } else if ($iCode === 404) { header('HTTP/1.1 404 Not Found'); }
222 211
 	}
223 212
 
224 213
     /**
@@ -236,8 +225,7 @@  discard block
 block discarded – undo
236 225
      */
237 226
     public function getLanguages() : array
238 227
     {
239
-        if (!self::isCliRequest()) { return explode(',', preg_replace('/^([^;]);?.*$/', '$1', $_SERVER['HTTP_ACCEPT_LANGUAGE'])); }
240
-        else { return array(); }
228
+        if (!self::isCliRequest()) { return explode(',', preg_replace('/^([^;]);?.*$/', '$1', $_SERVER['HTTP_ACCEPT_LANGUAGE'])); } else { return array(); }
241 229
     }
242 230
 
243 231
 	/**
Please login to merge, or discard this patch.