Venus\lib\Form\Checkbox

Complexity

Total Complexity

13

Size/Duplication

Total Lines	157
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	getValue()	4	4	1
A	setValue()	5	5	1
A	getValuesChecked()	4	4	1
A	setValuesChecked()	5	5	1
A	getLabel()	4	4	1
A	setLabel()	5	5	1
A	isClicked()	9	9	4
A	fetch()	10	10	2

<?php

/**
 * Manage Form
 *
 * @category  	lib
 * @package		lib\Form
 * @author    	Judicaël Paquet <judicael.paquet@gmail.com>
 * @copyright 	Copyright (c) 2013-2014 PAQUET Judicaël FR Inc. (https://github.com/las93)
 * @license   	https://github.com/las93/venus2/blob/master/LICENSE.md Tout droit réservé à PAQUET Judicaël
 * @version   	Release: 1.0.0
 * @filesource	https://github.com/las93/venus2
 * @link      	https://github.com/las93
 * @since     	1.0
 */
namespace Venus\lib\Form;

/**
 * This class manage the Form
 *
 * @category  	lib
 * @package		lib\Form
 * @author    	Judicaël Paquet <judicael.paquet@gmail.com>
 * @copyright 	Copyright (c) 2013-2014 PAQUET Judicaël FR Inc. (https://github.com/las93)
 * @license   	https://github.com/las93/venus2/blob/master/LICENSE.md Tout droit réservé à PAQUET Judicaël
 * @version   	Release: 1.0.0
 * @filesource	https://github.com/las93/venus2
 * @link      	https://github.com/las93
 * @since     	1.0
 */
class Checkbox extends Common

This class seems to be duplicated in your project.

{
	/**
	 * the name of element
	 *
	 * @access private
	 * @var    string
	 */
	private $_sType = null;
	
	/**
	 * the label of element
	 *
	 * @access private
	 * @var    string
	 */
	private $_sLabel = null;
	
	/**
	 * the value of element
	 *
	 * @access private
	 * @var    string
	 */
	private $_sValue = null;

	/**
	 * the value of the checked element
	 *
	 * @access private
	 * @var    array
	 */
	private $_aValuesChecked = null;

	/**
	 * constructor that it increment (static) for all use
	 *
	 * @access public
	 * @param  string $sName name
	 * @param  string $sLabel label of checkbox
	 * @param  string $sValue value of checkbox
	 * @param  array $aValuesChecked value checked of checkbox
	 */
	public function __construct(string $sName, string $sLabel, string $sValue, array $aValuesChecked = null)
	{
		$this->setName($sName);
		$this->setValue($sValue);
		$this->setValuesChecked($aValuesChecked);

It seems like $aValuesChecked defined by parameter $aValuesChecked on line 74 can also be of type null; however, Venus\lib\Form\Checkbox::setValuesChecked() does only seem to accept array, maybe add an additional type check?

		$this->setLabel($sLabel);
	}

	/**
	 * get the Value
	 *
	 * @access public
	 * @return string
	 */
	public function getValue() : string
	{
		return $this->_sValue;
	}

	/**
	 * set the Value
	 *
	 * @access public
	 * @param  string $sValue Value of input;
	 * @return Checkbox
	 */
	public function setValue(string $sValue) : Checkbox
	{
		$this->_sValue = $sValue;
		return $this;
	}

	/**
	 * get the Value Checked
	 *
	 * @access public
	 * @return array
	 */
	public function getValuesChecked() : array
	{
		return $this->_aValuesChecked;
	}

	/**
	 * set the Value Checked
	 *
	 * @access public
	 * @param  array $aValuesChecked Values of input;
	 * @return Checkbox
	 */
	public function setValuesChecked(array $aValuesChecked) : Checkbox
	{
		$this->_aValuesChecked = $aValuesChecked;
		return $this;
	}

	/**
	 * get the Label
	 *
	 * @access public
	 * @return string
	 */
	public function getLabel() : string
	{
		return $this->_sLabel;
	}

	/**
	 * set the Label
	 *
	 * @access public
	 * @param  string $sLabel Label of input;
	 * @return Checkbox
	 */
	public function setLabel(string $sLabel) : Checkbox
	{
		$this->_sLabel = $sLabel;
		return $this;
	}

	/**
	 * if the button is clicked
	 *
	 * @access public
	 * @param  string $sType type of input;
	 * @return bool
	 */
	public function isClicked(string $sType) : bool

The parameter $sType is not used and could be removed.

	{
		if ($this->getType() === 'submit' || $this->getType() === 'button') {

The method getType() does not seem to exist on object<Venus\lib\Form\Checkbox>.

			if (isset($_POST[$this->getName()])) { return true; }
		}

		return false;
	}

	/**
	 * get the <html>
	 *
	 * @access public
	 * @return string
	 */
	public function fetch() : string
	{
		$sContent = '<input type="checkbox" name="'.$this->getName().'[]" value="'.$this->getValue().'"';

		if (in_array($this->getValue(), $this->getValuesChecked())) { $sContent .= ' checked="checked"'; }
		
		$sContent .= '/> '.$this->getLabel();

		return $sContent;
	}
}