Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class Order |
||
9 | { |
||
10 | use HelperTrait; |
||
11 | |||
12 | /** |
||
13 | * @var OrderRepositoryInterface |
||
14 | */ |
||
15 | protected $orderInfo; |
||
16 | /** |
||
17 | * @var mixed |
||
18 | */ |
||
19 | public $column; |
||
20 | |||
21 | /** |
||
22 | * Order constructor. |
||
23 | * |
||
24 | * @param OrderRepositoryInterface $orderInfo |
||
25 | */ |
||
26 | public function __construct(OrderRepositoryInterface $orderInfo) |
||
31 | |||
32 | /** |
||
33 | * @param Model $model |
||
34 | * |
||
35 | * @return mixed |
||
36 | */ |
||
37 | View Code Duplication | public function increment(Model $model) |
|
49 | |||
50 | /** |
||
51 | * @param Model $model |
||
52 | * |
||
53 | * @return mixed |
||
54 | */ |
||
55 | View Code Duplication | public function decrement(Model $model) |
|
67 | |||
68 | /** |
||
69 | * @param Model $model |
||
70 | * |
||
71 | * @return mixed |
||
72 | */ |
||
73 | public function delete(Model $model) |
||
79 | |||
80 | /** |
||
81 | * @param Model $model |
||
82 | * |
||
83 | * @return mixed |
||
84 | */ |
||
85 | public function toFirst(Model $model) |
||
91 | |||
92 | /** |
||
93 | * @param Model $model |
||
94 | * |
||
95 | * @return mixed |
||
96 | */ |
||
97 | public function toLast(Model $model) |
||
103 | |||
104 | /** |
||
105 | * @param Model $model |
||
106 | * |
||
107 | * @return mixed |
||
108 | */ |
||
109 | public function toMiddle(Model $model) |
||
115 | |||
116 | /** |
||
117 | * @param Model $model1 |
||
118 | * @param Model $model2 |
||
119 | * |
||
120 | * @return mixed |
||
121 | */ |
||
122 | public function switchModels(Model $model1, Model $model2) |
||
128 | |||
129 | /** |
||
130 | * @param Model $model |
||
131 | * @param Model $index1 |
||
132 | * @param Model $index2 |
||
133 | * |
||
134 | * @return mixed |
||
135 | */ |
||
136 | public function switchIndexes(Model $model, $index1, $index2) |
||
142 | } |
||
143 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.