LAG\SmokerBundle\Response\Handler\HtmlHandler::handle()

Complexity

Conditions	7
Paths	9

Size

Total Lines	36
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle(string $routeName, Crawler $crawler, Client $client, array $options = []): void
    {
        $configuration = $this->getConfiguration($routeName);
        $mapping = $this->mappingResolver->resolve($this->getMappingName($routeName), $routeName);

It seems like $this->getMappingName($routeName) can also be of type null; however, parameter $routeName of LAG\SmokerBundle\Url\Requirements\Mapping\MappingResolverInterface::resolve() does only seem to accept string, maybe add an additional type check?

$routeName of type string is incompatible with the type boolean expected by parameter $filterMappingData of LAG\SmokerBundle\Url\Requirements\Mapping\MappingResolverInterface::resolve().

        foreach ($configuration as $selector => $content) {
            if ($this->isDynamicString($content)) {
                /** @var Response $response */
                $response = $client->getResponse();

The assignment to $response is dead and can be removed.

                $requirements = [];
                //$response->getHeader();

                foreach ($this->requirementsProviderRegistry->all() as $requirementsProvider) {
                    if (!$requirementsProvider->supports($routeName)) {
                        continue;
                    }
                    $requirements = array_merge($requirements, $requirementsProvider->getRequirements($routeName));
                }
                $criteria = [];

The assignment to $criteria is dead and can be removed.

                foreach ($requirements as $requirement) {

                }




                var_dump($mapping, $client->getResponse());

var_dump($mapping, $client->getResponse()) looks like debug code. Are you sure you do not want to remove it?

                die;

Using exit here is not recommended.

//                $provider = $this->registry->get('default');
//                $provider->getRequirements($routeName, [
//                    'where' => '',
//                ]);
            } else {
                if (false === strpos($crawler->filter($selector)->text(), $content)) {
                    throw new Exception();
                }