LAG\SmokerBundle\Response\Handler\HtmlHandler::handle()

Complexity

Conditions	11
Paths	15

Size

Total Lines	62
Code Lines	32

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function handle(string $routeName, Crawler $crawler, Client $client, array $options = []): void
    {
        $configuration = $this->getConfiguration($routeName);
        $mapping = $this->mappingResolver->resolve($this->getMappingName($routeName), $routeName);

$routeName of type string is incompatible with the type boolean expected by parameter $filterMappingData of LAG\SmokerBundle\Url\Requirements\Mapping\MappingResolverInterface::resolve().

It seems like $this->getMappingName($routeName) can also be of type null; however, parameter $routeName of LAG\SmokerBundle\Url\Requirements\Mapping\MappingResolverInterface::resolve() does only seem to accept string, maybe add an additional type check?

The assignment to $mapping is dead and can be removed.

        foreach ($configuration as $selector => $content) {
            if ($this->isDynamicString($content)) {
                /** @var Response $response */
                $response = $client->getResponse();

The assignment to $response is dead and can be removed.

                $requirements = [];
                /** @var UrlInfo $test */
                $test = $options['url_info'];
                //$response->getHeader();

                foreach ($this->requirementsProviderRegistry->all() as $requirementsProvider) {
                    if (!$requirementsProvider->supports($routeName)) {
                        continue;
                    }
                    $criteria = [];
                    $requirements = array_merge($requirements, $requirementsProvider->getRequirements($routeName));

The assignment to $requirements is dead and can be removed.

                    foreach ($requirementsProvider->getRequirements($routeName) as $requirement => $default) {
                        if (!key_exists($requirement, $test->getExtra())) {
                            continue;
                        }
                        $criteria[$requirement] = $test->getExtra()[$requirement];
                    }

                    $lol = $requirementsProvider->getRequirementsData($routeName, [
                        'where' => $criteria,
                    ]);
                    var_dump($criteria);

var_dump($criteria) looks like debug code. Are you sure you do not want to remove it?

                    foreach ($lol as $item) {
                        var_dump($item);

                    }
                    die;

Using exit here is not recommended.

                }

                $criteria = [];
//                var_dump($requirements);
//                die('ko');

                //$t = $this->urlProviderRegistry->match();

                foreach ($requirements as $requirement => $default) {
                    if (!key_exists($requirement, $test->getExtra())) {
                        continue;
                    }
                    $criteria[$requirement] = $test->getExtra()[$requirement];
                }

                var_dump($criteria);
                die;

Using exit here is not recommended.

//                $provider = $this->registry->get('default');
//                $provider->getRequirements($routeName, [
//                    'where' => '',
//                ]);
            } else {
                if (false === strpos($crawler->filter($selector)->text(), $content)) {
                    throw new Exception();
                }